From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD986C433F5 for ; Mon, 24 Jan 2022 16:08:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243414AbiAXQIT (ORCPT ); Mon, 24 Jan 2022 11:08:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236170AbiAXQIT (ORCPT ); Mon, 24 Jan 2022 11:08:19 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DAA8DC06173B for ; Mon, 24 Jan 2022 08:08:18 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 83026614EC for ; Mon, 24 Jan 2022 16:08:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 609B0C340E7; Mon, 24 Jan 2022 16:08:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643040497; bh=0WOim5nTdCqqMD1vLy/tY7GpuD/pq5Dicfb2VhedgFs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GDSyagsl3G9yUt3zTXLfWJgKLzG+WbMeKu5sd+FxRKz5PfEHQRcn/dyRzFaMxx3X9 kskvUcxtS1aK9YtpVD1TT+39+AldRhnFmJfLm6dAbjf9m5H3JRTWT9XqlXK7+vRSSK nurOake3awPfDg6eQsZlt5kI99YbwzUl9BCCL9lg= Date: Mon, 24 Jan 2022 17:08:15 +0100 From: Greg KH To: Fabio Estevam Cc: sashal@kernel.org, stable@vger.kernel.org, Kalle Valo Subject: Re: [PATCH stable-5.10] ath10k: Fix the MTU size on QCA9377 SDIO Message-ID: References: <20220124154454.1349296-1-festevam@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220124154454.1349296-1-festevam@denx.de> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Jan 24, 2022 at 12:44:54PM -0300, Fabio Estevam wrote: > [ Upstream commit 09b8cd69edcf2be04a781e1781e98e52a775c9ad ] > > On an imx6dl-pico-pi board with a QCA9377 SDIO chip, simply trying to > connect via ssh to another machine causes: > > [ 55.824159] ath10k_sdio mmc1:0001:1: failed to transmit packet, dropping: -12 > [ 55.832169] ath10k_sdio mmc1:0001:1: failed to submit frame: -12 > [ 55.838529] ath10k_sdio mmc1:0001:1: failed to push frame: -12 > [ 55.905863] ath10k_sdio mmc1:0001:1: failed to transmit packet, dropping: -12 > [ 55.913650] ath10k_sdio mmc1:0001:1: failed to submit frame: -12 > [ 55.919887] ath10k_sdio mmc1:0001:1: failed to push frame: -12 > > , leading to an ssh connection failure. > > One user inspected the size of frames on Wireshark and reported > the followig: > > "I was able to narrow the issue down to the mtu. If I set the mtu for > the wlan0 device to 1486 instead of 1500, the issue does not happen. > > The size of frames that I see on Wireshark is exactly 1500 after > setting it to 1486." > > Clearing the HI_ACS_FLAGS_ALT_DATA_CREDIT_SIZE avoids the problem and > the ssh command works successfully after that. > > Introduce a 'credit_size_workaround' field to ath10k_hw_params for > the QCA9377 SDIO, so that the HI_ACS_FLAGS_ALT_DATA_CREDIT_SIZE > is not set in this case. > > Tested with QCA9377 SDIO with firmware WLAN.TF.1.1.1-00061-QCATFSWPZ-1. > > Fixes: 2f918ea98606 ("ath10k: enable alt data of TX path for sdio") > Signed-off-by: Fabio Estevam > Signed-off-by: Kalle Valo > Link: https://lore.kernel.org/r/20211124131047.713756-1-festevam@denx.de > --- > Hi, > > This is the resolution for the linux-stable 5.10 tree. Now queued up, thanks. greg k-h