From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C41C7C433F5 for ; Thu, 13 Jan 2022 14:18:28 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EB25E81429; Thu, 13 Jan 2022 15:18:26 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=blueri.se Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 6B54E80FCC; Thu, 13 Jan 2022 15:18:25 +0100 (CET) Received: from ams.blueri.se (ams.blueri.se [IPv6:2a03:6000:6f70:601::204]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0D407832EA for ; Thu, 13 Jan 2022 15:18:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=blueri.se Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=patrick@blueri.se Received: from ryzen.fritz.box (p5b0ac7de.dip0.t-ipconnect.de [91.10.199.222]) by ams.blueri.se (OpenSMTPD) with ESMTPSA id c97c77d2 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Thu, 13 Jan 2022 15:18:22 +0100 (CET) Date: Thu, 13 Jan 2022 15:18:20 +0100 From: Patrick Wildt To: Fabio Estevam Cc: Michael Walle , frieder.schrempf@kontron.de, heiko.thiery@gmail.com, hs@denx.de, marcel.ziswiler@toradex.com, peng.fan@oss.nxp.com, sbabic@denx.de, trini@konsulko.com, u-boot@lists.denx.de Subject: Re: [PATCH 3/4] arm64: dts: imx8mm-u-boot.dtsi: fix typo in ddr blob name Message-ID: References: <20220113114250.2656319-1-michael@walle.cc> <20a6a4f25750fa6760f18079b684aee2@walle.cc> <8825c339d0cd37b5801648bb406e1fc5@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8825c339d0cd37b5801648bb406e1fc5@denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Thu, Jan 13, 2022 at 10:40:21AM -0300, Fabio Estevam wrote: > Hi Patrick, > > On 13/01/2022 10:29, Michael Walle wrote: > > > Why don't you just change it to the correct naming then? > > I agree with Michael: node names should use a dash instead of the > underscore. > > dtc complains about it when building with W=2: > > arch/arm/dts/imx8mm-evk.dtb: Warning (node_name_chars_strict): > /binman/u-boot-spl-ddr/1d_dmem: Character '_' not recommended in node name Ok, I'll send a v2 for the patchset in a minute. Cheers, Patrick