All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, clg@kaod.org, danielhb413@gmail.com,
	david@gibson.dropbear.id.au, groug@kaod.org, lvivier@redhat.com
Cc: peter.maydell@linaro.org, quintela@redhat.com
Subject: ppc pbr403 vmstate
Date: Thu, 13 Jan 2022 18:51:56 +0000	[thread overview]
Message-ID: <YeB0zGRC/ct8DAzM@work-vm> (raw)

Hi,
  Is there any easy way of getting a machine where the pbr403 vmstate
would be generated?

  Given my vague understanding of vmstate subsection naming, I think
we need:

diff --git a/target/ppc/machine.c b/target/ppc/machine.c
index 756d8de5d8..e535edb7c4 100644
--- a/target/ppc/machine.c
+++ b/target/ppc/machine.c
@@ -718,7 +718,7 @@ static bool pbr403_needed(void *opaque)
 }
 
 static const VMStateDescription vmstate_pbr403 = {
-    .name = "cpu/pbr403",
+    .name = "cpu/tlb6xx/pbr403",
     .version_id = 1,
     .minimum_version_id = 1,
     .needed = pbr403_needed,

to fit the rule where the name of a subsection is prefixed
by the parent name. (Something a new check I added just triggered).

Dave

-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK



             reply	other threads:[~2022-01-13 19:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-13 18:51 Dr. David Alan Gilbert [this message]
2022-01-13 23:41 ` ppc pbr403 vmstate David Gibson
2022-01-14  7:07   ` Cédric Le Goater
2022-01-17  5:52     ` David Gibson
2022-01-17  9:45       ` Cédric Le Goater
2022-01-17  9:52         ` Dr. David Alan Gilbert
2022-01-17 20:40       ` Peter Maydell
2022-01-18  9:11         ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YeB0zGRC/ct8DAzM@work-vm \
    --to=dgilbert@redhat.com \
    --cc=clg@kaod.org \
    --cc=danielhb413@gmail.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=groug@kaod.org \
    --cc=lvivier@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.