From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04C81C433EF for ; Thu, 13 Jan 2022 18:13:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237499AbiAMSN7 (ORCPT ); Thu, 13 Jan 2022 13:13:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230329AbiAMSN7 (ORCPT ); Thu, 13 Jan 2022 13:13:59 -0500 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9AAEC061574 for ; Thu, 13 Jan 2022 10:13:58 -0800 (PST) Received: by mail-wm1-x32f.google.com with SMTP id p18so4484851wmg.4 for ; Thu, 13 Jan 2022 10:13:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Ac1CW+w8MfEgxRizMp8E6jYlwyEjp+9JFaWkJLpJ2iM=; b=ThwCNTofgwTc+mkoPa9E9G+oiOr9DVUx2+eRNucbih4SSpBVFPTUON7XhTjWTmmHPj rA/82o1e8GfhzDOIWrrirCPtJuivImCkoc9TcLRDDgx4QPoAmZAxTFlALDUVK6sPXpZI KgRUYvzrib/9EoapI7aJ1Wv6IosSAodDphVhtDSbiwLjPS6YttgxDmuYAkiU3rdfPKyH hGQKO4cTJXCVXPuLc7k7I2m6A5GNCU5bFArHJRQq4lyJWSslSvSZ+4sWsogjDr0TK2db +Rq9mWsxmIkwt1kUzNL54DlAwYMF65cXCCb1RBYncxlSwTYc1FmaMUeUW5xQbzFPZWQt y1Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Ac1CW+w8MfEgxRizMp8E6jYlwyEjp+9JFaWkJLpJ2iM=; b=OfaHLkybpcTpdekldeDKBAh82NMntHwfd4zK6dOVqV03uPK0GJNsjhyj5L6hqZRhF4 Q50lvOjUJ3qM7NBlGyaXxUr/zTt/gMF++xYQdWTZd40dXMUX17n+sOxcTuzyUi0sbz39 X2jtd0W/HyuBtIxxxT6L5yVq4IDVWWrqMLEJG3d3rkyesIAz4LF2voRJdXcEsXY3+/m8 pL/RZ1fxxU9gut/9bPf8ey6sXMo29q/kJcCqg62XAJZ9KogbPQYpCZshlH128TpD+XUb OUE++Ieveh91kdNAjAc5AXfMn/F1s2+9qs1GszoqlUbV0HQZWeZplPWKe6ECme7/pH58 QOEw== X-Gm-Message-State: AOAM531NdX7Wp8jzto97Ib0csdzCozO3SdYg1ONciDs62qYMYIS8LqdU d5gO/RosSX+fAOM+gggnQfHSMA== X-Google-Smtp-Source: ABdhPJzqUyLNgOdEdKPDTuYHQxuPVsUPThLVTkhmoJxT2G6rqBuEuWuHe1r1dniZw6b09TiYZKJqmQ== X-Received: by 2002:a05:600c:34c4:: with SMTP id d4mr12271023wmq.53.1642097637217; Thu, 13 Jan 2022 10:13:57 -0800 (PST) Received: from google.com ([31.124.24.179]) by smtp.gmail.com with ESMTPSA id i12sm2598129wrf.100.2022.01.13.10.13.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jan 2022 10:13:56 -0800 (PST) Date: Thu, 13 Jan 2022 18:13:55 +0000 From: Lee Jones To: Jessica Clarke Cc: Zong Li , Michael Turquette , Stephen Boyd , Palmer Dabbelt , Paul Walmsley , linux-clk , linux-riscv Subject: Re: [PATCH v3 RESEND] clk: sifive: Fix W=1 kernel build warning Message-ID: References: <20220107090715.2601-1-zong.li@sifive.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Thu, 13 Jan 2022, Jessica Clarke wrote: > On 13 Jan 2022, at 17:21, Lee Jones wrote: > > > > On Thu, 13 Jan 2022, Zong Li wrote: > > > >> On Wed, Jan 12, 2022 at 5:09 PM Lee Jones wrote: > >>> > >>> On Wed, 12 Jan 2022, Zong Li wrote: > >>> > >>>> On Tue, Jan 11, 2022 at 5:32 PM Lee Jones wrote: > >>>>> > >>>>> On Tue, 11 Jan 2022, Zong Li wrote: > >>>>> > >>>>>> On Mon, Jan 10, 2022 at 5:50 PM Lee Jones wrote: > >>>>>>> > >>>>>>> Please improve the subject line. > >>>>>>> > >>>>>>> If this is a straight revert, the subject line should reflect that. > >>>>>>> > >>>>>>> If not, you need to give us specific information regarding the purpose > >>>>>>> of this patch. Please read the Git log for better, more forthcoming > >>>>>>> examples. > >>>>>>> > >>>>>> > >>>>>> It seems to me that this patch is not a straight revert, it provides > >>>>>> another way to fix the original build warnings, just like > >>>>>> '487dc7bb6a0c' tried to do. I guess the commit message has described > >>>>>> what the original warnings is and what the root cause is, it also > >>>>>> mentioned what is changed in this patch. I'm a bit confused whether we > >>>>>> need to add fixes tag, it looks like that it might cause some > >>>>>> misunderstanding? > >>>>> > >>>>> I think it's the patch description and subject that is causing the > >>>>> misunderstanding. > >>>>> > >>>> > >>>> Yes, the subject should be made better. > >>>> > >>>>> Please help me with a couple of points and I'll help you draft > >>>>> something up. > >>>>> > >>>>> Firstly, what alerted you to the problem you're attempting to solve? > >>>>> > >>>> > >>>> I recently noticed the code was changed, I guess that I was missing > >>>> something there. After tracking the log, I found that there is a build > >>>> warning in the original implementation, and it was already fixed, but > >>>> it seems to me that there are still some situations there, please help > >>>> me to see the following illustration. > >>>> > >>>>>>>> --- a/drivers/clk/sifive/fu540-prci.c > >>>>>>>> +++ b/drivers/clk/sifive/fu540-prci.c > >>>>>>>> @@ -20,7 +20,6 @@ > >>>>>>>> > >>>>>>>> #include > >>>>>>>> > >>>>>>>> -#include "fu540-prci.h" > >>>>> > >>>>> How is this related to the issue/patch? > >>>>> > >>>> > >>>> Let's go back to the version without '487dc7bb6a0c' fix. The > >>>> prci_clk_fu540 variable is defined in sifive-fu540-prci.h header, > >>>> however, fu540-prci.c includes this header but doesn't use this > >>>> variable, so the warnings happen. > >>>> > >>>> The easiest way to do it is just removing this line, then the warning > >>>> could be fixed. But as the '487dc7bb6a0c' or this patch does, the code > >>>> should be improved, the prci_clk_fu540 variable shouldn't be defined > >>>> in the header, it should be moved somewhere. > >>>> > >>>>>>>> +struct prci_clk_desc prci_clk_fu540 = { > >>>>>>>> + .clks = __prci_init_clocks_fu540, > >>>>>>>> + .num_clks = ARRAY_SIZE(__prci_init_clocks_fu540), > >>>>>>>> +}; > >>>>> > >>>>>>>> diff --git a/drivers/clk/sifive/fu540-prci.h b/drivers/clk/sifive/fu540-prci.h > >>>>>>>> index c220677dc010..931d6cad8c1c 100644 > >>>>>>>> --- a/drivers/clk/sifive/fu540-prci.h > >>>>>>>> +++ b/drivers/clk/sifive/fu540-prci.h > >>>>>>>> @@ -7,10 +7,6 @@ > >>>>>>>> +extern struct prci_clk_desc prci_clk_fu540; > >>>>> > >>>>>>>> diff --git a/drivers/clk/sifive/sifive-prci.c b/drivers/clk/sifive/sifive-prci.c > >>>>>>>> index 80a288c59e56..916d2fc28b9c 100644 > >>>>>>>> --- a/drivers/clk/sifive/sifive-prci.c > >>>>>>>> +++ b/drivers/clk/sifive/sifive-prci.c > >>>>>>>> @@ -12,11 +12,6 @@ > >>>>>>>> #include "fu540-prci.h" > >>>>>>>> #include "fu740-prci.h" > >>>>>>>> > >>>>>>>> -static const struct prci_clk_desc prci_clk_fu540 = { > >>>>>>>> - .clks = __prci_init_clocks_fu540, > >>>>>>>> - .num_clks = ARRAY_SIZE(__prci_init_clocks_fu540), > >>>>>>>> -}; > >>>>>>>> - > >>>>> > >>>>> I'm not sure if it's you or I that is missing the point here, but > >>>>> prci_clk_fu540 is used within *this* file itself: > >>>>> > >>>> > >>>> Here is another situation I mentioned at the beginning, if we'd like > >>>> to put prci_clk_fu540 here, prci_clk_fu740 should be put here as well. > >>>> I guess you didn't do that because there is a bug in the original > >>>> code, fu740-prci.c misused the fu540-prci.h, so there is no build > >>>> warning on fu740. FU740 still works correctly by misusing the > >>>> fu540-prci.h header because fu740-prci.c doesn't actually use the > >>>> prci_clk_fu740 variable, like fu540 we talked about earlier. > >>>> > >>>>> static const struct of_device_id sifive_prci_of_match[] = { > >>>>> {.compatible = "sifive,fu540-c000-prci", .data = &prci_clk_fu540}, > >>>>> {.compatible = "sifive,fu740-c000-prci", .data = &prci_clk_fu740}, > >>>>> {} > >>>>> }; > >>>>> > >>>>> So why are you moving it out to somewhere it is *not* used and making > >>>>> it an extern? This sounds like the opposite to what you'd want? > >>>> > >>>> The idea is that sifive-prci.c is the core and common part of PRCI, > >>>> and I'd like to separate the SoCs-dependent part into SoCs-dependent > >>>> files, such as fu540-prci.c and fu740-prci.c. The goal is if we add > >>>> new SoCs in the future, we can just put the SoCs-dependent data > >>>> structure in the new C file, and do as minimum modification as > >>>> possible in the core file (i.e. sifive-prci.c). It might also help us > >>>> to see all SoCs-dependent data in one file, then we don't need to > >>>> cross many files. Putting these two variables in sifive-pric.c is the > >>>> right thing to do, but that is why I separate them and make them > >>>> extern in this patch. > >>> > >>> I can see what you are doing, but I don't think this is the right > >>> thing to do. Please put the struct in the same location as it's > >>> referenced. > >> > >> If we decide to move them into sifive-prci.c (i.e. put it in where > >> it's referenced.), I worried that we might need to move all stuff > >> which are in fu540-prci.c and fu740-prci.c. Because 'prci_clk_fu540' > >> is referenced in sifive-prci.c, whereas '__prci_init_clocks_fu540' is > >> used by 'prci_clk_fu540', and the almost things in fu540-prci.c are > >> used by '__prci_init_clocks_fu540'. It seems to be a little bit > >> difficult to clearly decouple it for modularization which I want to > >> do. What this patch does might be a accepted way, I hope that you can > >> consider it again. > >> > >>> > >>> And yes that should also be the case for prci_clk_fu740 and yes, it > >>> was over-looked because it wasn't causing warnings at build time for > >>> whatever reason. > >>> > >>> IMHO, placing 'struct of_device_id' match tables in headers is also > >>> odd and is likely the real cause of this strange situation. > >> > >> I couldn't see what are you pointing, do you mind give more details > >> about it? It seems to me that the match table is put in C file (i.e. > >> sifive-prci.c). > > > > Oh, sorry, it's a common source file, rather than a header. > > > > Okay, so I went and actually looked at the code this time. > > > > If I were you I would move all of the device specific structs and > > tables into the device specific header files, then delete the device > > specific source (C) files entirely. > > > > There seems to be no good reason for carrying a common source file as > > well as a source file AND header file for each supported device. > > IMHO, that's over-complicating things for no apparent gain. > > The reason it exists the way it does is that the driver uses the header > files shipped and used for the device tree bindings, and they give the > same names to different constants (the first three constants are in > fact the same so don’t clash, but PRCI_CLK_TLCLK is different between > the two), so can’t both be in the same translation unit (at least not > without some gross #undef’ing). In FreeBSD I took the alternate > approach of just defining our own FU540_ and FU740_ namespaced copies > of the constants, as drivers do for most things anyway. That's a sensible approach. One which we use in Linux extensively. -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69FE5C433EF for ; Thu, 13 Jan 2022 18:14:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GI74DUcgGnnZjSWj15qOOoLn0mS9mttIUaJlVBORilo=; b=nimnNaA/wTFijl R/6ZVXKVGZ3BcrcyodMpPu8icZgq/mxH0hDBAe9UF/acVJgVMVsljEAsmLPqZuc+rQSBV8eG5+xd0 gcbubR6CcjtnCBXfsTf5cplFjp6L8qVDUVVoARYHhkZbbpq129mtoV/AR0sIMiFsRKXlMP3ORih05 lk5KFjuebaHak66Qh8OFHmmKS85c/kG+j/C+3coTAEaKQfS534Kqz3/v095QbC9jtjwwf6PyAlzS8 fRzz0NdzYZCk7d9cOMKDCnemFM0jvvPoN+XQH6xfAYdxvkz49uIllRCmksGqe369yZd/JfaCf7djC gS0LMe2dNorthQ6+gnMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n84bq-006qw8-J7; Thu, 13 Jan 2022 18:14:02 +0000 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n84bn-006qvU-64 for linux-riscv@lists.infradead.org; Thu, 13 Jan 2022 18:14:02 +0000 Received: by mail-wm1-x336.google.com with SMTP id d187-20020a1c1dc4000000b003474b4b7ebcso4217332wmd.5 for ; Thu, 13 Jan 2022 10:13:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Ac1CW+w8MfEgxRizMp8E6jYlwyEjp+9JFaWkJLpJ2iM=; b=ThwCNTofgwTc+mkoPa9E9G+oiOr9DVUx2+eRNucbih4SSpBVFPTUON7XhTjWTmmHPj rA/82o1e8GfhzDOIWrrirCPtJuivImCkoc9TcLRDDgx4QPoAmZAxTFlALDUVK6sPXpZI KgRUYvzrib/9EoapI7aJ1Wv6IosSAodDphVhtDSbiwLjPS6YttgxDmuYAkiU3rdfPKyH hGQKO4cTJXCVXPuLc7k7I2m6A5GNCU5bFArHJRQq4lyJWSslSvSZ+4sWsogjDr0TK2db +Rq9mWsxmIkwt1kUzNL54DlAwYMF65cXCCb1RBYncxlSwTYc1FmaMUeUW5xQbzFPZWQt y1Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Ac1CW+w8MfEgxRizMp8E6jYlwyEjp+9JFaWkJLpJ2iM=; b=M36oryyVtKxpKuPHa4ZOY41GsUkwt1tDP+gMVV9kEUy8RZYJyiYehHA/bhNMoi50o7 KgCydH9uZl5bRmCfO3Nx0mXFr6JDto9Hd/un06h4bI+zwR/CghEHIC5F32kaxH4wxGit lqtuIqCkGa6btXKCW+xN7BX8aP9NJmkXBE+rkI8bjehooRa3uyRqINxoHM35kTFoRfq1 pfRbk6AIyJGycdDVRtW6Vxz25NCIJnMn1D9axGivh/bAuR4ZbAYJYLs0IHNmu2KAcsJm hpncXM3TXmLMTLC3A5940TLSxxqxISrRWqyutdxQxW/S3yjvn+obHviE95Xc3DM0pk4M +2dQ== X-Gm-Message-State: AOAM531vxBdXO6C0jfFr1bgUvHx4MSV03PNzTnLfBWElKibHcVo8KH0K fIoulyjfJzVYvvKNrj5at2Fw4IZANtFYRA== X-Google-Smtp-Source: ABdhPJzqUyLNgOdEdKPDTuYHQxuPVsUPThLVTkhmoJxT2G6rqBuEuWuHe1r1dniZw6b09TiYZKJqmQ== X-Received: by 2002:a05:600c:34c4:: with SMTP id d4mr12271023wmq.53.1642097637217; Thu, 13 Jan 2022 10:13:57 -0800 (PST) Received: from google.com ([31.124.24.179]) by smtp.gmail.com with ESMTPSA id i12sm2598129wrf.100.2022.01.13.10.13.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jan 2022 10:13:56 -0800 (PST) Date: Thu, 13 Jan 2022 18:13:55 +0000 From: Lee Jones To: Jessica Clarke Cc: Zong Li , Michael Turquette , Stephen Boyd , Palmer Dabbelt , Paul Walmsley , linux-clk , linux-riscv Subject: Re: [PATCH v3 RESEND] clk: sifive: Fix W=1 kernel build warning Message-ID: References: <20220107090715.2601-1-zong.li@sifive.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220113_101359_292365_FB81AE55 X-CRM114-Status: GOOD ( 66.41 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gVGh1LCAxMyBKYW4gMjAyMiwgSmVzc2ljYSBDbGFya2Ugd3JvdGU6Cgo+IE9uIDEzIEphbiAy MDIyLCBhdCAxNzoyMSwgTGVlIEpvbmVzIDxsZWUuam9uZXNAbGluYXJvLm9yZz4gd3JvdGU6Cj4g PiAKPiA+IE9uIFRodSwgMTMgSmFuIDIwMjIsIFpvbmcgTGkgd3JvdGU6Cj4gPiAKPiA+PiBPbiBX ZWQsIEphbiAxMiwgMjAyMiBhdCA1OjA5IFBNIExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5v cmc+IHdyb3RlOgo+ID4+PiAKPiA+Pj4gT24gV2VkLCAxMiBKYW4gMjAyMiwgWm9uZyBMaSB3cm90 ZToKPiA+Pj4gCj4gPj4+PiBPbiBUdWUsIEphbiAxMSwgMjAyMiBhdCA1OjMyIFBNIExlZSBKb25l cyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+IHdyb3RlOgo+ID4+Pj4+IAo+ID4+Pj4+IE9uIFR1ZSwg MTEgSmFuIDIwMjIsIFpvbmcgTGkgd3JvdGU6Cj4gPj4+Pj4gCj4gPj4+Pj4+IE9uIE1vbiwgSmFu IDEwLCAyMDIyIGF0IDU6NTAgUE0gTGVlIEpvbmVzIDxsZWUuam9uZXNAbGluYXJvLm9yZz4gd3Jv dGU6Cj4gPj4+Pj4+PiAKPiA+Pj4+Pj4+IFBsZWFzZSBpbXByb3ZlIHRoZSBzdWJqZWN0IGxpbmUu Cj4gPj4+Pj4+PiAKPiA+Pj4+Pj4+IElmIHRoaXMgaXMgYSBzdHJhaWdodCByZXZlcnQsIHRoZSBz dWJqZWN0IGxpbmUgc2hvdWxkIHJlZmxlY3QgdGhhdC4KPiA+Pj4+Pj4+IAo+ID4+Pj4+Pj4gSWYg bm90LCB5b3UgbmVlZCB0byBnaXZlIHVzIHNwZWNpZmljIGluZm9ybWF0aW9uIHJlZ2FyZGluZyB0 aGUgcHVycG9zZQo+ID4+Pj4+Pj4gb2YgdGhpcyBwYXRjaC4gIFBsZWFzZSByZWFkIHRoZSBHaXQg bG9nIGZvciBiZXR0ZXIsIG1vcmUgZm9ydGhjb21pbmcKPiA+Pj4+Pj4+IGV4YW1wbGVzLgo+ID4+ Pj4+Pj4gCj4gPj4+Pj4+IAo+ID4+Pj4+PiBJdCBzZWVtcyB0byBtZSB0aGF0IHRoaXMgcGF0Y2gg aXMgbm90IGEgc3RyYWlnaHQgcmV2ZXJ0LCBpdCBwcm92aWRlcwo+ID4+Pj4+PiBhbm90aGVyIHdh eSB0byBmaXggdGhlIG9yaWdpbmFsIGJ1aWxkIHdhcm5pbmdzLCBqdXN0IGxpa2UKPiA+Pj4+Pj4g JzQ4N2RjN2JiNmEwYycgdHJpZWQgdG8gZG8uIEkgZ3Vlc3MgdGhlIGNvbW1pdCBtZXNzYWdlIGhh cyBkZXNjcmliZWQKPiA+Pj4+Pj4gd2hhdCB0aGUgb3JpZ2luYWwgd2FybmluZ3MgaXMgYW5kIHdo YXQgdGhlIHJvb3QgY2F1c2UgaXMsIGl0IGFsc28KPiA+Pj4+Pj4gbWVudGlvbmVkIHdoYXQgaXMg Y2hhbmdlZCBpbiB0aGlzIHBhdGNoLiBJJ20gYSBiaXQgY29uZnVzZWQgd2hldGhlciB3ZQo+ID4+ Pj4+PiBuZWVkIHRvIGFkZCBmaXhlcyB0YWcsIGl0IGxvb2tzIGxpa2UgdGhhdCBpdCBtaWdodCBj YXVzZSBzb21lCj4gPj4+Pj4+IG1pc3VuZGVyc3RhbmRpbmc/Cj4gPj4+Pj4gCj4gPj4+Pj4gSSB0 aGluayBpdCdzIHRoZSBwYXRjaCBkZXNjcmlwdGlvbiBhbmQgc3ViamVjdCB0aGF0IGlzIGNhdXNp bmcgdGhlCj4gPj4+Pj4gbWlzdW5kZXJzdGFuZGluZy4KPiA+Pj4+PiAKPiA+Pj4+IAo+ID4+Pj4g WWVzLCB0aGUgc3ViamVjdCBzaG91bGQgYmUgbWFkZSBiZXR0ZXIuCj4gPj4+PiAKPiA+Pj4+PiBQ bGVhc2UgaGVscCBtZSB3aXRoIGEgY291cGxlIG9mIHBvaW50cyBhbmQgSSdsbCBoZWxwIHlvdSBk cmFmdAo+ID4+Pj4+IHNvbWV0aGluZyB1cC4KPiA+Pj4+PiAKPiA+Pj4+PiBGaXJzdGx5LCB3aGF0 IGFsZXJ0ZWQgeW91IHRvIHRoZSBwcm9ibGVtIHlvdSdyZSBhdHRlbXB0aW5nIHRvIHNvbHZlPwo+ ID4+Pj4+IAo+ID4+Pj4gCj4gPj4+PiBJIHJlY2VudGx5IG5vdGljZWQgdGhlIGNvZGUgd2FzIGNo YW5nZWQsIEkgZ3Vlc3MgdGhhdCBJIHdhcyBtaXNzaW5nCj4gPj4+PiBzb21ldGhpbmcgdGhlcmUu IEFmdGVyIHRyYWNraW5nIHRoZSBsb2csIEkgZm91bmQgdGhhdCB0aGVyZSBpcyBhIGJ1aWxkCj4g Pj4+PiB3YXJuaW5nIGluIHRoZSBvcmlnaW5hbCBpbXBsZW1lbnRhdGlvbiwgYW5kIGl0IHdhcyBh bHJlYWR5IGZpeGVkLCBidXQKPiA+Pj4+IGl0IHNlZW1zIHRvIG1lIHRoYXQgdGhlcmUgYXJlIHN0 aWxsIHNvbWUgc2l0dWF0aW9ucyB0aGVyZSwgcGxlYXNlIGhlbHAKPiA+Pj4+IG1lIHRvIHNlZSB0 aGUgZm9sbG93aW5nIGlsbHVzdHJhdGlvbi4KPiA+Pj4+IAo+ID4+Pj4+Pj4+IC0tLSBhL2RyaXZl cnMvY2xrL3NpZml2ZS9mdTU0MC1wcmNpLmMKPiA+Pj4+Pj4+PiArKysgYi9kcml2ZXJzL2Nsay9z aWZpdmUvZnU1NDAtcHJjaS5jCj4gPj4+Pj4+Pj4gQEAgLTIwLDcgKzIwLDYgQEAKPiA+Pj4+Pj4+ PiAKPiA+Pj4+Pj4+PiAjaW5jbHVkZSA8ZHQtYmluZGluZ3MvY2xvY2svc2lmaXZlLWZ1NTQwLXBy Y2kuaD4KPiA+Pj4+Pj4+PiAKPiA+Pj4+Pj4+PiAtI2luY2x1ZGUgImZ1NTQwLXByY2kuaCIKPiA+ Pj4+PiAKPiA+Pj4+PiBIb3cgaXMgdGhpcyByZWxhdGVkIHRvIHRoZSBpc3N1ZS9wYXRjaD8KPiA+ Pj4+PiAKPiA+Pj4+IAo+ID4+Pj4gTGV0J3MgZ28gYmFjayB0byB0aGUgdmVyc2lvbiB3aXRob3V0 ICc0ODdkYzdiYjZhMGMnIGZpeC4gVGhlCj4gPj4+PiBwcmNpX2Nsa19mdTU0MCB2YXJpYWJsZSBp cyBkZWZpbmVkIGluIHNpZml2ZS1mdTU0MC1wcmNpLmggaGVhZGVyLAo+ID4+Pj4gaG93ZXZlciwg ZnU1NDAtcHJjaS5jIGluY2x1ZGVzIHRoaXMgaGVhZGVyIGJ1dCBkb2Vzbid0IHVzZSB0aGlzCj4g Pj4+PiB2YXJpYWJsZSwgc28gdGhlIHdhcm5pbmdzIGhhcHBlbi4KPiA+Pj4+IAo+ID4+Pj4gVGhl IGVhc2llc3Qgd2F5IHRvIGRvIGl0IGlzIGp1c3QgcmVtb3ZpbmcgdGhpcyBsaW5lLCB0aGVuIHRo ZSB3YXJuaW5nCj4gPj4+PiBjb3VsZCBiZSBmaXhlZC4gQnV0IGFzIHRoZSAnNDg3ZGM3YmI2YTBj JyBvciB0aGlzIHBhdGNoIGRvZXMsIHRoZSBjb2RlCj4gPj4+PiBzaG91bGQgYmUgaW1wcm92ZWQs IHRoZSBwcmNpX2Nsa19mdTU0MCB2YXJpYWJsZSBzaG91bGRuJ3QgYmUgZGVmaW5lZAo+ID4+Pj4g aW4gdGhlIGhlYWRlciwgaXQgc2hvdWxkIGJlIG1vdmVkIHNvbWV3aGVyZS4KPiA+Pj4+IAo+ID4+ Pj4+Pj4+ICtzdHJ1Y3QgcHJjaV9jbGtfZGVzYyBwcmNpX2Nsa19mdTU0MCA9IHsKPiA+Pj4+Pj4+ PiArICAgICAuY2xrcyA9IF9fcHJjaV9pbml0X2Nsb2Nrc19mdTU0MCwKPiA+Pj4+Pj4+PiArICAg ICAubnVtX2Nsa3MgPSBBUlJBWV9TSVpFKF9fcHJjaV9pbml0X2Nsb2Nrc19mdTU0MCksCj4gPj4+ Pj4+Pj4gK307Cj4gPj4+Pj4gCj4gPj4+Pj4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvY2xrL3Np Zml2ZS9mdTU0MC1wcmNpLmggYi9kcml2ZXJzL2Nsay9zaWZpdmUvZnU1NDAtcHJjaS5oCj4gPj4+ Pj4+Pj4gaW5kZXggYzIyMDY3N2RjMDEwLi45MzFkNmNhZDhjMWMgMTAwNjQ0Cj4gPj4+Pj4+Pj4g LS0tIGEvZHJpdmVycy9jbGsvc2lmaXZlL2Z1NTQwLXByY2kuaAo+ID4+Pj4+Pj4+ICsrKyBiL2Ry aXZlcnMvY2xrL3NpZml2ZS9mdTU0MC1wcmNpLmgKPiA+Pj4+Pj4+PiBAQCAtNywxMCArNyw2IEBA Cj4gPj4+Pj4+Pj4gK2V4dGVybiBzdHJ1Y3QgcHJjaV9jbGtfZGVzYyBwcmNpX2Nsa19mdTU0MDsK PiA+Pj4+PiAKPiA+Pj4+Pj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9jbGsvc2lmaXZlL3NpZml2 ZS1wcmNpLmMgYi9kcml2ZXJzL2Nsay9zaWZpdmUvc2lmaXZlLXByY2kuYwo+ID4+Pj4+Pj4+IGlu ZGV4IDgwYTI4OGM1OWU1Ni4uOTE2ZDJmYzI4YjljIDEwMDY0NAo+ID4+Pj4+Pj4+IC0tLSBhL2Ry aXZlcnMvY2xrL3NpZml2ZS9zaWZpdmUtcHJjaS5jCj4gPj4+Pj4+Pj4gKysrIGIvZHJpdmVycy9j bGsvc2lmaXZlL3NpZml2ZS1wcmNpLmMKPiA+Pj4+Pj4+PiBAQCAtMTIsMTEgKzEyLDYgQEAKPiA+ Pj4+Pj4+PiAjaW5jbHVkZSAiZnU1NDAtcHJjaS5oIgo+ID4+Pj4+Pj4+ICNpbmNsdWRlICJmdTc0 MC1wcmNpLmgiCj4gPj4+Pj4+Pj4gCj4gPj4+Pj4+Pj4gLXN0YXRpYyBjb25zdCBzdHJ1Y3QgcHJj aV9jbGtfZGVzYyBwcmNpX2Nsa19mdTU0MCA9IHsKPiA+Pj4+Pj4+PiAtICAgICAuY2xrcyA9IF9f cHJjaV9pbml0X2Nsb2Nrc19mdTU0MCwKPiA+Pj4+Pj4+PiAtICAgICAubnVtX2Nsa3MgPSBBUlJB WV9TSVpFKF9fcHJjaV9pbml0X2Nsb2Nrc19mdTU0MCksCj4gPj4+Pj4+Pj4gLX07Cj4gPj4+Pj4+ Pj4gLQo+ID4+Pj4+IAo+ID4+Pj4+IEknbSBub3Qgc3VyZSBpZiBpdCdzIHlvdSBvciBJIHRoYXQg aXMgbWlzc2luZyB0aGUgcG9pbnQgaGVyZSwgYnV0Cj4gPj4+Pj4gcHJjaV9jbGtfZnU1NDAgaXMg dXNlZCB3aXRoaW4gKnRoaXMqIGZpbGUgaXRzZWxmOgo+ID4+Pj4+IAo+ID4+Pj4gCj4gPj4+PiBI ZXJlIGlzIGFub3RoZXIgc2l0dWF0aW9uIEkgbWVudGlvbmVkIGF0IHRoZSBiZWdpbm5pbmcsIGlm IHdlJ2QgbGlrZQo+ID4+Pj4gdG8gcHV0IHByY2lfY2xrX2Z1NTQwIGhlcmUsIHByY2lfY2xrX2Z1 NzQwIHNob3VsZCBiZSBwdXQgaGVyZSBhcyB3ZWxsLgo+ID4+Pj4gSSBndWVzcyB5b3UgZGlkbid0 IGRvIHRoYXQgYmVjYXVzZSB0aGVyZSBpcyBhIGJ1ZyBpbiB0aGUgb3JpZ2luYWwKPiA+Pj4+IGNv ZGUsIGZ1NzQwLXByY2kuYyBtaXN1c2VkIHRoZSBmdTU0MC1wcmNpLmgsIHNvIHRoZXJlIGlzIG5v IGJ1aWxkCj4gPj4+PiB3YXJuaW5nIG9uIGZ1NzQwLiBGVTc0MCBzdGlsbCB3b3JrcyBjb3JyZWN0 bHkgYnkgbWlzdXNpbmcgdGhlCj4gPj4+PiBmdTU0MC1wcmNpLmggaGVhZGVyIGJlY2F1c2UgZnU3 NDAtcHJjaS5jIGRvZXNuJ3QgYWN0dWFsbHkgdXNlIHRoZQo+ID4+Pj4gcHJjaV9jbGtfZnU3NDAg dmFyaWFibGUsIGxpa2UgZnU1NDAgd2UgdGFsa2VkIGFib3V0IGVhcmxpZXIuCj4gPj4+PiAKPiA+ Pj4+PiBzdGF0aWMgY29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCBzaWZpdmVfcHJjaV9vZl9tYXRj aFtdID0gewo+ID4+Pj4+ICAgICAgICAgey5jb21wYXRpYmxlID0gInNpZml2ZSxmdTU0MC1jMDAw LXByY2kiLCAuZGF0YSA9ICZwcmNpX2Nsa19mdTU0MH0sCj4gPj4+Pj4gICAgICAgICB7LmNvbXBh dGlibGUgPSAic2lmaXZlLGZ1NzQwLWMwMDAtcHJjaSIsIC5kYXRhID0gJnByY2lfY2xrX2Z1NzQw fSwKPiA+Pj4+PiAgICAgICAgIHt9Cj4gPj4+Pj4gfTsKPiA+Pj4+PiAKPiA+Pj4+PiBTbyB3aHkg YXJlIHlvdSBtb3ZpbmcgaXQgb3V0IHRvIHNvbWV3aGVyZSBpdCBpcyAqbm90KiB1c2VkIGFuZCBt YWtpbmcKPiA+Pj4+PiBpdCBhbiBleHRlcm4/ICBUaGlzIHNvdW5kcyBsaWtlIHRoZSBvcHBvc2l0 ZSB0byB3aGF0IHlvdSdkIHdhbnQ/Cj4gPj4+PiAKPiA+Pj4+IFRoZSBpZGVhIGlzIHRoYXQgc2lm aXZlLXByY2kuYyBpcyB0aGUgY29yZSBhbmQgY29tbW9uIHBhcnQgb2YgUFJDSSwKPiA+Pj4+IGFu ZCBJJ2QgbGlrZSB0byBzZXBhcmF0ZSB0aGUgU29Dcy1kZXBlbmRlbnQgcGFydCBpbnRvIFNvQ3Mt ZGVwZW5kZW50Cj4gPj4+PiBmaWxlcywgc3VjaCBhcyBmdTU0MC1wcmNpLmMgYW5kIGZ1NzQwLXBy Y2kuYy4gVGhlIGdvYWwgaXMgaWYgd2UgYWRkCj4gPj4+PiBuZXcgU29DcyBpbiB0aGUgZnV0dXJl LCB3ZSBjYW4ganVzdCBwdXQgdGhlIFNvQ3MtZGVwZW5kZW50IGRhdGEKPiA+Pj4+IHN0cnVjdHVy ZSBpbiB0aGUgbmV3IEMgZmlsZSwgYW5kIGRvIGFzIG1pbmltdW0gbW9kaWZpY2F0aW9uIGFzCj4g Pj4+PiBwb3NzaWJsZSBpbiB0aGUgY29yZSBmaWxlIChpLmUuIHNpZml2ZS1wcmNpLmMpLiBJdCBt aWdodCBhbHNvIGhlbHAgdXMKPiA+Pj4+IHRvIHNlZSBhbGwgU29Dcy1kZXBlbmRlbnQgZGF0YSBp biBvbmUgZmlsZSwgdGhlbiB3ZSBkb24ndCBuZWVkIHRvCj4gPj4+PiBjcm9zcyBtYW55IGZpbGVz LiBQdXR0aW5nIHRoZXNlIHR3byB2YXJpYWJsZXMgaW4gc2lmaXZlLXByaWMuYyBpcyB0aGUKPiA+ Pj4+IHJpZ2h0IHRoaW5nIHRvIGRvLCBidXQgdGhhdCBpcyB3aHkgSSBzZXBhcmF0ZSB0aGVtIGFu ZCBtYWtlIHRoZW0KPiA+Pj4+IGV4dGVybiBpbiB0aGlzIHBhdGNoLgo+ID4+PiAKPiA+Pj4gSSBj YW4gc2VlIHdoYXQgeW91IGFyZSBkb2luZywgYnV0IEkgZG9uJ3QgdGhpbmsgdGhpcyBpcyB0aGUg cmlnaHQKPiA+Pj4gdGhpbmcgdG8gZG8uICBQbGVhc2UgcHV0IHRoZSBzdHJ1Y3QgaW4gdGhlIHNh bWUgbG9jYXRpb24gYXMgaXQncwo+ID4+PiByZWZlcmVuY2VkLgo+ID4+IAo+ID4+IElmIHdlIGRl Y2lkZSB0byBtb3ZlIHRoZW0gaW50byBzaWZpdmUtcHJjaS5jIChpLmUuIHB1dCBpdCBpbiB3aGVy ZQo+ID4+IGl0J3MgcmVmZXJlbmNlZC4pLCBJIHdvcnJpZWQgdGhhdCB3ZSBtaWdodCBuZWVkIHRv IG1vdmUgYWxsIHN0dWZmCj4gPj4gd2hpY2ggYXJlIGluIGZ1NTQwLXByY2kuYyBhbmQgZnU3NDAt cHJjaS5jLiBCZWNhdXNlICdwcmNpX2Nsa19mdTU0MCcKPiA+PiBpcyByZWZlcmVuY2VkIGluIHNp Zml2ZS1wcmNpLmMsIHdoZXJlYXMgJ19fcHJjaV9pbml0X2Nsb2Nrc19mdTU0MCcgaXMKPiA+PiB1 c2VkIGJ5ICdwcmNpX2Nsa19mdTU0MCcsIGFuZCB0aGUgYWxtb3N0IHRoaW5ncyBpbiBmdTU0MC1w cmNpLmMgYXJlCj4gPj4gdXNlZCBieSAnX19wcmNpX2luaXRfY2xvY2tzX2Z1NTQwJy4gSXQgc2Vl bXMgdG8gYmUgYSBsaXR0bGUgYml0Cj4gPj4gZGlmZmljdWx0IHRvIGNsZWFybHkgZGVjb3VwbGUg aXQgZm9yIG1vZHVsYXJpemF0aW9uIHdoaWNoIEkgd2FudCB0bwo+ID4+IGRvLiBXaGF0IHRoaXMg cGF0Y2ggZG9lcyBtaWdodCBiZSBhIGFjY2VwdGVkIHdheSwgSSBob3BlIHRoYXQgeW91IGNhbgo+ ID4+IGNvbnNpZGVyIGl0IGFnYWluLgo+ID4+IAo+ID4+PiAKPiA+Pj4gQW5kIHllcyB0aGF0IHNo b3VsZCBhbHNvIGJlIHRoZSBjYXNlIGZvciBwcmNpX2Nsa19mdTc0MCBhbmQgeWVzLCBpdAo+ID4+ PiB3YXMgb3Zlci1sb29rZWQgYmVjYXVzZSBpdCB3YXNuJ3QgY2F1c2luZyB3YXJuaW5ncyBhdCBi dWlsZCB0aW1lIGZvcgo+ID4+PiB3aGF0ZXZlciByZWFzb24uCj4gPj4+IAo+ID4+PiBJTUhPLCBw bGFjaW5nICdzdHJ1Y3Qgb2ZfZGV2aWNlX2lkJyBtYXRjaCB0YWJsZXMgaW4gaGVhZGVycyBpcyBh bHNvCj4gPj4+IG9kZCBhbmQgaXMgbGlrZWx5IHRoZSByZWFsIGNhdXNlIG9mIHRoaXMgc3RyYW5n ZSBzaXR1YXRpb24uCj4gPj4gCj4gPj4gSSBjb3VsZG4ndCBzZWUgd2hhdCBhcmUgeW91IHBvaW50 aW5nLCBkbyB5b3UgbWluZCBnaXZlIG1vcmUgZGV0YWlscwo+ID4+IGFib3V0IGl0PyBJdCBzZWVt cyB0byBtZSB0aGF0IHRoZSBtYXRjaCB0YWJsZSBpcyBwdXQgaW4gQyBmaWxlIChpLmUuCj4gPj4g c2lmaXZlLXByY2kuYykuCj4gPiAKPiA+IE9oLCBzb3JyeSwgaXQncyBhIGNvbW1vbiBzb3VyY2Ug ZmlsZSwgcmF0aGVyIHRoYW4gYSBoZWFkZXIuCj4gPiAKPiA+IE9rYXksIHNvIEkgd2VudCBhbmQg YWN0dWFsbHkgbG9va2VkIGF0IHRoZSBjb2RlIHRoaXMgdGltZS4KPiA+IAo+ID4gSWYgSSB3ZXJl IHlvdSBJIHdvdWxkIG1vdmUgYWxsIG9mIHRoZSBkZXZpY2Ugc3BlY2lmaWMgc3RydWN0cyBhbmQK PiA+IHRhYmxlcyBpbnRvIHRoZSBkZXZpY2Ugc3BlY2lmaWMgaGVhZGVyIGZpbGVzLCB0aGVuIGRl bGV0ZSB0aGUgZGV2aWNlCj4gPiBzcGVjaWZpYyBzb3VyY2UgKEMpIGZpbGVzIGVudGlyZWx5Lgo+ ID4gCj4gPiBUaGVyZSBzZWVtcyB0byBiZSBubyBnb29kIHJlYXNvbiBmb3IgY2FycnlpbmcgYSBj b21tb24gc291cmNlIGZpbGUgYXMKPiA+IHdlbGwgYXMgYSBzb3VyY2UgZmlsZSBBTkQgaGVhZGVy IGZpbGUgZm9yIGVhY2ggc3VwcG9ydGVkIGRldmljZS4KPiA+IElNSE8sIHRoYXQncyBvdmVyLWNv bXBsaWNhdGluZyB0aGluZ3MgZm9yIG5vIGFwcGFyZW50IGdhaW4uCj4gCj4gVGhlIHJlYXNvbiBp dCBleGlzdHMgdGhlIHdheSBpdCBkb2VzIGlzIHRoYXQgdGhlIGRyaXZlciB1c2VzIHRoZSBoZWFk ZXIKPiBmaWxlcyBzaGlwcGVkIGFuZCB1c2VkIGZvciB0aGUgZGV2aWNlIHRyZWUgYmluZGluZ3Ms IGFuZCB0aGV5IGdpdmUgdGhlCj4gc2FtZSBuYW1lcyB0byBkaWZmZXJlbnQgY29uc3RhbnRzICh0 aGUgZmlyc3QgdGhyZWUgY29uc3RhbnRzIGFyZSBpbgo+IGZhY3QgdGhlIHNhbWUgc28gZG9u4oCZ dCBjbGFzaCwgYnV0IFBSQ0lfQ0xLX1RMQ0xLIGlzIGRpZmZlcmVudCBiZXR3ZWVuCj4gdGhlIHR3 byksIHNvIGNhbuKAmXQgYm90aCBiZSBpbiB0aGUgc2FtZSB0cmFuc2xhdGlvbiB1bml0IChhdCBs ZWFzdCBub3QKPiB3aXRob3V0IHNvbWUgZ3Jvc3MgI3VuZGVm4oCZaW5nKS4gSW4gRnJlZUJTRCBJ IHRvb2sgdGhlIGFsdGVybmF0ZQo+IGFwcHJvYWNoIG9mIGp1c3QgZGVmaW5pbmcgb3VyIG93biBG VTU0MF8gYW5kIEZVNzQwXyBuYW1lc3BhY2VkIGNvcGllcwo+IG9mIHRoZSBjb25zdGFudHMsIGFz IGRyaXZlcnMgZG8gZm9yIG1vc3QgdGhpbmdzIGFueXdheS4KClRoYXQncyBhIHNlbnNpYmxlIGFw cHJvYWNoLgoKT25lIHdoaWNoIHdlIHVzZSBpbiBMaW51eCBleHRlbnNpdmVseS4KCi0tIApMZWUg Sm9uZXMgW+adjueQvOaWr10KUHJpbmNpcGFsIFRlY2huaWNhbCBMZWFkIC0gRGV2ZWxvcGVyIFNl cnZpY2VzCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBcm0gU29DcwpG b2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5nIGxpc3QK bGludXgtcmlzY3ZAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJpc2N2Cg==