All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: kernel test robot <lkp@intel.com>,
	kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	Ingo Molnar <mingo@kernel.org>, Sasha Levin <sashal@kernel.org>
Subject: Re: [linux-stable-rc:linux-5.4.y 2563/9999] arch/ia64/kernel/kprobes.c:401:24: error: implicit declaration of function '__kretprobe_trampoline_handler'; did you mean 'kretprobe_trampoline'?
Date: Fri, 14 Jan 2022 08:04:44 +0100	[thread overview]
Message-ID: <YeEgjJBTCAJE0wS4@kroah.com> (raw)
In-Reply-To: <20220113182533.15c04b3a16f02af34f2cb9e4@kernel.org>

On Thu, Jan 13, 2022 at 06:25:33PM +0900, Masami Hiramatsu wrote:
> On Thu, 13 Jan 2022 04:15:43 +0800
> kernel test robot <lkp@intel.com> wrote:
> 
> > Hi Masami,
> > 
> > FYI, the error/warning still remains.
> > 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> > head:   0a4ce4977bbeea4560a1f32632650b388c834c8a
> > commit: 77fa5e15c933a1ec812de61ad709c00aa51e96ae [2563/9999] ia64: kprobes: Use generic kretprobe trampoline handler
> > config: ia64-randconfig-r002-20220112 (https://download.01.org/0day-ci/archive/20220113/202201130408.tdm9swhk-lkp@intel.com/config)
> > compiler: ia64-linux-gcc (GCC) 11.2.0
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=77fa5e15c933a1ec812de61ad709c00aa51e96ae
> >         git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> >         git fetch --no-tags linux-stable-rc linux-5.4.y
> >         git checkout 77fa5e15c933a1ec812de61ad709c00aa51e96ae
> >         # save the config file to linux build tree
> >         mkdir build_dir
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=ia64 SHELL=/bin/bash
> > 
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> > 
> > All errors (new ones prefixed by >>):
> > 
> >    arch/ia64/kernel/kprobes.c: In function 'get_kprobe_inst':
> >    arch/ia64/kernel/kprobes.c:325:22: warning: variable 'template' set but not used [-Wunused-but-set-variable]
> >      325 |         unsigned int template;
> >          |                      ^~~~~~~~
> 
> OK, this is another issue, which is in the upstream master too.
> 
> >    arch/ia64/kernel/kprobes.c: At top level:
> >    arch/ia64/kernel/kprobes.c:399:15: warning: no previous prototype for 'trampoline_probe_handler' [-Wmissing-prototypes]
> >      399 | int __kprobes trampoline_probe_handler(struct kprobe *p, struct pt_regs *regs)
> >          |               ^~~~~~~~~~~~~~~~~~~~~~~~
> >    arch/ia64/kernel/kprobes.c: In function 'trampoline_probe_handler':
> > >> arch/ia64/kernel/kprobes.c:401:24: error: implicit declaration of function '__kretprobe_trampoline_handler'; did you mean 'kretprobe_trampoline'? [-Werror=implicit-function-declaration]
> >      401 |         regs->cr_iip = __kretprobe_trampoline_handler(regs, kretprobe_trampoline, NULL);
> >          |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >          |                        kretprobe_trampoline
> >    cc1: some warnings being treated as errors
> 
> This seems that the upstream commit e792ff804f49720ce003b3e4c618b5d996256a18
> has been picked to the stable-5.4.y tree accidentally.
> That is a part of lockless kretprobe series and should not be picked to
> the stable tree.
> 
> Greg, can you revert commit 77fa5e15c933a1ec812de61ad709c00aa51e96ae ?
> (Or should I send revert patch?)

I can revert it, thanks.

greg k-h

WARNING: multiple messages have this Message-ID
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: kbuild-all@lists.01.org
Subject: Re: [linux-stable-rc:linux-5.4.y 2563/9999] arch/ia64/kernel/kprobes.c:401:24: error: implicit declaration of function '__kretprobe_trampoline_handler'; did you mean 'kretprobe_trampoline'?
Date: Fri, 14 Jan 2022 08:04:44 +0100	[thread overview]
Message-ID: <YeEgjJBTCAJE0wS4@kroah.com> (raw)
In-Reply-To: <20220113182533.15c04b3a16f02af34f2cb9e4@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 3264 bytes --]

On Thu, Jan 13, 2022 at 06:25:33PM +0900, Masami Hiramatsu wrote:
> On Thu, 13 Jan 2022 04:15:43 +0800
> kernel test robot <lkp@intel.com> wrote:
> 
> > Hi Masami,
> > 
> > FYI, the error/warning still remains.
> > 
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> > head:   0a4ce4977bbeea4560a1f32632650b388c834c8a
> > commit: 77fa5e15c933a1ec812de61ad709c00aa51e96ae [2563/9999] ia64: kprobes: Use generic kretprobe trampoline handler
> > config: ia64-randconfig-r002-20220112 (https://download.01.org/0day-ci/archive/20220113/202201130408.tdm9swhk-lkp(a)intel.com/config)
> > compiler: ia64-linux-gcc (GCC) 11.2.0
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=77fa5e15c933a1ec812de61ad709c00aa51e96ae
> >         git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> >         git fetch --no-tags linux-stable-rc linux-5.4.y
> >         git checkout 77fa5e15c933a1ec812de61ad709c00aa51e96ae
> >         # save the config file to linux build tree
> >         mkdir build_dir
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=ia64 SHELL=/bin/bash
> > 
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> > 
> > All errors (new ones prefixed by >>):
> > 
> >    arch/ia64/kernel/kprobes.c: In function 'get_kprobe_inst':
> >    arch/ia64/kernel/kprobes.c:325:22: warning: variable 'template' set but not used [-Wunused-but-set-variable]
> >      325 |         unsigned int template;
> >          |                      ^~~~~~~~
> 
> OK, this is another issue, which is in the upstream master too.
> 
> >    arch/ia64/kernel/kprobes.c: At top level:
> >    arch/ia64/kernel/kprobes.c:399:15: warning: no previous prototype for 'trampoline_probe_handler' [-Wmissing-prototypes]
> >      399 | int __kprobes trampoline_probe_handler(struct kprobe *p, struct pt_regs *regs)
> >          |               ^~~~~~~~~~~~~~~~~~~~~~~~
> >    arch/ia64/kernel/kprobes.c: In function 'trampoline_probe_handler':
> > >> arch/ia64/kernel/kprobes.c:401:24: error: implicit declaration of function '__kretprobe_trampoline_handler'; did you mean 'kretprobe_trampoline'? [-Werror=implicit-function-declaration]
> >      401 |         regs->cr_iip = __kretprobe_trampoline_handler(regs, kretprobe_trampoline, NULL);
> >          |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >          |                        kretprobe_trampoline
> >    cc1: some warnings being treated as errors
> 
> This seems that the upstream commit e792ff804f49720ce003b3e4c618b5d996256a18
> has been picked to the stable-5.4.y tree accidentally.
> That is a part of lockless kretprobe series and should not be picked to
> the stable tree.
> 
> Greg, can you revert commit 77fa5e15c933a1ec812de61ad709c00aa51e96ae ?
> (Or should I send revert patch?)

I can revert it, thanks.

greg k-h

  reply	other threads:[~2022-01-14  7:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-12 20:15 [linux-stable-rc:linux-5.4.y 2563/9999] arch/ia64/kernel/kprobes.c:401:24: error: implicit declaration of function '__kretprobe_trampoline_handler'; did you mean 'kretprobe_trampoline'? kernel test robot
2022-01-12 20:15 ` kernel test robot
2022-01-13  9:25 ` Masami Hiramatsu
2022-01-13  9:25   ` Masami Hiramatsu
2022-01-14  7:04   ` Greg Kroah-Hartman [this message]
2022-01-14  7:04     ` Greg Kroah-Hartman
2022-01-14  7:09     ` Greg Kroah-Hartman
2022-01-14  7:09       ` Greg Kroah-Hartman
2022-01-14  7:49       ` Masami Hiramatsu
2022-01-14  7:49         ` Masami Hiramatsu
2022-01-14 10:19       ` [PATCH 5.4.y] Revert "ia64: kprobes: Use generic kretprobe trampoline handler" Masami Hiramatsu
2022-01-14 11:00         ` Greg Kroah-Hartman
2022-01-15  4:58         ` kernel test robot
2022-01-15  4:58           ` kernel test robot
2022-01-15 10:13           ` Masami Hiramatsu
2022-01-15 10:13             ` Masami Hiramatsu
2022-01-15 12:59       ` [PATCH v2 " Masami Hiramatsu
2022-01-24 15:09         ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YeEgjJBTCAJE0wS4@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mhiramat@kernel.org \
    --cc=mingo@kernel.org \
    --cc=sashal@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.