From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49267C433FE for ; Fri, 14 Jan 2022 07:09:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236689AbiANHJt (ORCPT ); Fri, 14 Jan 2022 02:09:49 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:56198 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229474AbiANHJs (ORCPT ); Fri, 14 Jan 2022 02:09:48 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C773361D9B for ; Fri, 14 Jan 2022 07:09:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8EF38C36AEA; Fri, 14 Jan 2022 07:09:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1642144187; bh=C00wdp1peOulWwBhFb0l0Euqt2p1KCX4BpOGvNi6bic=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GsI0krqRBomGcrp5QapS3OB7NnZ2ag8WKeq5AYHIcQR60IPVdwl/2dLyAHwmlMfif H58emGiM4qVnN030zIYa8lZJBbJg3ML+yy3vUB/Ub0cSY1ZGQb6tTPsTB+29+9eJ7d UF9Y5QC6BizjqqvkHolZa+pTMjNFYQjPNNe9F81k= Date: Fri, 14 Jan 2022 08:09:44 +0100 From: Greg Kroah-Hartman To: Masami Hiramatsu Cc: kernel test robot , kbuild-all@lists.01.org, linux-kernel@vger.kernel.org, Ingo Molnar , Sasha Levin Subject: Re: [linux-stable-rc:linux-5.4.y 2563/9999] arch/ia64/kernel/kprobes.c:401:24: error: implicit declaration of function '__kretprobe_trampoline_handler'; did you mean 'kretprobe_trampoline'? Message-ID: References: <202201130408.tdm9swhk-lkp@intel.com> <20220113182533.15c04b3a16f02af34f2cb9e4@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 14, 2022 at 08:04:44AM +0100, Greg Kroah-Hartman wrote: > On Thu, Jan 13, 2022 at 06:25:33PM +0900, Masami Hiramatsu wrote: > > On Thu, 13 Jan 2022 04:15:43 +0800 > > kernel test robot wrote: > > > > > Hi Masami, > > > > > > FYI, the error/warning still remains. > > > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y > > > head: 0a4ce4977bbeea4560a1f32632650b388c834c8a > > > commit: 77fa5e15c933a1ec812de61ad709c00aa51e96ae [2563/9999] ia64: kprobes: Use generic kretprobe trampoline handler > > > config: ia64-randconfig-r002-20220112 (https://download.01.org/0day-ci/archive/20220113/202201130408.tdm9swhk-lkp@intel.com/config) > > > compiler: ia64-linux-gcc (GCC) 11.2.0 > > > reproduce (this is a W=1 build): > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > > chmod +x ~/bin/make.cross > > > # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=77fa5e15c933a1ec812de61ad709c00aa51e96ae > > > git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > > > git fetch --no-tags linux-stable-rc linux-5.4.y > > > git checkout 77fa5e15c933a1ec812de61ad709c00aa51e96ae > > > # save the config file to linux build tree > > > mkdir build_dir > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=ia64 SHELL=/bin/bash > > > > > > If you fix the issue, kindly add following tag as appropriate > > > Reported-by: kernel test robot > > > > > > All errors (new ones prefixed by >>): > > > > > > arch/ia64/kernel/kprobes.c: In function 'get_kprobe_inst': > > > arch/ia64/kernel/kprobes.c:325:22: warning: variable 'template' set but not used [-Wunused-but-set-variable] > > > 325 | unsigned int template; > > > | ^~~~~~~~ > > > > OK, this is another issue, which is in the upstream master too. > > > > > arch/ia64/kernel/kprobes.c: At top level: > > > arch/ia64/kernel/kprobes.c:399:15: warning: no previous prototype for 'trampoline_probe_handler' [-Wmissing-prototypes]> > > 399 | int __kprobes trampoline_probe_handler(struct kprobe *p, struct pt_regs *regs) > > > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > > arch/ia64/kernel/kprobes.c: In function 'trampoline_probe_handler': > > > >> arch/ia64/kernel/kprobes.c:401:24: error: implicit declaration of function '__kretprobe_trampoline_handler'; did you mean 'kretprobe_trampoline'? [-Werror=implicit-function-declaration] > > > 401 | regs->cr_iip = __kretprobe_trampoline_handler(regs, kretprobe_trampoline, NULL); > > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > | kretprobe_trampoline > > > cc1: some warnings being treated as errors > > > > This seems that the upstream commit e792ff804f49720ce003b3e4c618b5d996256a18 > > has been picked to the stable-5.4.y tree accidentally. > > That is a part of lockless kretprobe series and should not be picked to > > the stable tree. > > > > Greg, can you revert commit 77fa5e15c933a1ec812de61ad709c00aa51e96ae ? > > (Or should I send revert patch?) > > I can revert it, thanks. No, it does not revert cleanly, it looks like it was needed for another patch. So a series of reverts if you could create them would be great. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============1535498475110510767==" MIME-Version: 1.0 From: Greg Kroah-Hartman To: kbuild-all@lists.01.org Subject: Re: [linux-stable-rc:linux-5.4.y 2563/9999] arch/ia64/kernel/kprobes.c:401:24: error: implicit declaration of function '__kretprobe_trampoline_handler'; did you mean 'kretprobe_trampoline'? Date: Fri, 14 Jan 2022 08:09:44 +0100 Message-ID: In-Reply-To: List-Id: --===============1535498475110510767== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Fri, Jan 14, 2022 at 08:04:44AM +0100, Greg Kroah-Hartman wrote: > On Thu, Jan 13, 2022 at 06:25:33PM +0900, Masami Hiramatsu wrote: > > On Thu, 13 Jan 2022 04:15:43 +0800 > > kernel test robot wrote: > > = > > > Hi Masami, > > > = > > > FYI, the error/warning still remains. > > > = > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-= stable-rc.git linux-5.4.y > > > head: 0a4ce4977bbeea4560a1f32632650b388c834c8a > > > commit: 77fa5e15c933a1ec812de61ad709c00aa51e96ae [2563/9999] ia64: kp= robes: Use generic kretprobe trampoline handler > > > config: ia64-randconfig-r002-20220112 (https://download.01.org/0day-c= i/archive/20220113/202201130408.tdm9swhk-lkp(a)intel.com/config) > > > compiler: ia64-linux-gcc (GCC) 11.2.0 > > > reproduce (this is a W=3D1 build): > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master= /sbin/make.cross -O ~/bin/make.cross > > > chmod +x ~/bin/make.cross > > > # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linu= x-stable-rc.git/commit/?id=3D77fa5e15c933a1ec812de61ad709c00aa51e96ae > > > git remote add linux-stable-rc https://git.kernel.org/pub/scm= /linux/kernel/git/stable/linux-stable-rc.git > > > git fetch --no-tags linux-stable-rc linux-5.4.y > > > git checkout 77fa5e15c933a1ec812de61ad709c00aa51e96ae > > > # save the config file to linux build tree > > > mkdir build_dir > > > COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-11.2.0 make= .cross O=3Dbuild_dir ARCH=3Dia64 SHELL=3D/bin/bash > > > = > > > If you fix the issue, kindly add following tag as appropriate > > > Reported-by: kernel test robot > > > = > > > All errors (new ones prefixed by >>): > > > = > > > arch/ia64/kernel/kprobes.c: In function 'get_kprobe_inst': > > > arch/ia64/kernel/kprobes.c:325:22: warning: variable 'template' se= t but not used [-Wunused-but-set-variable] > > > 325 | unsigned int template; > > > | ^~~~~~~~ > > = > > OK, this is another issue, which is in the upstream master too. > > = > > > arch/ia64/kernel/kprobes.c: At top level: > > > arch/ia64/kernel/kprobes.c:399:15: warning: no previous prototype = for 'trampoline_probe_handler' [-Wmissing-prototypes]> > > 399 | int _= _kprobes trampoline_probe_handler(struct kprobe *p, struct pt_regs *regs) > > > | ^~~~~~~~~~~~~~~~~~~~~~~~ > > > arch/ia64/kernel/kprobes.c: In function 'trampoline_probe_handler': > > > >> arch/ia64/kernel/kprobes.c:401:24: error: implicit declaration of = function '__kretprobe_trampoline_handler'; did you mean 'kretprobe_trampoli= ne'? [-Werror=3Dimplicit-function-declaration] > > > 401 | regs->cr_iip =3D __kretprobe_trampoline_handler(re= gs, kretprobe_trampoline, NULL); > > > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > | kretprobe_trampoline > > > cc1: some warnings being treated as errors > > = > > This seems that the upstream commit e792ff804f49720ce003b3e4c618b5d9962= 56a18 > > has been picked to the stable-5.4.y tree accidentally. > > That is a part of lockless kretprobe series and should not be picked to > > the stable tree. > > = > > Greg, can you revert commit 77fa5e15c933a1ec812de61ad709c00aa51e96ae ? > > (Or should I send revert patch?) > = > I can revert it, thanks. No, it does not revert cleanly, it looks like it was needed for another patch. So a series of reverts if you could create them would be great. thanks, greg k-h --===============1535498475110510767==--