From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32D83C433EF for ; Fri, 14 Jan 2022 17:25:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243873AbiANRZ5 (ORCPT ); Fri, 14 Jan 2022 12:25:57 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:38284 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229758AbiANRZ4 (ORCPT ); Fri, 14 Jan 2022 12:25:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=JwoliXcJ7ab5c8+F4xKeDTkJ6noi7Vx/K/CQ+XG7ErE=; b=Ez6nvfIec49hV3Dsh4GUYRqhWB fGpwDEyw3EXhakHWRoPB9/BpJ9jUnYqugH6S98n+/OQIr1a2ts414G0cdMTQb1mGeBlx5eD1U2mNz A3GK7IJTX7datZmfZaoYS9A4Ue3fDF8a08l7vgZVKs5nk1PsjR9haYe5qtzTXDJcQXcY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1n8QKb-001Qx9-N6; Fri, 14 Jan 2022 18:25:41 +0100 Date: Fri, 14 Jan 2022 18:25:41 +0100 From: Andrew Lunn To: Kai-Heng Feng Cc: peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, "David S. Miller" , Jakub Kicinski , Maxime Coquelin , Heiner Kallweit , Russell King , Marek =?iso-8859-1?Q?Beh=FAn?= , Ivan Bornyakov , Pali =?iso-8859-1?Q?Roh=E1r?= , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] stmmac: intel: Honor phy LED set by system firmware on a Dell hardware Message-ID: References: <20220114040755.1314349-1-kai.heng.feng@canonical.com> <20220114040755.1314349-2-kai.heng.feng@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > This is a PHY property. Why is the MAC involved? > > This is inspired by commit a93f7fe13454 ("net: phy: marvell: add new > default led configure for m88e151x") which passes the flag from MAC to > PHY. But in this case, the MAC does not care what the LEDs are. The platform wants them left alone, not the MAC. > > Please also think about how to make this generic, so any ACPI based > > system can use it, with any PHY. ... > So the only approach I can think of is to use DMI match directly in PHY driver. In the phylib core. And the core then asks the specific PHY driver to not touch the LED configuration. It is then generic. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86247C433F5 for ; Fri, 14 Jan 2022 17:27:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+Rqir61hE48PZne0zpXK+3TtAEx9nVYAeaJEayChiHw=; b=cWEuvdqEqhPSeq ZNBwsqBBXmrUbTkFgCjUICCSlWRO7KOcOXXzZSNARexVw/DJqgh6x/nlBz0UQK9zD3J+Y+64Mdqqn 0WVJwGb9RFqWFFA8KGh8WnyK8TfLOgjNjhbg72Bm6oosRdPKBx+ql4KoizC1JFoVoFKqG4cIbzsia HAovXI+HQ7E5ciyZqAscVIN2FvWW7OSB+09zWFenNgW5yjt2UEIW+QVkWHzxDvnaB7vEOTrfu7p0y ItbVvK8tmR4RI29GfE6K5/w8d/sXvMn8x4bDbRFBpyVagIhK4fmNZpWqX97CGIvRnJn+PQ+rVOiN0 L0h3wjD3suYaGkzwg/Nw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n8QKv-009vUk-8w; Fri, 14 Jan 2022 17:26:01 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n8QKs-009vTM-7N for linux-arm-kernel@lists.infradead.org; Fri, 14 Jan 2022 17:25:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=JwoliXcJ7ab5c8+F4xKeDTkJ6noi7Vx/K/CQ+XG7ErE=; b=Ez6nvfIec49hV3Dsh4GUYRqhWB fGpwDEyw3EXhakHWRoPB9/BpJ9jUnYqugH6S98n+/OQIr1a2ts414G0cdMTQb1mGeBlx5eD1U2mNz A3GK7IJTX7datZmfZaoYS9A4Ue3fDF8a08l7vgZVKs5nk1PsjR9haYe5qtzTXDJcQXcY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1n8QKb-001Qx9-N6; Fri, 14 Jan 2022 18:25:41 +0100 Date: Fri, 14 Jan 2022 18:25:41 +0100 From: Andrew Lunn To: Kai-Heng Feng Cc: peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, "David S. Miller" , Jakub Kicinski , Maxime Coquelin , Heiner Kallweit , Russell King , Marek =?iso-8859-1?Q?Beh=FAn?= , Ivan Bornyakov , Pali =?iso-8859-1?Q?Roh=E1r?= , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] stmmac: intel: Honor phy LED set by system firmware on a Dell hardware Message-ID: References: <20220114040755.1314349-1-kai.heng.feng@canonical.com> <20220114040755.1314349-2-kai.heng.feng@canonical.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220114_092558_294357_83B8A6BC X-CRM114-Status: GOOD ( 13.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > This is a PHY property. Why is the MAC involved? > > This is inspired by commit a93f7fe13454 ("net: phy: marvell: add new > default led configure for m88e151x") which passes the flag from MAC to > PHY. But in this case, the MAC does not care what the LEDs are. The platform wants them left alone, not the MAC. > > Please also think about how to make this generic, so any ACPI based > > system can use it, with any PHY. ... > So the only approach I can think of is to use DMI match directly in PHY driver. In the phylib core. And the core then asks the specific PHY driver to not touch the LED configuration. It is then generic. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel