On Thu, Jan 13, 2022 at 10:40:40PM +0000, Joel Stanley wrote:
> Hello,
> 
> On Thu, 13 Jan 2022 at 08:52, logananth hcl <logananth13.hcl@gmail.com> wrote:
> >
> > Hai All,
> >
> > In openbmc/u-boot repo(branch - v2016.07-aspeed-openbmc)
> > https://github.com/openbmc/u-boot/tree/v2016.07-aspeed-openbmc
> >
> > I want to send a review on this particular branch in u-boot through upstream.
> > Is there any specific procedure to upstream it,
> > kindly provide your suggestions.
> 
> I strongly recommend using the newer v2019.04 based branch for any new
> system you're bringing up.

It doesn't seem like anyone is using this branch for any Aspeed system though.

```
$ git grep "v2019.04"
meta-aspeed/recipes-bsp/u-boot/u-boot-common-aspeed-sdk_2019.04.inc:PV = "v2019.04+git${SRCPV}"
```

I think everyone doing AST2400/AST2500 work has been copying from existing
systems and still pointing to the v2016.07 branch that we have working in the
tree.

> However, if you insist on the older branch, you can send patches to
> the list for it. Indicate in the subject that they are for the old
> branch:
> 
> git format-patch --subject-prefix "PATCH u-boot v2017.07-aspeed-openbmc"

I think the question is two-fold:

1) How do we get the code into the tree that everyone is using? (Which you've
answered)

2) What is the best way to get feedback from upstream on the proper way to do
this?

Is most of the Aspeed content fully upstream now?  I thought it wasn't and was
still in yet another Aspeed U-Boot tree.

-- 
Patrick Williams