From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A3ABC433EF for ; Mon, 17 Jan 2022 14:01:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232995AbiAQOBA (ORCPT ); Mon, 17 Jan 2022 09:01:00 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:40590 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232569AbiAQOA7 (ORCPT ); Mon, 17 Jan 2022 09:00:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=YS790bExTfkh4PHW3hIrNVTP5XO0J1V7mlWfOzj2+hg=; b=kEgFdw/dWrg94oZxKo8cq/EkPK V5dNV7H5YZA08vwuYe98OcgpKsQuy6JuvzVs5na5hcJsPZaPaGdUQIPZm413eitLoNlK5aUCwq/HR FzjBO4L2dGo2JdZh7OQ//LFe9XTfQ7M2WuNHn0+6+ZxMCBtW2nBfvEuhcl3+lMfi6bQo=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1n9SYr-001e33-H2; Mon, 17 Jan 2022 15:00:41 +0100 Date: Mon, 17 Jan 2022 15:00:41 +0100 From: Andrew Lunn To: Tobias Waldekranz Cc: davem@davemloft.net, kuba@kernel.org, madalin.bucur@nxp.com, robh+dt@kernel.org, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH net 1/4] net/fsl: xgmac_mdio: Add workaround for erratum A-009885 Message-ID: References: <20220116211529.25604-1-tobias@waldekranz.com> <20220116211529.25604-2-tobias@waldekranz.com> <87czkqdduh.fsf@waldekranz.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87czkqdduh.fsf@waldekranz.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jan 17, 2022 at 08:24:22AM +0100, Tobias Waldekranz wrote: > On Sun, Jan 16, 2022 at 23:02, Andrew Lunn wrote: > > On Sun, Jan 16, 2022 at 10:15:26PM +0100, Tobias Waldekranz wrote: > >> Once an MDIO read transaction is initiated, we must read back the data > >> register within 16 MDC cycles after the transaction completes. Outside > >> of this window, reads may return corrupt data. > >> > >> Therefore, disable local interrupts in the critical section, to > >> maximize the probability that we can satisfy this requirement. > > > > Since this is for net, a Fixes: tag would be nice. Maybe that would be > > for the commit which added this driver, or maybe when the DTSI files > > for the SOCs which have this errata we added? > > Alright, I wasn't sure how to tag WAs for errata since it is more about > the hardware than the driver. The tag gives the backporter an idea how far back to go. If support for this SoC has only recently been added, there is no need to backport a long way. If it is an old SoC, then maybe more effort should be put into the backport? > Should I send a v2 even if nothing else > pops up, or is this more of a if-you're-sending-a-v2-anyway type of > comment? If you reply with a Fixes: patchwork will automagically append it like it does Reviewed-by, Tested-by etc. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3FFA5C433F5 for ; Mon, 17 Jan 2022 14:01:44 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Jctqp3gPMz3035 for ; Tue, 18 Jan 2022 01:01:42 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=lunn.ch header.i=@lunn.ch header.a=rsa-sha256 header.s=20171124 header.b=kEgFdw/d; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lunn.ch (client-ip=185.16.172.187; helo=vps0.lunn.ch; envelope-from=andrew@lunn.ch; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=lunn.ch header.i=@lunn.ch header.a=rsa-sha256 header.s=20171124 header.b=kEgFdw/d; dkim-atps=neutral Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Jctq3364tz2y0B for ; Tue, 18 Jan 2022 01:01:02 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=YS790bExTfkh4PHW3hIrNVTP5XO0J1V7mlWfOzj2+hg=; b=kEgFdw/dWrg94oZxKo8cq/EkPK V5dNV7H5YZA08vwuYe98OcgpKsQuy6JuvzVs5na5hcJsPZaPaGdUQIPZm413eitLoNlK5aUCwq/HR FzjBO4L2dGo2JdZh7OQ//LFe9XTfQ7M2WuNHn0+6+ZxMCBtW2nBfvEuhcl3+lMfi6bQo=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1n9SYr-001e33-H2; Mon, 17 Jan 2022 15:00:41 +0100 Date: Mon, 17 Jan 2022 15:00:41 +0100 From: Andrew Lunn To: Tobias Waldekranz Subject: Re: [PATCH net 1/4] net/fsl: xgmac_mdio: Add workaround for erratum A-009885 Message-ID: References: <20220116211529.25604-1-tobias@waldekranz.com> <20220116211529.25604-2-tobias@waldekranz.com> <87czkqdduh.fsf@waldekranz.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87czkqdduh.fsf@waldekranz.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, madalin.bucur@nxp.com, robh+dt@kernel.org, paulus@samba.org, kuba@kernel.org, netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, davem@davemloft.net Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Jan 17, 2022 at 08:24:22AM +0100, Tobias Waldekranz wrote: > On Sun, Jan 16, 2022 at 23:02, Andrew Lunn wrote: > > On Sun, Jan 16, 2022 at 10:15:26PM +0100, Tobias Waldekranz wrote: > >> Once an MDIO read transaction is initiated, we must read back the data > >> register within 16 MDC cycles after the transaction completes. Outside > >> of this window, reads may return corrupt data. > >> > >> Therefore, disable local interrupts in the critical section, to > >> maximize the probability that we can satisfy this requirement. > > > > Since this is for net, a Fixes: tag would be nice. Maybe that would be > > for the commit which added this driver, or maybe when the DTSI files > > for the SOCs which have this errata we added? > > Alright, I wasn't sure how to tag WAs for errata since it is more about > the hardware than the driver. The tag gives the backporter an idea how far back to go. If support for this SoC has only recently been added, there is no need to backport a long way. If it is an old SoC, then maybe more effort should be put into the backport? > Should I send a v2 even if nothing else > pops up, or is this more of a if-you're-sending-a-v2-anyway type of > comment? If you reply with a Fixes: patchwork will automagically append it like it does Reviewed-by, Tested-by etc. Andrew