From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6900C433F5 for ; Tue, 18 Jan 2022 16:17:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243870AbiARQRQ (ORCPT ); Tue, 18 Jan 2022 11:17:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347541AbiARQQ6 (ORCPT ); Tue, 18 Jan 2022 11:16:58 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A941BC06173F; Tue, 18 Jan 2022 08:16:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xjulHOS5CUwNIm036P6j8UbjrwgqOIyQQzkCAKbIpbY=; b=UOfvy6QYbtpEnRIvhnRAmZV8tM uUPwsa0FpluV8AQMrNgGhnOpfr1ceFlKhbLO6j6TXzZPl1RSSEUFJQUHQUbIBDcOmQ6XPgRk5Dhon gdE9+fYI0sRyMIrNeEqt/HZ9P1B0EMqwcfuBFSaT0xbOOttoczaMAWpF63kQVtILnbYspnywhTLQk c67JRHO9HeQp041bd3xWpAbmscXASfrZVG4yG3AujijkVppqlzCIsWMR3GhYW+4LPLanMQ0RmW8jI Hm7risGLwvd09syPIsD7cwoYDFnBoX1hIWXNNyuzpi7s0099ZVn79PsBEQC/YJkGJyCPrq3yAB0Lb DytI5P4A==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9rAC-002D80-0z; Tue, 18 Jan 2022 16:16:52 +0000 Date: Tue, 18 Jan 2022 08:16:51 -0800 From: Luis Chamberlain To: Linus Torvalds Cc: Jessica Yu , Colin Ian King , Greg Kroah-Hartman , Dmitry Torokhov , Yu Chen , Linux Kernel Mailing List , linux-modules@vger.kernel.org Subject: Re: Modules updates for v5.17-rc1 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Luis Chamberlain Precedence: bulk List-ID: On Mon, Jan 17, 2022 at 07:38:25AM +0200, Linus Torvalds wrote: > On Sat, Jan 15, 2022 at 2:20 AM Luis Chamberlain wrote: > > > > Although this change was only merged on January 11th, the patches have > > been being reviewed since early december. There was at least one fix > > already found for it and merged. > > Grr.. > > And that's exactly why it matters not about "being reviewed", but when > they were in linux-next etc. > > I've pulled this, but consider this a complaint. Things should not be > "reviewed" before the merge window. They should be ready and merged > and have actually seen some testing. > > Review is good. But nothing beats actually being out there and > actually seeing real-life testing (of course, linux-next probably > mostly gets build-testing, but what testing it gets is still better > than not being there). Understood, that gives me a better ballpark idea of when to defer things for a next release. Thanks for the feedback. Luis