From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FC81C433EF for ; Tue, 18 Jan 2022 22:59:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350076AbiARW7s (ORCPT ); Tue, 18 Jan 2022 17:59:48 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:33110 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344248AbiARW7s (ORCPT ); Tue, 18 Jan 2022 17:59:48 -0500 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A0CC614C3; Tue, 18 Jan 2022 23:59:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1642546786; bh=oQxJRzBrf6lHKGTHWKd6MEe0cG2GGX7UJoS3jk8VEhc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jBGceSU6x7NuMMI/g4LA6JGxbDvYj2GzP+jT8T47lK3jQGesMz6t25O4aEAT3ybrA OmMa8i2OZ32Zo4xf0xKFia/qVFWXmd/hHSUSr2ICkg+3qefwBXc96OVJpjPbATxhep CbbYtw1SK1mxJfiyppJj5ESaNOhA/6oNLUOaIbHo= Date: Wed, 19 Jan 2022 00:59:32 +0200 From: Laurent Pinchart To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Florian Fainelli , Jean-Michel Hautbois , Nicolas Saenz Julienne , Rob Herring , devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Stefan Wahren , Cyril Brulebois , Dave Stevenson , Maxime Ripard Subject: Re: [PATCH v3] ARM: dts: bcm2711-rpi-cm4-io: Add rtc on a pinctrl-muxed i2c bus Message-ID: References: <20211231115109.94626-1-uwe@kleine-koenig.org> <2540edbe-084e-802f-3533-0aa66ddc20ec@ideasonboard.com> <397bf7c2-da9f-a993-f8bb-5d6cbc6e87eb@gmail.com> <41d2ff4a-79eb-5071-3a35-efa8cccec074@kleine-koenig.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <41d2ff4a-79eb-5071-3a35-efa8cccec074@kleine-koenig.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Uwe, On Tue, Jan 18, 2022 at 11:41:19PM +0100, Uwe Kleine-König wrote: > On 1/18/22 21:47, Laurent Pinchart wrote: > > On Tue, Jan 18, 2022 at 12:00:50PM -0800, Florian Fainelli wrote: > >> On 1/18/22 11:45 AM, Jean-Michel Hautbois wrote: > >>> This is also needed for camera and display support. > >>> I tested it successfully with imx219 + unicam on mainline. > >> > >> Thanks for testing, can you reply with a Tested-by tag so it could be > >> applied to the commit message when this gets picked up? > > > > Well, this also points out that there's an issue: if the mux is needed > > for other devices, it shouldn't be in bcm2711-rpi-cm4-io.dts :-) We > > could move it to bcm2711-rpi.dtsi (so far all bcm2711-based boards use > > either I/O pins 0+1 or 44+45) > > If I understand correctly it's not used on rpi-4-b, so bcm2711-rpi.dtsi > would be wrong. rpi-4-b muxes I2C0 on pins 0+1 and 44+45. The latter is wired to the camera connector, and used for the camera sensor. Same thing on rpi-cm4. rpi-400 has no camera connector, but I believe the display I2C bus is also on pins 44+45 (at least according to the downstream DT sources, rpi-400 muxes I2C0 on 0+1 and 44+45 too). > > , or move it to per-board files. > > It is in an board file now?! So I don't understand your suggestion here. Sorry, I meant have it in per-board files, not more it there. > > In the > > latter case, instead of duplicating the same block everywhere, it could > > be moved to a .dtsi included in those board files. This is what the > > downstream kernel does. > > How does it call the dtsi file? I wonder if that is sensible expecting > that the devices on the bus are different for different boards?! Downstream has a bcm283x-rpi-i2c0mux_0_44.dtsi that just contains &i2c0mux { pinctrl-0 = <&i2c0_gpio0>; pinctrl-1 = <&i2c0_gpio44>; }; with i2c0mux defined in bcm283x.dtsi as i2c0mux: i2c0mux { compatible = "i2c-mux-pinctrl"; #address-cells = <1>; #size-cells = <0>; i2c-parent = <&i2c0if>; pinctrl-names = "i2c0", "i2c_csi_dsi"; status = "disabled"; i2c0: i2c@0 { reg = <0>; #address-cells = <1>; #size-cells = <0>; }; i2c_csi_dsi: i2c@1 { reg = <1>; #address-cells = <1>; #size-cells = <0>; }; }; The following board files #include "bcm283x-rpi-i2c0mux_0_44.dtsi": - bcm2710-rpi-3-b.dts - bcm2710-rpi-3-b-plus.dts - bcm2710-rpi-zero-2-w.dts - bcm2711-rpi-400.dts - bcm2711-rpi-4-b.dts - bcm2711-rpi-4-b.dts.orig - bcm2711-rpi-cm4.dts We don't have to replicate the exact same mechanism and use the same names, but for rpi-4-b and rpi-cm4, to enable camera support (which we're working on, Jean-Michel has posted a driver for the Unicam CSI-2 receiver to the linux-media mailing list, the ISP will follow), we need the mux. Given that those two boards have a camera connector, I think it makes sense to define the mux in a different file than bcm2711-rpi-cm4-io.dts. The RTC node can stay in bcm2711-rpi-cm4-io.dts. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4711DC433F5 for ; Tue, 18 Jan 2022 23:01:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JwI9+Yh3MV67uZ445Y1HN6FE60pF0x3bVtbDstjs2aE=; b=fE1VybIzTzcleR 3E3H233qxgo/3lysYvhiDSHPjx1i5rcNiAOZ2I+mF9DvYVZoYSGKcX9WroIJofI9EkmcUk1QxVU9J ce666jGGbFkjBxJe5qvnWYkto7Wq6iHS4xlA/ewIo6Jul8kxjYVAgvp6Xn5UzQ6GSS6JvDqv0qsrN WZR9PdtSJuIqbKCK6YLsxEnGPQxqEHgjZC3CIPGmPVQQzrteeT/jKa2jwf5vogi+Akdkw0c42R13b rQabGEwLmnSFAMsHycPtkTOPWSzkRMBBfOy193vz2TfxxkgM8Iy5U+nqny+wVeyBnvbtwmpADmT1+ GGY9subwTL2LAUoopbRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9xSD-003BTK-6q; Tue, 18 Jan 2022 22:59:53 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n9xS9-003BSW-QC; Tue, 18 Jan 2022 22:59:51 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id A0CC614C3; Tue, 18 Jan 2022 23:59:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1642546786; bh=oQxJRzBrf6lHKGTHWKd6MEe0cG2GGX7UJoS3jk8VEhc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jBGceSU6x7NuMMI/g4LA6JGxbDvYj2GzP+jT8T47lK3jQGesMz6t25O4aEAT3ybrA OmMa8i2OZ32Zo4xf0xKFia/qVFWXmd/hHSUSr2ICkg+3qefwBXc96OVJpjPbATxhep CbbYtw1SK1mxJfiyppJj5ESaNOhA/6oNLUOaIbHo= Date: Wed, 19 Jan 2022 00:59:32 +0200 From: Laurent Pinchart To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Florian Fainelli , Jean-Michel Hautbois , Nicolas Saenz Julienne , Rob Herring , devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Stefan Wahren , Cyril Brulebois , Dave Stevenson , Maxime Ripard Subject: Re: [PATCH v3] ARM: dts: bcm2711-rpi-cm4-io: Add rtc on a pinctrl-muxed i2c bus Message-ID: References: <20211231115109.94626-1-uwe@kleine-koenig.org> <2540edbe-084e-802f-3533-0aa66ddc20ec@ideasonboard.com> <397bf7c2-da9f-a993-f8bb-5d6cbc6e87eb@gmail.com> <41d2ff4a-79eb-5071-3a35-efa8cccec074@kleine-koenig.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <41d2ff4a-79eb-5071-3a35-efa8cccec074@kleine-koenig.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220118_145950_022394_2DB056CD X-CRM114-Status: GOOD ( 29.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgVXdlLAoKT24gVHVlLCBKYW4gMTgsIDIwMjIgYXQgMTE6NDE6MTlQTSArMDEwMCwgVXdlIEts ZWluZS1Lw7ZuaWcgd3JvdGU6Cj4gT24gMS8xOC8yMiAyMTo0NywgTGF1cmVudCBQaW5jaGFydCB3 cm90ZToKPiA+IE9uIFR1ZSwgSmFuIDE4LCAyMDIyIGF0IDEyOjAwOjUwUE0gLTA4MDAsIEZsb3Jp YW4gRmFpbmVsbGkgd3JvdGU6Cj4gPj4gT24gMS8xOC8yMiAxMTo0NSBBTSwgSmVhbi1NaWNoZWwg SGF1dGJvaXMgd3JvdGU6Cj4gPj4+IFRoaXMgaXMgYWxzbyBuZWVkZWQgZm9yIGNhbWVyYSBhbmQg ZGlzcGxheSBzdXBwb3J0Lgo+ID4+PiBJIHRlc3RlZCBpdCBzdWNjZXNzZnVsbHkgd2l0aCBpbXgy MTkgKyB1bmljYW0gb24gbWFpbmxpbmUuCj4gPj4KPiA+PiBUaGFua3MgZm9yIHRlc3RpbmcsIGNh biB5b3UgcmVwbHkgd2l0aCBhIFRlc3RlZC1ieSB0YWcgc28gaXQgY291bGQgYmUKPiA+PiBhcHBs aWVkIHRvIHRoZSBjb21taXQgbWVzc2FnZSB3aGVuIHRoaXMgZ2V0cyBwaWNrZWQgdXA/Cj4gPiAK PiA+IFdlbGwsIHRoaXMgYWxzbyBwb2ludHMgb3V0IHRoYXQgdGhlcmUncyBhbiBpc3N1ZTogaWYg dGhlIG11eCBpcyBuZWVkZWQKPiA+IGZvciBvdGhlciBkZXZpY2VzLCBpdCBzaG91bGRuJ3QgYmUg aW4gYmNtMjcxMS1ycGktY200LWlvLmR0cyA6LSkgV2UKPiA+IGNvdWxkIG1vdmUgaXQgdG8gYmNt MjcxMS1ycGkuZHRzaSAoc28gZmFyIGFsbCBiY20yNzExLWJhc2VkIGJvYXJkcyB1c2UKPiA+IGVp dGhlciBJL08gcGlucyAwKzEgb3IgNDQrNDUpCj4gCj4gSWYgSSB1bmRlcnN0YW5kIGNvcnJlY3Rs eSBpdCdzIG5vdCB1c2VkIG9uIHJwaS00LWIsIHNvIGJjbTI3MTEtcnBpLmR0c2kgCj4gd291bGQg YmUgd3JvbmcuCgpycGktNC1iIG11eGVzIEkyQzAgb24gcGlucyAwKzEgYW5kIDQ0KzQ1LiBUaGUg bGF0dGVyIGlzIHdpcmVkIHRvIHRoZQpjYW1lcmEgY29ubmVjdG9yLCBhbmQgdXNlZCBmb3IgdGhl IGNhbWVyYSBzZW5zb3IuIFNhbWUgdGhpbmcgb24gcnBpLWNtNC4KcnBpLTQwMCBoYXMgbm8gY2Ft ZXJhIGNvbm5lY3RvciwgYnV0IEkgYmVsaWV2ZSB0aGUgZGlzcGxheSBJMkMgYnVzIGlzCmFsc28g b24gcGlucyA0NCs0NSAoYXQgbGVhc3QgYWNjb3JkaW5nIHRvIHRoZSBkb3duc3RyZWFtIERUIHNv dXJjZXMsCnJwaS00MDAgbXV4ZXMgSTJDMCBvbiAwKzEgYW5kIDQ0KzQ1IHRvbykuCgo+ID4gLCBv ciBtb3ZlIGl0IHRvIHBlci1ib2FyZCBmaWxlcy4KPiAKPiBJdCBpcyBpbiBhbiBib2FyZCBmaWxl IG5vdz8hIFNvIEkgZG9uJ3QgdW5kZXJzdGFuZCB5b3VyIHN1Z2dlc3Rpb24gaGVyZS4KClNvcnJ5 LCBJIG1lYW50IGhhdmUgaXQgaW4gcGVyLWJvYXJkIGZpbGVzLCBub3QgbW9yZSBpdCB0aGVyZS4K Cj4gPiBJbiB0aGUKPiA+IGxhdHRlciBjYXNlLCBpbnN0ZWFkIG9mIGR1cGxpY2F0aW5nIHRoZSBz YW1lIGJsb2NrIGV2ZXJ5d2hlcmUsIGl0IGNvdWxkCj4gPiBiZSBtb3ZlZCB0byBhIC5kdHNpIGlu Y2x1ZGVkIGluIHRob3NlIGJvYXJkIGZpbGVzLiBUaGlzIGlzIHdoYXQgdGhlCj4gPiBkb3duc3Ry ZWFtIGtlcm5lbCBkb2VzLgo+IAo+IEhvdyBkb2VzIGl0IGNhbGwgdGhlIGR0c2kgZmlsZT8gSSB3 b25kZXIgaWYgdGhhdCBpcyBzZW5zaWJsZSBleHBlY3RpbmcgCj4gdGhhdCB0aGUgZGV2aWNlcyBv biB0aGUgYnVzIGFyZSBkaWZmZXJlbnQgZm9yIGRpZmZlcmVudCBib2FyZHM/IQoKRG93bnN0cmVh bSBoYXMgYSBiY20yODN4LXJwaS1pMmMwbXV4XzBfNDQuZHRzaSB0aGF0IGp1c3QgY29udGFpbnMK CiZpMmMwbXV4IHsKCXBpbmN0cmwtMCA9IDwmaTJjMF9ncGlvMD47CglwaW5jdHJsLTEgPSA8Jmky YzBfZ3BpbzQ0PjsKfTsKCndpdGggaTJjMG11eCBkZWZpbmVkIGluIGJjbTI4M3guZHRzaSBhcwoK CWkyYzBtdXg6IGkyYzBtdXggewoJCWNvbXBhdGlibGUgPSAiaTJjLW11eC1waW5jdHJsIjsKCQkj YWRkcmVzcy1jZWxscyA9IDwxPjsKCQkjc2l6ZS1jZWxscyA9IDwwPjsKCgkJaTJjLXBhcmVudCA9 IDwmaTJjMGlmPjsKCgkJcGluY3RybC1uYW1lcyA9ICJpMmMwIiwgImkyY19jc2lfZHNpIjsKCgkJ c3RhdHVzID0gImRpc2FibGVkIjsKCgkJaTJjMDogaTJjQDAgewoJCQlyZWcgPSA8MD47CgkJCSNh ZGRyZXNzLWNlbGxzID0gPDE+OwoJCQkjc2l6ZS1jZWxscyA9IDwwPjsKCQl9OwoKCQlpMmNfY3Np X2RzaTogaTJjQDEgewoJCQlyZWcgPSA8MT47CgkJCSNhZGRyZXNzLWNlbGxzID0gPDE+OwoJCQkj c2l6ZS1jZWxscyA9IDwwPjsKCQl9OwoJfTsKClRoZSBmb2xsb3dpbmcgYm9hcmQgZmlsZXMgI2lu Y2x1ZGUgImJjbTI4M3gtcnBpLWkyYzBtdXhfMF80NC5kdHNpIjoKCi0gYmNtMjcxMC1ycGktMy1i LmR0cwotIGJjbTI3MTAtcnBpLTMtYi1wbHVzLmR0cwotIGJjbTI3MTAtcnBpLXplcm8tMi13LmR0 cwotIGJjbTI3MTEtcnBpLTQwMC5kdHMKLSBiY20yNzExLXJwaS00LWIuZHRzCi0gYmNtMjcxMS1y cGktNC1iLmR0cy5vcmlnCi0gYmNtMjcxMS1ycGktY200LmR0cwoKV2UgZG9uJ3QgaGF2ZSB0byBy ZXBsaWNhdGUgdGhlIGV4YWN0IHNhbWUgbWVjaGFuaXNtIGFuZCB1c2UgdGhlIHNhbWUKbmFtZXMs IGJ1dCBmb3IgcnBpLTQtYiBhbmQgcnBpLWNtNCwgdG8gZW5hYmxlIGNhbWVyYSBzdXBwb3J0ICh3 aGljaAp3ZSdyZSB3b3JraW5nIG9uLCBKZWFuLU1pY2hlbCBoYXMgcG9zdGVkIGEgZHJpdmVyIGZv ciB0aGUgVW5pY2FtIENTSS0yCnJlY2VpdmVyIHRvIHRoZSBsaW51eC1tZWRpYSBtYWlsaW5nIGxp c3QsIHRoZSBJU1Agd2lsbCBmb2xsb3cpLCB3ZSBuZWVkCnRoZSBtdXguIEdpdmVuIHRoYXQgdGhv c2UgdHdvIGJvYXJkcyBoYXZlIGEgY2FtZXJhIGNvbm5lY3RvciwgSSB0aGluayBpdAptYWtlcyBz ZW5zZSB0byBkZWZpbmUgdGhlIG11eCBpbiBhIGRpZmZlcmVudCBmaWxlIHRoYW4KYmNtMjcxMS1y cGktY200LWlvLmR0cy4gVGhlIFJUQyBub2RlIGNhbiBzdGF5IGluIGJjbTI3MTEtcnBpLWNtNC1p by5kdHMuCgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBs aXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK