From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1E48C433EF for ; Wed, 19 Jan 2022 09:19:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352997AbiASJTU (ORCPT ); Wed, 19 Jan 2022 04:19:20 -0500 Received: from mga12.intel.com ([192.55.52.136]:61815 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352693AbiASJTL (ORCPT ); Wed, 19 Jan 2022 04:19:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642583951; x=1674119951; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Zf7maaT407OcqJiMSYXoEAzMcLY861f8NYGTlKtPnGA=; b=YkalItov6WCXDDbUVKKK5aiMjxJxH7VjKeBum4WvbO6/eIILTB8TVBJw jRCxXXVexNuFXe7vS7MNJ6i/X4Yr+VXupmXNUNrECWFoZIzkBepGSqWw4 yra6STdVm4jTib3jLzsdVfV7+Lrqx9pj3CQ8cR5EmMeagU4MlmkKoHH85 5cqCu828qtI5h+4xugHrJy1z8tTYl4NE8N1FgJNRRB2GpXvaucEd6IDMH xoEjc5zSBaX34fbfXHRQmOWwjcQ/gvsOwidLRd5fdoDcVqTwyPqi1fw9Z FnwI4Ke+m92A92TKLrLxpYChlXf3f9lyFUIz6G/FF/LoqsfAt2B3teJxK A==; X-IronPort-AV: E=McAfee;i="6200,9189,10231"; a="225001669" X-IronPort-AV: E=Sophos;i="5.88,299,1635231600"; d="scan'208";a="225001669" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 01:19:11 -0800 X-IronPort-AV: E=Sophos;i="5.88,299,1635231600"; d="scan'208";a="622447667" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 01:19:01 -0800 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id CEBE0203C8; Wed, 19 Jan 2022 11:18:59 +0200 (EET) Date: Wed, 19 Jan 2022 11:18:59 +0200 From: Sakari Ailus To: Lucas De Marchi Cc: linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-security-module@vger.kernel.org, nouveau@lists.freedesktop.org, netdev@vger.kernel.org, Alex Deucher , Andrew Morton , Andy Shevchenko , Andy Shevchenko , Ben Skeggs , Christian =?iso-8859-1?Q?K=F6nig?= , Chris Wilson , Daniel Vetter , David Airlie , "David S . Miller" , Emma Anholt , Eryk Brol , Francis Laniel , Greg Kroah-Hartman , Harry Wentland , Jakub Kicinski , Jani Nikula , Joonas Lahtinen , Julia Lawall , Kentaro Takeda , Leo Li , Mikita Lipski , Petr Mladek , Rahul Lakkireddy , Raju Rangoju , Rasmus Villemoes , Rodrigo Vivi , Sergey Senozhatsky , Steven Rostedt , Vishal Kulkarni Subject: Re: [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation Message-ID: References: <20220119072450.2890107-1-lucas.demarchi@intel.com> <20220119072450.2890107-2-lucas.demarchi@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220119072450.2890107-2-lucas.demarchi@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lucas, On Tue, Jan 18, 2022 at 11:24:48PM -0800, Lucas De Marchi wrote: > @@ -1354,8 +1345,7 @@ static bool tomoyo_print_condition(struct tomoyo_io_buffer *head, > case 3: > if (cond->grant_log != TOMOYO_GRANTLOG_AUTO) > tomoyo_io_printf(head, " grant_log=%s", > - tomoyo_yesno(cond->grant_log == > - TOMOYO_GRANTLOG_YES)); > + yesno(cond->grant_log == TOMOYO_GRANTLOG_YES)); This would be better split on two lines. Then, Reviewed-by: Sakari Ailus -- Sakari Ailus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 140ECC433EF for ; Wed, 19 Jan 2022 09:19:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E0D1310E96D; Wed, 19 Jan 2022 09:19:12 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 29C5F10E96D; Wed, 19 Jan 2022 09:19:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642583952; x=1674119952; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Zf7maaT407OcqJiMSYXoEAzMcLY861f8NYGTlKtPnGA=; b=ZFNwW0Dd9ESaHoa0UPh0BzF1zqZNveic6/jajEPk6qIJOnltb2XtBENE 885yBSiun1DGbR2uQ7RjwbCELiS2skBvZQgtW+grFtz7tSYK6b0RBOL/y AAIjYSX8rjjSgCN+Hv8SKBxs8xtEQUtwkHI1Y3mf0ZUqdF1Ay8uK9YsMy ordGnhWbMpmC1jlKXmhOyE8+ftckvfAD2s515M4FB+5rjVfwwUbaSQN4p EajkxxmSlJaQc/l5HNiih7vtpeb8WHIWvqYIuJruGo338HwJ7i4nFZh/P e3xZpoctQHC4BqAxceYeKH38QlSoFHVCmEoST1+GVW3rgexoNpDOKK+Vw g==; X-IronPort-AV: E=McAfee;i="6200,9189,10231"; a="232388195" X-IronPort-AV: E=Sophos;i="5.88,299,1635231600"; d="scan'208";a="232388195" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 01:19:11 -0800 X-IronPort-AV: E=Sophos;i="5.88,299,1635231600"; d="scan'208";a="622447667" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 01:19:01 -0800 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id CEBE0203C8; Wed, 19 Jan 2022 11:18:59 +0200 (EET) Date: Wed, 19 Jan 2022 11:18:59 +0200 From: Sakari Ailus To: Lucas De Marchi Subject: Re: [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation Message-ID: References: <20220119072450.2890107-1-lucas.demarchi@intel.com> <20220119072450.2890107-2-lucas.demarchi@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220119072450.2890107-2-lucas.demarchi@intel.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emma Anholt , David Airlie , nouveau@lists.freedesktop.org, Rasmus Villemoes , dri-devel@lists.freedesktop.org, Chris Wilson , Vishal Kulkarni , Francis Laniel , Kentaro Takeda , Mikita Lipski , amd-gfx@lists.freedesktop.org, Andy Shevchenko , Ben Skeggs , Jakub Kicinski , Petr Mladek , Leo Li , intel-gfx@lists.freedesktop.org, Raju Rangoju , Julia Lawall , Rahul Lakkireddy , Steven Rostedt , Rodrigo Vivi , Andy Shevchenko , Eryk Brol , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Christian =?iso-8859-1?Q?K=F6nig?= , Sergey Senozhatsky , linux-security-module@vger.kernel.org, netdev@vger.kernel.org, Alex Deucher , Andrew Morton , "David S . Miller" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Lucas, On Tue, Jan 18, 2022 at 11:24:48PM -0800, Lucas De Marchi wrote: > @@ -1354,8 +1345,7 @@ static bool tomoyo_print_condition(struct tomoyo_io_buffer *head, > case 3: > if (cond->grant_log != TOMOYO_GRANTLOG_AUTO) > tomoyo_io_printf(head, " grant_log=%s", > - tomoyo_yesno(cond->grant_log == > - TOMOYO_GRANTLOG_YES)); > + yesno(cond->grant_log == TOMOYO_GRANTLOG_YES)); This would be better split on two lines. Then, Reviewed-by: Sakari Ailus -- Sakari Ailus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3FA1C433F5 for ; Wed, 19 Jan 2022 09:19:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 401A110E978; Wed, 19 Jan 2022 09:19:13 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 29C5F10E96D; Wed, 19 Jan 2022 09:19:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642583952; x=1674119952; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Zf7maaT407OcqJiMSYXoEAzMcLY861f8NYGTlKtPnGA=; b=ZFNwW0Dd9ESaHoa0UPh0BzF1zqZNveic6/jajEPk6qIJOnltb2XtBENE 885yBSiun1DGbR2uQ7RjwbCELiS2skBvZQgtW+grFtz7tSYK6b0RBOL/y AAIjYSX8rjjSgCN+Hv8SKBxs8xtEQUtwkHI1Y3mf0ZUqdF1Ay8uK9YsMy ordGnhWbMpmC1jlKXmhOyE8+ftckvfAD2s515M4FB+5rjVfwwUbaSQN4p EajkxxmSlJaQc/l5HNiih7vtpeb8WHIWvqYIuJruGo338HwJ7i4nFZh/P e3xZpoctQHC4BqAxceYeKH38QlSoFHVCmEoST1+GVW3rgexoNpDOKK+Vw g==; X-IronPort-AV: E=McAfee;i="6200,9189,10231"; a="232388195" X-IronPort-AV: E=Sophos;i="5.88,299,1635231600"; d="scan'208";a="232388195" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 01:19:11 -0800 X-IronPort-AV: E=Sophos;i="5.88,299,1635231600"; d="scan'208";a="622447667" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 01:19:01 -0800 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id CEBE0203C8; Wed, 19 Jan 2022 11:18:59 +0200 (EET) Date: Wed, 19 Jan 2022 11:18:59 +0200 From: Sakari Ailus To: Lucas De Marchi Message-ID: References: <20220119072450.2890107-1-lucas.demarchi@intel.com> <20220119072450.2890107-2-lucas.demarchi@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220119072450.2890107-2-lucas.demarchi@intel.com> Subject: Re: [Intel-gfx] [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emma Anholt , David Airlie , nouveau@lists.freedesktop.org, Rasmus Villemoes , dri-devel@lists.freedesktop.org, Chris Wilson , Vishal Kulkarni , Francis Laniel , Kentaro Takeda , Mikita Lipski , amd-gfx@lists.freedesktop.org, Andy Shevchenko , Ben Skeggs , Jakub Kicinski , Harry Wentland , Petr Mladek , Leo Li , intel-gfx@lists.freedesktop.org, Raju Rangoju , Julia Lawall , Rahul Lakkireddy , Steven Rostedt , Andy Shevchenko , Eryk Brol , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Christian =?iso-8859-1?Q?K=F6nig?= , Sergey Senozhatsky , linux-security-module@vger.kernel.org, netdev@vger.kernel.org, Alex Deucher , Andrew Morton , "David S . Miller" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Lucas, On Tue, Jan 18, 2022 at 11:24:48PM -0800, Lucas De Marchi wrote: > @@ -1354,8 +1345,7 @@ static bool tomoyo_print_condition(struct tomoyo_io_buffer *head, > case 3: > if (cond->grant_log != TOMOYO_GRANTLOG_AUTO) > tomoyo_io_printf(head, " grant_log=%s", > - tomoyo_yesno(cond->grant_log == > - TOMOYO_GRANTLOG_YES)); > + yesno(cond->grant_log == TOMOYO_GRANTLOG_YES)); This would be better split on two lines. Then, Reviewed-by: Sakari Ailus -- Sakari Ailus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D87BC433F5 for ; Wed, 19 Jan 2022 14:32:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9E65C10EB5F; Wed, 19 Jan 2022 14:32:46 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 29C5F10E96D; Wed, 19 Jan 2022 09:19:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642583952; x=1674119952; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Zf7maaT407OcqJiMSYXoEAzMcLY861f8NYGTlKtPnGA=; b=ZFNwW0Dd9ESaHoa0UPh0BzF1zqZNveic6/jajEPk6qIJOnltb2XtBENE 885yBSiun1DGbR2uQ7RjwbCELiS2skBvZQgtW+grFtz7tSYK6b0RBOL/y AAIjYSX8rjjSgCN+Hv8SKBxs8xtEQUtwkHI1Y3mf0ZUqdF1Ay8uK9YsMy ordGnhWbMpmC1jlKXmhOyE8+ftckvfAD2s515M4FB+5rjVfwwUbaSQN4p EajkxxmSlJaQc/l5HNiih7vtpeb8WHIWvqYIuJruGo338HwJ7i4nFZh/P e3xZpoctQHC4BqAxceYeKH38QlSoFHVCmEoST1+GVW3rgexoNpDOKK+Vw g==; X-IronPort-AV: E=McAfee;i="6200,9189,10231"; a="232388195" X-IronPort-AV: E=Sophos;i="5.88,299,1635231600"; d="scan'208";a="232388195" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 01:19:11 -0800 X-IronPort-AV: E=Sophos;i="5.88,299,1635231600"; d="scan'208";a="622447667" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 01:19:01 -0800 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id CEBE0203C8; Wed, 19 Jan 2022 11:18:59 +0200 (EET) Date: Wed, 19 Jan 2022 11:18:59 +0200 From: Sakari Ailus To: Lucas De Marchi Subject: Re: [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation Message-ID: References: <20220119072450.2890107-1-lucas.demarchi@intel.com> <20220119072450.2890107-2-lucas.demarchi@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220119072450.2890107-2-lucas.demarchi@intel.com> X-Mailman-Approved-At: Wed, 19 Jan 2022 14:32:45 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emma Anholt , David Airlie , nouveau@lists.freedesktop.org, Joonas Lahtinen , Rasmus Villemoes , dri-devel@lists.freedesktop.org, Chris Wilson , Vishal Kulkarni , Francis Laniel , Kentaro Takeda , Mikita Lipski , amd-gfx@lists.freedesktop.org, Andy Shevchenko , Ben Skeggs , Jakub Kicinski , Harry Wentland , Petr Mladek , Leo Li , intel-gfx@lists.freedesktop.org, Raju Rangoju , Jani Nikula , Julia Lawall , Rahul Lakkireddy , Steven Rostedt , Rodrigo Vivi , Andy Shevchenko , Eryk Brol , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Christian =?iso-8859-1?Q?K=F6nig?= , Sergey Senozhatsky , linux-security-module@vger.kernel.org, Daniel Vetter , netdev@vger.kernel.org, Alex Deucher , Andrew Morton , "David S . Miller" Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Hi Lucas, On Tue, Jan 18, 2022 at 11:24:48PM -0800, Lucas De Marchi wrote: > @@ -1354,8 +1345,7 @@ static bool tomoyo_print_condition(struct tomoyo_io_buffer *head, > case 3: > if (cond->grant_log != TOMOYO_GRANTLOG_AUTO) > tomoyo_io_printf(head, " grant_log=%s", > - tomoyo_yesno(cond->grant_log == > - TOMOYO_GRANTLOG_YES)); > + yesno(cond->grant_log == TOMOYO_GRANTLOG_YES)); This would be better split on two lines. Then, Reviewed-by: Sakari Ailus -- Sakari Ailus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1104CC433EF for ; Thu, 20 Jan 2022 18:17:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1341C10E68A; Thu, 20 Jan 2022 18:16:53 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 29C5F10E96D; Wed, 19 Jan 2022 09:19:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642583952; x=1674119952; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Zf7maaT407OcqJiMSYXoEAzMcLY861f8NYGTlKtPnGA=; b=ZFNwW0Dd9ESaHoa0UPh0BzF1zqZNveic6/jajEPk6qIJOnltb2XtBENE 885yBSiun1DGbR2uQ7RjwbCELiS2skBvZQgtW+grFtz7tSYK6b0RBOL/y AAIjYSX8rjjSgCN+Hv8SKBxs8xtEQUtwkHI1Y3mf0ZUqdF1Ay8uK9YsMy ordGnhWbMpmC1jlKXmhOyE8+ftckvfAD2s515M4FB+5rjVfwwUbaSQN4p EajkxxmSlJaQc/l5HNiih7vtpeb8WHIWvqYIuJruGo338HwJ7i4nFZh/P e3xZpoctQHC4BqAxceYeKH38QlSoFHVCmEoST1+GVW3rgexoNpDOKK+Vw g==; X-IronPort-AV: E=McAfee;i="6200,9189,10231"; a="232388195" X-IronPort-AV: E=Sophos;i="5.88,299,1635231600"; d="scan'208";a="232388195" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 01:19:11 -0800 X-IronPort-AV: E=Sophos;i="5.88,299,1635231600"; d="scan'208";a="622447667" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 01:19:01 -0800 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id CEBE0203C8; Wed, 19 Jan 2022 11:18:59 +0200 (EET) Date: Wed, 19 Jan 2022 11:18:59 +0200 From: Sakari Ailus To: Lucas De Marchi Message-ID: References: <20220119072450.2890107-1-lucas.demarchi@intel.com> <20220119072450.2890107-2-lucas.demarchi@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220119072450.2890107-2-lucas.demarchi@intel.com> X-Mailman-Approved-At: Thu, 20 Jan 2022 18:16:51 +0000 Subject: Re: [Nouveau] [PATCH 1/3] lib/string_helpers: Consolidate yesno() implementation X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emma Anholt , David Airlie , nouveau@lists.freedesktop.org, Joonas Lahtinen , Rasmus Villemoes , dri-devel@lists.freedesktop.org, Chris Wilson , Vishal Kulkarni , Francis Laniel , Kentaro Takeda , Mikita Lipski , amd-gfx@lists.freedesktop.org, Andy Shevchenko , Ben Skeggs , Jakub Kicinski , Harry Wentland , Petr Mladek , Leo Li , intel-gfx@lists.freedesktop.org, Raju Rangoju , Jani Nikula , Julia Lawall , Rahul Lakkireddy , Steven Rostedt , Rodrigo Vivi , Andy Shevchenko , Eryk Brol , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Christian =?iso-8859-1?Q?K=F6nig?= , Sergey Senozhatsky , linux-security-module@vger.kernel.org, Daniel Vetter , netdev@vger.kernel.org, Alex Deucher , Andrew Morton , "David S . Miller" Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" Hi Lucas, On Tue, Jan 18, 2022 at 11:24:48PM -0800, Lucas De Marchi wrote: > @@ -1354,8 +1345,7 @@ static bool tomoyo_print_condition(struct tomoyo_io_buffer *head, > case 3: > if (cond->grant_log != TOMOYO_GRANTLOG_AUTO) > tomoyo_io_printf(head, " grant_log=%s", > - tomoyo_yesno(cond->grant_log == > - TOMOYO_GRANTLOG_YES)); > + yesno(cond->grant_log == TOMOYO_GRANTLOG_YES)); This would be better split on two lines. Then, Reviewed-by: Sakari Ailus -- Sakari Ailus