Re: Issue with UAS and" VIA Labs, Inc. VL817 SATA Adaptor"

[Greg KH <greg@kroah.com>]

On Thu, Jan 20, 2022 at 08:28:30AM +0100, Thomas Weißschuh wrote:
> Hi Alan,
> 
> I hava a IcyBox IB-3740-C31 [0], this device seems to be identical to the one
> here. It has the same USB IDs and case design.
> It also has the serial number "4".
> The only difference it seems is the field bcdDevice which is "1.36" and the
> reported name is different (see the patch below).
> 
> So I adapted the patch slightly to also match that bcdDevice.
> I also changed the productName field but that does not seem to be used anyways.
> 
> Using the quirk flags "fgkm" as mentioned in [1] did not help.
> 
> FYI while there are many reports that UAS does not work with these devices,
> there also are a few that report it working. For example [2].
> 
> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
> index 29191d33c0e3..53e8249644b2 100644
> --- a/drivers/usb/storage/unusual_devs.h
> +++ b/drivers/usb/storage/unusual_devs.h
> @@ -2301,6 +2301,19 @@ UNUSUAL_DEV(  0x2027, 0xa001, 0x0000, 0x9999,
>                 USB_SC_DEVICE, USB_PR_DEVICE, usb_stor_euscsi_init,
>                 US_FL_SCM_MULT_TARG ),
> 
> +UNUSUAL_DEV( 0x2109, 0x0715, 0x0000, 0x9999,
> +               "VIA Labs, Inc.",
> +               "VL817 SATA Adaptor",
> +               USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> +               US_FL_IGNORE_UAS),
> 
> This is the exact issue:
> 
> [ 3606.231973] scsi host14: uas_eh_device_reset_handler start
> [ 3606.232149] sd 14:0:0:0: [sdg] tag#2 uas_zap_pending 0 uas-tag 1 inflight: CMD
> [ 3606.232154] sd 14:0:0:0: [sdg] tag#2 CDB: Write(16) 8a 00 00 00 00 00 18 0c c9 80 00 00 00 80 00 00
> [ 3606.306257] usb 4-4.4: reset SuperSpeed Plus Gen 2x1 USB device number 11 using xhci_hcd
> [ 3606.328584] scsi host14: uas_eh_device_reset_handler success
> 
> For this patch:
> 
> Tested-by: Thomas Weißschuh <linux@weissschuh.net>
> 
> Thomas
> 
> [0] https://icybox.de/en/product.php?id=155
> [1] https://lore.kernel.org/linux-usb/c4b4aa34-12d9-7000-6398-d94a7ebffdfc@suse.com/
> [2] https://spod.cx/blog/enabling_trim_support_via_VL817_usb_sata_adaptor.shtml

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
  and can not be applied.  Please read the file,
  Documentation/email-clients.txt in order to fix this.

- Your patch does not have a Signed-off-by: line.  Please read the
  kernel file, Documentation/SubmittingPatches and resend it after
  adding that line.  Note, the line needs to be in the body of the
  email, before the patch, not at the bottom of the patch or in the
  email signature.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what a proper Subject: line should
  look like.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot