From: Tomasz Duszynski <tomasz.duszynski@octakon.com>
To: Weiguo Li <liwg06@foxmail.com>
Cc: <dev@dpdk.org>, <jerinj@marvell.com>
Subject: Re: [PATCH] common/cnxk: fix incorrect error checking
Date: Fri, 21 Jan 2022 20:28:47 +0100 [thread overview]
Message-ID: <YesIsXmlFGVMkLlf@arch> (raw)
In-Reply-To: <tencent_2800749EBE11469445C462BE78A44E532209@qq.com>
On Tue, Dec 21, 2021 at 04:02:20PM +0800, Weiguo Li wrote:
> Fixes: 804c108b039a ("common/cnxk: set BPHY IRQ handler")
>
> Signed-off-by: Weiguo Li <liwg06 at foxmail.com>
> ---
> drivers/common/cnxk/roc_bphy_irq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/common/cnxk/roc_bphy_irq.c b/drivers/common/cnxk/roc_bphy_irq.c
> index f4e9b341af..5ba73c98dc 100644
> --- a/drivers/common/cnxk/roc_bphy_irq.c
> +++ b/drivers/common/cnxk/roc_bphy_irq.c
> @@ -261,9 +261,9 @@ roc_bphy_irq_handler_set(struct roc_bphy_irq_chip *chip, int irq_num,
> CPU_SET(curr_cpu, &intr_cpuset);
> retval = pthread_setaffinity_np(pthread_self(), sizeof(intr_cpuset),
> &intr_cpuset);
Use rc instead. This will generate less changes and will match
local conventions.
> - if (rc < 0) {
> + if (retval < 0) {
> plt_err("Failed to set affinity mask");
> - return rc;
> + return retval;
> }
>
> irq_usr.isr_base = (uint64_t)roc_bphy_intr_handler;
> --
> 2.25.1
>
next prev parent reply other threads:[~2022-01-21 19:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 8:02 [PATCH] common/cnxk: fix incorrect error checking Weiguo Li
2022-01-21 19:28 ` Tomasz Duszynski [this message]
2022-01-22 6:49 ` [PATCH v2] " Weiguo Li
2022-01-23 12:42 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YesIsXmlFGVMkLlf@arch \
--to=tomasz.duszynski@octakon.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=liwg06@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.