From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CFFBC433FE for ; Fri, 21 Jan 2022 22:09:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232146AbiAUWI6 (ORCPT ); Fri, 21 Jan 2022 17:08:58 -0500 Received: from mail-oi1-f180.google.com ([209.85.167.180]:45728 "EHLO mail-oi1-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbiAUWI5 (ORCPT ); Fri, 21 Jan 2022 17:08:57 -0500 Received: by mail-oi1-f180.google.com with SMTP id m9so1083159oia.12; Fri, 21 Jan 2022 14:08:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=B5PRJv8DW4GtoofF22Yvx5mcu38WclazOKtU1d0nT6U=; b=z1t8EgPdc82tFjmnizYT8KGo3305Uc1yE0e9m7QZxPg1FwTXH5rcTaho13UYF+EtUW idPsQImxcosKUSDsIXiPXNUeeYKVLspmEcreHVxfBXIK0z6X5jIJt5dMzDi10njumbIs fKhOlq7Pg7lMx5Eslsk7C3fQKGHbgT9Jme/lEUlfPpEkXp0gTMXrq/dqDxz4DwM45S9n G80mjwd+K3iBZfAjomwcV8/VjDpY2X7oAa4BkumwLkk+lnXYLqxSysBk6WdGuSAJDKRM R1WopoKP01xUyfoo5WttPIosRnvhIJiFg8s8n4/MYbZDyUyZ69LGYNc4kdSL1/112QyP UNpg== X-Gm-Message-State: AOAM531EBgBT5gQPH/bBFNi+tBarv7IUgZInBpUWgJySJwsRc9KA8HDP 5OppJvhrO/gSD0jk8RIR1zSQpkEYfg== X-Google-Smtp-Source: ABdhPJwnQunxSNcAMTfZBLYtlv7Gl89Wu2H4S7e1uRHLx4SML5xE5ON9F5makJ9I7cRXCkkJuPhyEQ== X-Received: by 2002:aca:b985:: with SMTP id j127mr2168884oif.92.1642802936359; Fri, 21 Jan 2022 14:08:56 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id l16sm1310898oop.45.2022.01.21.14.08.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 14:08:55 -0800 (PST) Received: (nullmailer pid 1682948 invoked by uid 1000); Fri, 21 Jan 2022 22:08:54 -0000 Date: Fri, 21 Jan 2022 16:08:54 -0600 From: Rob Herring To: Alistair Francis Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dmitry.torokhov@gmail.com, rydberg@bitmath.org, andreas@kemnade.info, linus.walleij@linaro.org, alistair23@gmail.com, =?iso-8859-1?Q?Myl=E8ne?= Josserand Subject: Re: [PATCH v5 2/4] dt-bindings: input: Add Cypress TT2100 touchscreen controller Message-ID: References: <20220109115331.388633-1-alistair@alistair23.me> <20220109115331.388633-3-alistair@alistair23.me> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220109115331.388633-3-alistair@alistair23.me> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 09, 2022 at 09:53:29PM +1000, Alistair Francis wrote: > From: Mylène Josserand > > Add the Cypress TrueTouch Generation 5 touchscreen device tree bindings > documentation. It can use I2C or SPI bus. > This touchscreen can handle some defined zone that are designed and > sent as button. To be able to customize the keycode sent, the > "linux,code" property in a "button" sub-node can be used. > > Signed-off-by: Mylène Josserand > Signed-off-by: Alistair Francis > --- > .../input/touchscreen/cypress,tt21000.yaml | 92 +++++++++++++++++++ > 1 file changed, 92 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml b/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml > new file mode 100644 > index 000000000000..acd2d9389f8c > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000.yaml > @@ -0,0 +1,92 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/touchscreen/cypress,tt21000.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cypress TT2100 touchscreen controller > + > +description: The Cypress TT2100 series (also known as "CYTTSP5" after > + the marketing name Cypress TrueTouch Standard Product series 5). > + > +maintainers: > + - Alistair Francis > + > +allOf: > + - $ref: touchscreen.yaml# > + > +properties: > + compatible: > + const: cypress,tt21000 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + vdd-supply: > + description: Regulator for voltage. > + > + reset-gpios: > + maxItems: 1 > + > + linux,code: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: EV_ABS specific event code generated by the axis. > + > +patternProperties: > + "^button-[0-9]+$": Where does the numbering come from? I assume it correlates to something in the h/w. If so, I think you should use 'reg' and a unit-address here. Generally, we don't want the node names to be important (i.e. used by the OS). > + type: object > + properties: > + linux,code: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Keycode to emit > + > + required: > + - linux,code > + > + additionalProperties: false > + > +required: > + - compatible > + - reg > + - interrupts > + - vdd-supply > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + touchscreen@24 { > + compatible = "cypress,tt21000"; > + reg = <0x24>; > + pinctrl-names = "default"; > + pinctrl-0 = <&tp_reset_ds203>; > + interrupt-parent = <&pio>; > + interrupts = <1 5 IRQ_TYPE_LEVEL_LOW>; > + reset-gpios = <&pio 7 1 GPIO_ACTIVE_LOW>; > + vdd-supply = <®_touch>; > + > + button-0 { > + linux,code = ; > + }; > + > + button-1 { > + linux,code = ; > + }; > + > + button-2 { > + linux,code = ; > + }; > + }; > + }; > +... > -- > 2.31.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20094C433F5 for ; Fri, 21 Jan 2022 22:11:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JGNyChhf9Wf/SIxYxue66Fi1MQBv3ZyaC01AMCZIeyY=; b=SG36kumVAJCiGK 9aOXG+9fsFwnbdIyP+2xtD2bWjiYAHKOu87zr0GsHBe8RFHePnQFM4HqRtapdYIvXqRP1lhiI5yr7 HJ/k/kgnBu0+hJN0nmhwDUUadr3BzDXqJOduyqAEPI61EoRIhICkKYtaBx6mQJHmjE10GLeZ1Sv54 4lDhB0Bx8f9xi1lRHmMiBwa1wbExDghVhagH74OsK45ZH0EVLEjZM9Rh88LeDo0cO853NQfxTHBfS Pu+TGJYBZO1OOoyWil0IdvJJTbzMnsbaVkSBmxO4BHM6+euIHFC2K7/k/vs54MAKyS7NH9hQNoG6/ hMn68JiPTaTnQksW9Zpw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nB25d-00GAEo-8v; Fri, 21 Jan 2022 22:09:01 +0000 Received: from mail-oi1-f179.google.com ([209.85.167.179]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nB25Z-00GAEV-LO for linux-arm-kernel@lists.infradead.org; Fri, 21 Jan 2022 22:08:59 +0000 Received: by mail-oi1-f179.google.com with SMTP id y14so15516674oia.9 for ; Fri, 21 Jan 2022 14:08:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=B5PRJv8DW4GtoofF22Yvx5mcu38WclazOKtU1d0nT6U=; b=abGxuq/EMFA3w8klsB5GRWaRpiPdl+TF0Z6BY2dhsUKOVfPzHj6gUIf3tLPot4ZnfW stz9mqNRnEDiDQvH0ek0djxotnJA2zA3BRzBTSSck4Feh3dlwOSknSBdkbSQ/twgpduA oTNe5pRNkZbbwzp+xYgP1HWnfnlSuqwGJM7JJhC4vkxkuacxOT55KjeboReSFnaB6nCh geBS4l/iy7JbUzrJk0+3inRK90N9GFB012Pzew/9v/9ULFU+RUSnKblcE9pQNJ1XSe+b 8vfIX5DPKnISemrETV7aymEgqLiJTD5D/puOXfPPg8b8qBZZKQ9+pwRla8EN/g/B/nm3 9BXg== X-Gm-Message-State: AOAM533WFW9wfziT4XPJrSgX4J0SucWwszOCjiGyOfrBo2vDK9TE8WSK HCSnwwJ6qF3g/BbZXJIPJg== X-Google-Smtp-Source: ABdhPJwnQunxSNcAMTfZBLYtlv7Gl89Wu2H4S7e1uRHLx4SML5xE5ON9F5makJ9I7cRXCkkJuPhyEQ== X-Received: by 2002:aca:b985:: with SMTP id j127mr2168884oif.92.1642802936359; Fri, 21 Jan 2022 14:08:56 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id l16sm1310898oop.45.2022.01.21.14.08.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 14:08:55 -0800 (PST) Received: (nullmailer pid 1682948 invoked by uid 1000); Fri, 21 Jan 2022 22:08:54 -0000 Date: Fri, 21 Jan 2022 16:08:54 -0600 From: Rob Herring To: Alistair Francis Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dmitry.torokhov@gmail.com, rydberg@bitmath.org, andreas@kemnade.info, linus.walleij@linaro.org, alistair23@gmail.com, =?iso-8859-1?Q?Myl=E8ne?= Josserand Subject: Re: [PATCH v5 2/4] dt-bindings: input: Add Cypress TT2100 touchscreen controller Message-ID: References: <20220109115331.388633-1-alistair@alistair23.me> <20220109115331.388633-3-alistair@alistair23.me> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220109115331.388633-3-alistair@alistair23.me> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220121_140857_731761_D055DB2F X-CRM114-Status: GOOD ( 22.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Jan 09, 2022 at 09:53:29PM +1000, Alistair Francis wrote: > From: Myl=E8ne Josserand > = > Add the Cypress TrueTouch Generation 5 touchscreen device tree bindings > documentation. It can use I2C or SPI bus. > This touchscreen can handle some defined zone that are designed and > sent as button. To be able to customize the keycode sent, the > "linux,code" property in a "button" sub-node can be used. > = > Signed-off-by: Myl=E8ne Josserand > Signed-off-by: Alistair Francis > --- > .../input/touchscreen/cypress,tt21000.yaml | 92 +++++++++++++++++++ > 1 file changed, 92 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/c= ypress,tt21000.yaml > = > diff --git a/Documentation/devicetree/bindings/input/touchscreen/cypress,= tt21000.yaml b/Documentation/devicetree/bindings/input/touchscreen/cypress,= tt21000.yaml > new file mode 100644 > index 000000000000..acd2d9389f8c > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/touchscreen/cypress,tt21000= .yaml > @@ -0,0 +1,92 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/touchscreen/cypress,tt21000.yam= l# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Cypress TT2100 touchscreen controller > + > +description: The Cypress TT2100 series (also known as "CYTTSP5" after > + the marketing name Cypress TrueTouch Standard Product series 5). > + > +maintainers: > + - Alistair Francis > + > +allOf: > + - $ref: touchscreen.yaml# > + > +properties: > + compatible: > + const: cypress,tt21000 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + vdd-supply: > + description: Regulator for voltage. > + > + reset-gpios: > + maxItems: 1 > + > + linux,code: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: EV_ABS specific event code generated by the axis. > + > +patternProperties: > + "^button-[0-9]+$": Where does the numbering come from? I assume it correlates to something = in the h/w. If so, I think you should use 'reg' and a unit-address here. = Generally, we don't want the node names to be important (i.e. used by = the OS). > + type: object > + properties: > + linux,code: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Keycode to emit > + > + required: > + - linux,code > + > + additionalProperties: false > + > +required: > + - compatible > + - reg > + - interrupts > + - vdd-supply > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + > + i2c { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + > + touchscreen@24 { > + compatible =3D "cypress,tt21000"; > + reg =3D <0x24>; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&tp_reset_ds203>; > + interrupt-parent =3D <&pio>; > + interrupts =3D <1 5 IRQ_TYPE_LEVEL_LOW>; > + reset-gpios =3D <&pio 7 1 GPIO_ACTIVE_LOW>; > + vdd-supply =3D <®_touch>; > + > + button-0 { > + linux,code =3D ; > + }; > + > + button-1 { > + linux,code =3D ; > + }; > + > + button-2 { > + linux,code =3D ; > + }; > + }; > + }; > +... > -- = > 2.31.1 > = > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel