All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: smfrench@gmail.com, nspmangalore@gmail.com,
	Jeff Layton <jlayton@kernel.org>,
	linux-cifs@vger.kernel.org, linux-cachefs@redhat.com,
	linux-fsdevel@vger.kernel.org
Subject: Re: [RFC PATCH 1/7] cifs: Transition from ->readpages() to ->readahead()
Date: Tue, 25 Jan 2022 14:20:21 +0000	[thread overview]
Message-ID: <YfAHJcXeSsAE4uMB@casper.infradead.org> (raw)
In-Reply-To: <164311906472.2806745.605202239282432844.stgit@warthog.procyon.org.uk>

On Tue, Jan 25, 2022 at 01:57:44PM +0000, David Howells wrote:
> +	while (readahead_count(ractl) - ractl->_batch_count) {

You do understand that prefixing a structure member with an '_' means
"Don't use this", right?  If I could get the compiler to prevent you, I
would.


  reply	other threads:[~2022-01-25 14:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-25 13:57 [RFC][RFC PATCH 0/7] cifs: In-progress conversion to use iov_iters and netfslib David Howells
2022-01-25 13:57 ` [RFC PATCH 1/7] cifs: Transition from ->readpages() to ->readahead() David Howells
2022-01-25 14:20   ` Matthew Wilcox [this message]
2022-01-25 14:57   ` David Howells
2022-01-25 13:57 ` [RFC PATCH 2/7] cifs: Miscellaneous bits David Howells
2022-01-25 13:57 ` [RFC PATCH 3/7] cifs: Change the I/O paths to use an iterator rather than a page list David Howells
2022-01-31  5:06   ` Rohith Surabattula
2022-01-31  5:48     ` Shyam Prasad N
2022-02-14 16:06   ` David Howells
2022-01-25 13:58 ` [RFC PATCH 4/7] cifs: Make cifs_writepages() hand an iterator down David Howells
2022-01-25 13:58 ` [RFC PATCH 5/7] cifs: Make cifs_readahead() pass " David Howells
2022-01-25 13:58 ` [RFC PATCH 6/7] cifs: Get direct I/O and unbuffered I/O working with iterators David Howells
2022-01-25 13:59 ` [RFC PATCH 7/7] cifs: Use netfslib to handle reads David Howells
2022-02-08  5:59   ` Rohith Surabattula
2022-02-14 16:33   ` David Howells
2022-02-28 14:14     ` Rohith Surabattula
2022-02-28 14:28     ` David Howells
2022-03-01  7:21       ` Rohith Surabattula
2022-03-01  9:39       ` David Howells
2022-03-02 13:51         ` Rohith Surabattula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YfAHJcXeSsAE4uMB@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=dhowells@redhat.com \
    --cc=jlayton@kernel.org \
    --cc=linux-cachefs@redhat.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=nspmangalore@gmail.com \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.