From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6CBEC3525A for ; Wed, 26 Jan 2022 03:01:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236735AbiAZDBG (ORCPT ); Tue, 25 Jan 2022 22:01:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236762AbiAZDBF (ORCPT ); Tue, 25 Jan 2022 22:01:05 -0500 Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DF70C061744 for ; Tue, 25 Jan 2022 19:01:05 -0800 (PST) Received: by mail-ot1-x32f.google.com with SMTP id b12-20020a9d754c000000b0059eb935359eso12024368otl.8 for ; Tue, 25 Jan 2022 19:01:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WqLr3bUKc3/S+u1sDbLC4idmG0JJP+2DdwsuGVPAvk8=; b=GsQLdGSwsxtUnqAb2Uc3cu1MF+dX6mgHWx1G2hcOVenLHx0gz5vxrqVvnzEreFNpkx b/aosD6iRlz9qWPpXfCFPHcg9zxRUV2BmeYI3xTHbvWUgyMtXEtrVGrOyasQ/7oOWoD4 86k5BDrOaL4a0xauOcVU185wsmBu2KV92HNKIhm5IfL0mHx4CUaYQBaTApdLcuwHQajf c0DsLcuhBsU11f2JxUZl+cGghF/PULOfs/5DLYhDJ2n6fZX2uDNG9GJWEuk45b0V4lmL KY5/WzYatjrR7djUcVOOnt1EpUfVxhmtaprlK7ltp+sqbnxJ95JOu0XxZwlJJqqHBuU9 AX8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WqLr3bUKc3/S+u1sDbLC4idmG0JJP+2DdwsuGVPAvk8=; b=hRINdD8hRv9BR27uqVm3F3Gpy0iQhiOLI64TQHX9s95lWFirGvmuSNbUSYapsO3Apr Zgmg09qfWVdz8PB8jaHUQ/A5YKMaEBrw+AGQJ9ws8ykWDV1pzp8H9lwmcyqSt8NMTRvQ yy/go4DPcF+Ozj3umlG/A59rGLXDTNBl6CN1Q0BcsveSOPzP+NewJfB36GhJX23vmUnQ BfcULF0nSGGP5/wFqNeWT5Lh7k/mxEOGWJnm3gTXHrOwB1VRVlKBq7E1BYlLIJm8uH+J 4fWruXXDUJJLD4YwVZP4sXbsJ4NO8XyhCIHMTnV05wVVt2ubTgEGOD0a5SZ8V805BXAX wU0w== X-Gm-Message-State: AOAM530BhTdnmHr2UZceNNJm5vHfLxWnqW4ZBBGYGILnSutWhp3jWb+v KmhmxfnyvdWpL3RGAcjoOA3ERw== X-Google-Smtp-Source: ABdhPJwwKNXHXBpaK+MGuS4uhoTeazChcTR+LtX2cBDSv8QAb8uKdHZd1PyrXWukpd1LIzNOZcoMzw== X-Received: by 2002:a05:6830:13d2:: with SMTP id e18mr16390380otq.152.1643166064526; Tue, 25 Jan 2022 19:01:04 -0800 (PST) Received: from ripper ([2600:1700:a0:3dc8:205:1bff:fec0:b9b3]) by smtp.gmail.com with ESMTPSA id m130sm8273829oif.21.2022.01.25.19.01.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jan 2022 19:01:03 -0800 (PST) Date: Tue, 25 Jan 2022 19:01:31 -0800 From: Bjorn Andersson To: Doug Anderson Cc: Stephen Boyd , Konrad Dybcio , kgodara@codeaurora.org, Matthias Kaehlcke , Sibi Sankar , Prasad Malisetty , quic_rjendra@quicinc.com, Andy Gross , Rob Herring , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-msm , LKML Subject: Re: [PATCH v2 5/5] arm64: dts: qcom: sc7280: Add herobrine-r1 Message-ID: References: <20220125224422.544381-1-dianders@chromium.org> <20220125144316.v2.5.I5604b7af908e8bbe709ac037a6a8a6ba8a2bfa94@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue 25 Jan 15:46 PST 2022, Doug Anderson wrote: > Hi, > > On Tue, Jan 25, 2022 at 2:58 PM Stephen Boyd wrote: > > > > Quoting Douglas Anderson (2022-01-25 14:44:22) > > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dts > > > new file mode 100644 > > > index 000000000000..f95273052da0 > > > --- /dev/null > > > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dts > > > @@ -0,0 +1,313 @@ > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > +/* > > > + * Google Herobrine board device tree source > > > + * > > > + * Copyright 2022 Google LLC. > > > + */ > > > + > > > +/dts-v1/; > > > + > > > +#include "sc7280-herobrine.dtsi" > > > + > > > +/ { > > > + model = "Google Herobrine (rev1+)"; > > > + compatible = "google,herobrine", "qcom,sc7280"; > > > > Can we stop adding "qcom,sc7280" to the board compatible string? It > > looks out of place. It's the compatible for the SoC and should really be > > the compatible for the /soc node. > > I don't have any objections, but I feel like this is the type of thing > I'd like Bjorn to have the final say on. What say you, Bjorn? > One practical case I can think of right away, where this matters is in cpufreq-dt-plat.c where we blocklist qcom,sc7280. I don't know if we rely on this in any other places, but I'm not keen on seeing a bunch of board-specific compatibles sprinkled throughout the implementation - it's annoying enough having to add each platform to these drivers. Regards, Bjorn > > > > + pp3300_left_in_mlb: pp3300-left-in-mlb { > > > > Sometimes '-regulator' is left out. Is that intentional? I suppose it > > would be better if every node had regulator postfix, but it may be too > > long of a node name? > > Huh, you're right. No, it's not intentional. It looks like it was that > way on herobrine-rev0 too... It also looks like it's missing on > "pp3300-hub" on trogdor. > > Happy to add "-regulator" in the herobrine / trogdor nodes that need > it. I'll probably do it as a follow-on patch if that works OK? Then I > can just clean them all up at once... > > -Doug