From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 930F3C28CF5 for ; Wed, 26 Jan 2022 18:58:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231440AbiAZS6f (ORCPT ); Wed, 26 Jan 2022 13:58:35 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:59724 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231244AbiAZS6f (ORCPT ); Wed, 26 Jan 2022 13:58:35 -0500 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0D254478; Wed, 26 Jan 2022 19:58:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1643223514; bh=rvsqL/3XvWs9plwH/YhVRZkIJ3zfYCZfStAlgtWaVeM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Hs8VbJNGEA3dP409dMSPg52YiEOwzcbFra0S4u6Rkzi4ieTR6wBn9ADPrTHXRl7KM DFRsdpZu4rhheNtPPsQFU4azEGV3bOGE4AIgVNplrqMA4sq452zR2pRJZ0OrcJguCy YodkN5e4rcyqzBWD+jhni5Xrh6S3uanJNWE6zWOM= Date: Wed, 26 Jan 2022 20:58:15 +0200 From: Laurent Pinchart To: Geert Uytterhoeven Cc: Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Rob Herring , Kieran Bingham , Geert Uytterhoeven , Magnus Damm , Chris Paterson Subject: Re: [PATCH v2 1/3] arm64: dts: renesas: Prepare AA1024XD12 panel .dtsi for overlay support Message-ID: References: <20211229193135.28767-1-laurent.pinchart+renesas@ideasonboard.com> <20211229193135.28767-2-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Geert, On Wed, Jan 26, 2022 at 01:18:56PM +0100, Geert Uytterhoeven wrote: > On Wed, Dec 29, 2021 at 8:31 PM Laurent Pinchart wrote: > > The Mitsubishi AA1024XD12 panel can be used for R-Car Gen2 and Gen3 > > boards as an optional external panel. It is described in the > > arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi file as a direct child of the > > DT root node. This allows including r8a77xx-aa104xd12-panel.dtsi in > > board device trees, with other minor modifications, to enable the panel. > > > > This is however not how external components should be modelled. Instead > > of modifying the board device tree to enable the panel, it should be > > compiled as a DT overlay, to be loaded by the boot loader. > > > > Prepare the r8a77xx-aa104xd12-panel.dtsi file for this usage by > > declaring a panel node only, without hardcoding its path. Overlay > > sources can then include r8a77xx-aa104xd12-panel.dtsi where appropriate. > > > > This change doesn't cause any regression as r8a77xx-aa104xd12-panel.dtsi > > is currently unused. As overlay support for this panel has only been > > tested with Gen3 hardware, and Gen2 support will require more > > development, move the file to arch/arm64/boot/dts/renesas/. > > > > Signed-off-by: Laurent Pinchart > > Thanks for your patch! > > > --- a/arch/arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi > > > - * Copyright (C) 2014 Renesas Electronics Corp. > > > +++ b/arch/arm64/boot/dts/renesas/panel-aa104xd12.dtsi > > > + * Copyright (C) 2021 Renesas Electronics Corp. > > Shouldn't you keep the year? Not much has changed. Indeed. > Reviewed-by: Geert Uytterhoeven I see you've reviewed the whole series. Can you pick it up ? -- Regards, Laurent Pinchart