From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6577F2CA9 for ; Wed, 26 Jan 2022 22:54:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1EC5C340E3; Wed, 26 Jan 2022 22:54:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643237669; bh=55iCsDTeS4TYYqiGASJPJulq2w6UsXoqvp8QlgU+8lU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bQ4pdCQIUH35jlLiU8KlpqtJbUegpHgOPu4nVq4HLkdBpcZ+ZcsX6eUFpZN0YuGEM iWLP41LksYa/t/u7pZDbX4pWxd1IIyzGfBclRlG5h+lRbDdwNyCQ7xfRNf1eeX+7lj xn8InPfOiEBMXiJpLowr4QBoGDovWzMDQahuS5Yq1diqHw4Eufvp541Lg0Xk9r9R1F evQ2/FTYxqw/iAgKxfaWmBq/YtZPortMAfnFIhMkgrMMawVqvpSKYUZDMyEa4l5V1Z zzahVIQzk6/g3g2gC9NBVvzhXNXYcpYqssVcfmJa0I3Yw7x8beFxSH4643qPI7dxzf K2zcrTZTeJViQ== Date: Wed, 26 Jan 2022 14:54:27 -0800 From: Eric Biggers To: "Jason A. Donenfeld" Cc: Linux ARM , Linux Crypto Mailing List , Linux Kernel Mailing List , llvm@lists.linux.dev, Nick Desaulniers , Sami Tolvanen , Nathan Chancellor , Herbert Xu , Miles Chen , Ard Biesheuvel Subject: Re: [PATCH v2] lib/crypto: blake2s: avoid indirect calls to compression function for Clang CFI Message-ID: References: <20220119135450.564115-1-Jason@zx2c4.com> <20220124192849.14755-1-Jason@zx2c4.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jan 25, 2022 at 01:23:34PM +0100, Jason A. Donenfeld wrote: > On 1/25/22, Eric Biggers wrote: > > On Mon, Jan 24, 2022 at 08:28:49PM +0100, Jason A. Donenfeld wrote: > >> blake2s_compress_generic is weakly aliased by blake2s_generic. The > > > > Don't you mean "weakly aliased by blake2s_compress"? > > Grrrr. Thanks. > > >> Changes v1->v2: > >> - Wrapped columns at 80 for Eric. > > > > It is the recommended coding style, so not just for me :-) > > I was under the impression this increased to 100 mid-2020 or so, and > checkpatch.pl now makes noise at that width instead. >From Documentation/process/coding-style.rst: "The preferred limit on the length of a single line is 80 columns. Statements longer than 80 columns should be broken into sensible chunks, unless exceeding 80 columns significantly increases readability and does not hide information." It's not as strict as it used to be, but checkpatch seems to be overly-lenient. I always run it with --max-line-length=80. - Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B87ABC433FE for ; Wed, 26 Jan 2022 22:55:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=a6DE4MSqk3VT4AV9viUC7bcPl901nRsmOlACJSJNzqI=; b=bb3CxbiwwIC5qL xSQFVVvinlhQfGk2IV9EBiktd2Qg3BLrJh/UKQCmHPE9Kzqf8yJv8HvWwQ6ivWjoD9lbjLP2XL4Vk jucRLW2K1JVnvStRiVjmhpMEKCwO6M8/y5JPzPY0OXxtQMuqOypGvhvpQyH94Br0DcoTlPjBOgwSv YfjvoXEiLsQaOAz8g1jlv7qMZe59PWlGM1pZqa2vk1eakS8x2UTVIOyUipw6zH2cCkWTnrp7lRSR7 3CRaExUUSSWBhqqZ1hBwO8DCz8S4QDKjLazBs9IyLa2zMhFa+VuDyyjX5XAjCi9CkOR6puKVPqpXK g5mJWFCQs3sfdCTNFbog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCrBS-00DiXT-IO; Wed, 26 Jan 2022 22:54:34 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCrBO-00DiW9-O6 for linux-arm-kernel@lists.infradead.org; Wed, 26 Jan 2022 22:54:32 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9F09961A11; Wed, 26 Jan 2022 22:54:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1EC5C340E3; Wed, 26 Jan 2022 22:54:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643237669; bh=55iCsDTeS4TYYqiGASJPJulq2w6UsXoqvp8QlgU+8lU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bQ4pdCQIUH35jlLiU8KlpqtJbUegpHgOPu4nVq4HLkdBpcZ+ZcsX6eUFpZN0YuGEM iWLP41LksYa/t/u7pZDbX4pWxd1IIyzGfBclRlG5h+lRbDdwNyCQ7xfRNf1eeX+7lj xn8InPfOiEBMXiJpLowr4QBoGDovWzMDQahuS5Yq1diqHw4Eufvp541Lg0Xk9r9R1F evQ2/FTYxqw/iAgKxfaWmBq/YtZPortMAfnFIhMkgrMMawVqvpSKYUZDMyEa4l5V1Z zzahVIQzk6/g3g2gC9NBVvzhXNXYcpYqssVcfmJa0I3Yw7x8beFxSH4643qPI7dxzf K2zcrTZTeJViQ== Date: Wed, 26 Jan 2022 14:54:27 -0800 From: Eric Biggers To: "Jason A. Donenfeld" Cc: Linux ARM , Linux Crypto Mailing List , Linux Kernel Mailing List , llvm@lists.linux.dev, Nick Desaulniers , Sami Tolvanen , Nathan Chancellor , Herbert Xu , Miles Chen , Ard Biesheuvel Subject: Re: [PATCH v2] lib/crypto: blake2s: avoid indirect calls to compression function for Clang CFI Message-ID: References: <20220119135450.564115-1-Jason@zx2c4.com> <20220124192849.14755-1-Jason@zx2c4.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220126_145430_868514_79EDA8A3 X-CRM114-Status: GOOD ( 18.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 25, 2022 at 01:23:34PM +0100, Jason A. Donenfeld wrote: > On 1/25/22, Eric Biggers wrote: > > On Mon, Jan 24, 2022 at 08:28:49PM +0100, Jason A. Donenfeld wrote: > >> blake2s_compress_generic is weakly aliased by blake2s_generic. The > > > > Don't you mean "weakly aliased by blake2s_compress"? > > Grrrr. Thanks. > > >> Changes v1->v2: > >> - Wrapped columns at 80 for Eric. > > > > It is the recommended coding style, so not just for me :-) > > I was under the impression this increased to 100 mid-2020 or so, and > checkpatch.pl now makes noise at that width instead. >From Documentation/process/coding-style.rst: "The preferred limit on the length of a single line is 80 columns. Statements longer than 80 columns should be broken into sensible chunks, unless exceeding 80 columns significantly increases readability and does not hide information." It's not as strict as it used to be, but checkpatch seems to be overly-lenient. I always run it with --max-line-length=80. - Eric _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel