From: Matthew Wilcox <willy@infradead.org>
To: Daniel Black <daniel@mariadb.org>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: fcntl(fd, F_SETFL, O_DIRECT) succeeds followed by EINVAL in write
Date: Thu, 27 Jan 2022 04:37:33 +0000 [thread overview]
Message-ID: <YfIhjVB2gT6/EVc5@casper.infradead.org> (raw)
In-Reply-To: <CABVffEM4KhSNywBVg06XN5JpsDaONKf7wQiKvrTvqGXosssXLg@mail.gmail.com>
On Thu, Jan 27, 2022 at 01:38:58PM +1100, Daniel Black wrote:
> > Sorry for the confusion. You've caught us mid-transition. Eventually,
> > ->direct_IO will be deleted, but for now it signifies whether or not the
> > filesystem supports O_DIRECT, even though it's not used (except in some
> > scenarios you don't care about).
>
> being executed at the bottom of setfl which keeps the file descriptor
> out of O_DIRECT mode when
> the filesystem (like CIFS doesn't support it). In the original strace
Apparently I wasn't clear ...
CIFS absolutely does support O_DIRECT. It does not do it by calling
->direct_IO; instead it's handled in cifs_loose_read_iter().
prev parent reply other threads:[~2022-01-27 4:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 22:05 fcntl(fd, F_SETFL, O_DIRECT) succeeds followed by EINVAL in write Daniel Black
2022-01-26 3:02 ` Matthew Wilcox
2022-01-26 22:03 ` Daniel Black
2022-01-26 22:15 ` Matthew Wilcox
2022-01-26 23:16 ` Daniel Black
2022-01-27 2:38 ` Daniel Black
2022-01-27 4:37 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfIhjVB2gT6/EVc5@casper.infradead.org \
--to=willy@infradead.org \
--cc=daniel@mariadb.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.