From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Xiaoyao Li <xiaoyao.li@intel.com>, Like Xu <likexu@tencent.com>
Subject: Re: [PATCH 0/3] KVM: x86: XSS and XCR0 fixes
Date: Thu, 27 Jan 2022 15:03:27 +0000 [thread overview]
Message-ID: <YfK0P67bo5oSPXn4@google.com> (raw)
In-Reply-To: <f1389ace-6f5d-9f48-bb12-4835c29e6402@redhat.com>
On Thu, Jan 27, 2022, Paolo Bonzini wrote:
> On 1/26/22 18:48, Sean Christopherson wrote:
> > On Wed, Jan 26, 2022, Paolo Bonzini wrote:
> > > On 1/26/22 18:22, Sean Christopherson wrote:
> > > > For convenience, Like's patch split up and applied on top of Xiaoyao.
> > > > Tagged all for @stable, probably want to (retroactively?) get Xiaoyao's
> > > > patch tagged too?
> > > > Like Xu (2):
> > > > KVM: x86: Update vCPU's runtime CPUID on write to MSR_IA32_XSS
> > > > KVM: x86: Sync the states size with the XCR0/IA32_XSS at, any time
> > > >
> > > > Xiaoyao Li (1):
> > > > KVM: x86: Keep MSR_IA32_XSS unchanged for INIT
> > > >
> > > > arch/x86/kvm/x86.c | 6 +++---
> > > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > > >
> > > >
> > > > base-commit: e2e83a73d7ce66f62c7830a85619542ef59c90e4
> > >
> > > Queued, though I'll note that I kinda disagree with the stable@ marking of
> > > patch 1 (and therefore with the patch order) as it has no effect in
> > > practice.
> >
> > Hmm, that's not a given, is it? E.g. the guest can configure XSS early on and
> > then expect the configured value to live across INIT-SIPI-SIPI. I agree it's
> > highly unlikely for any guest to actually do that, but I don't like assuming all
> > guests will behave a certain way.
>
> No, I meant in the sense that supported_xss is always zero right now, and
> therefore so is MSR_IA32_XSS.
Oh, duh.
prev parent reply other threads:[~2022-01-27 15:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 17:22 [PATCH 0/3] KVM: x86: XSS and XCR0 fixes Sean Christopherson
2022-01-26 17:22 ` [PATCH 1/3] KVM: x86: Keep MSR_IA32_XSS unchanged for INIT Sean Christopherson
2022-01-26 17:22 ` [PATCH 2/3] KVM: x86: Update vCPU's runtime CPUID on write to MSR_IA32_XSS Sean Christopherson
2022-01-26 17:22 ` [PATCH 3/3] KVM: x86: Sync the states size with the XCR0/IA32_XSS at, any time Sean Christopherson
2022-01-26 17:43 ` [PATCH 0/3] KVM: x86: XSS and XCR0 fixes Paolo Bonzini
2022-01-26 17:48 ` Sean Christopherson
2022-01-27 12:09 ` Paolo Bonzini
2022-01-27 15:03 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfK0P67bo5oSPXn4@google.com \
--to=seanjc@google.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=likexu@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.