All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@kernel.org>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
	Dmitry Osipenko <digetx@gmail.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] i2c: tegra: allow DVC support to be compiled out
Date: Thu, 27 Jan 2022 22:31:50 +0100	[thread overview]
Message-ID: <YfMPRj8H8nT4rFZb@shikoro> (raw)
In-Reply-To: <ebe847bb25016e743c28bd38a10c966b04b06cc8.1642535860.git.mirq-linux@rere.qmqm.pl>

[-- Attachment #1: Type: text/plain, Size: 542 bytes --]

Hi Michał,

> ---
> v2: remove KConfig symbol as per Dmitry Osipenko's suggestion.
>     (Assuming that for Tegra20 the DVC part will be used anyway.)
> 
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>

Your SoB should be above the "---" line.

> +#define IS_DVC(dev) (IS_ENABLED(CONFIG_ARCH_TEGRA_2x_SOC) && dev->is_dvc)

'checkpatch --strict' IMO rightfully mentions that 'dev' should be in
paranthesis when being used.

Both comments apply to patch 2 as well. Otherwise looks good!

Thanks,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      parent reply	other threads:[~2022-01-27 21:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-18 20:00 [PATCH v2 0/2] i2c: tegra: allow compiling out support for Tegra's special constrollers Michał Mirosław
2022-01-18 20:00 ` [PATCH v2 2/2] i2c: tegra: allow VI support to be compiled out Michał Mirosław
2022-01-18 20:33   ` Dmitry Osipenko
2022-01-18 20:00 ` [PATCH v2 1/2] i2c: tegra: allow DVC " Michał Mirosław
2022-01-18 20:33   ` Dmitry Osipenko
2022-01-27 21:31   ` Wolfram Sang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YfMPRj8H8nT4rFZb@shikoro \
    --to=wsa@kernel.org \
    --cc=digetx@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=ldewangan@nvidia.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mirq-linux@rere.qmqm.pl \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.