From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39AADC433EF for ; Fri, 28 Jan 2022 10:26:56 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2DC96837CE; Fri, 28 Jan 2022 11:26:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=thorsis.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 55474837E7; Fri, 28 Jan 2022 11:26:53 +0100 (CET) Received: from mail.thorsis.com (mail.thorsis.com [92.198.35.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E4200837C9 for ; Fri, 28 Jan 2022 11:26:50 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=thorsis.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ada@thorsis.com Received: from localhost (localhost [127.0.0.1]) by mail.thorsis.com (Postfix) with ESMTP id 873062955 for ; Fri, 28 Jan 2022 11:26:50 +0100 (CET) Received: from mail.thorsis.com ([127.0.0.1]) by localhost (mail.thorsis.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hQP6MCd5KMDT for ; Fri, 28 Jan 2022 11:26:50 +0100 (CET) Received: by mail.thorsis.com (Postfix, from userid 109) id 659DB2981; Fri, 28 Jan 2022 11:26:50 +0100 (CET) Date: Fri, 28 Jan 2022 11:26:46 +0100 From: Alexander Dahl To: Grant Edwards Cc: u-boot@lists.denx.de Subject: Re: How to modify defconfig file - make savedefconfig? Message-ID: Mail-Followup-To: Grant Edwards , u-boot@lists.denx.de References: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Hello Grant, Am Thu, Jan 27, 2022 at 04:46:48PM -0000 schrieb Grant Edwards: > What is the "right" way to modify a defconfig file? > > Most sources I've found just say things like "edit the defconfig > file". That seems error-prone -- especially when dealing with settings > that have side effects. > > I did stumble across one mention of "make savedefconfig", and this > seems to be the right way to modify a defconfig file: > > make myboard_defconfig > make menuconfig > make savedefconfig > cp defconfig configs/myboard_defconfig That's what I do. > Do people manually edit their defconfig file when they want to make a > change, or do they use "make savedefconfig" like I show above? You can do both. If you already have a defconfig, this: 1) edit your myboard_defconfig 2) make myboard_defconfig 3) make savedefconfig 4) cp defconfig configs/myboard_defconfig You might want to `git add configs/myboard_defconfig` in between those stages if you want to inspect what changed with those calls. > One reason I'm asking is that the original defconfig file provided by > the silicon vendor (Renesas) appears to be a manually stripped-down > ..config file, because when I do > > make vendors_defconfig > make savedefconfig > > The defconfig file generated by 'make savedefconfig' looks _nothing_ > like the starting vendors_defconfig. The new defconfig generates the > same .config file as the vendors_defconfig file. But the > vendors_defconfig file is arranged completely differently with > different/extra comments, extra blank lines, etc. I think U-Boot expects those files to be created by savedefconfig, see all the changesets in Git reading 'configs: Resync with savedefconfig'. Greets Alex