From: Anthony PERARD <anthony.perard@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>,
"George Dunlap" <george.dunlap@citrix.com>,
"Paul Durrant" <paul@xen.org>,
"Tamas K Lengyel" <tamas@tklengyel.com>,
"Petre Pircalabu" <ppircalabu@bitdefender.com>,
"Alexandru Isaila" <aisaila@bitdefender.com>
Subject: Re: [PATCH v3 1/2] IOMMU/x86: disallow device assignment to PoD guests
Date: Fri, 28 Jan 2022 16:07:33 +0000 [thread overview]
Message-ID: <YfQUxVUEEPuQzewP@perard> (raw)
In-Reply-To: <b0a77526-17f2-a5ab-6f7f-1b3caeb4a59b@suse.com>
On Tue, Jan 04, 2022 at 10:41:32AM +0100, Jan Beulich wrote:
> While it is okay for IOMMU page tables to get set up for guests starting
> in PoD mode, actual device assignment may only occur once all PoD
> entries have been removed from the P2M. So far this was enforced only
> for boot-time assignment, and only in the tool stack.
>
> Also use the new function to replace p2m_pod_entry_count(): Its unlocked
> access to p2m->pod.entry_count wasn't really okay (irrespective of the
> result being stale by the time the caller gets to see it).
>
> To allow the tool stack to see a consistent snapshot of PoD state, move
> the tail of XENMEM_{get,set}_pod_target handling into a function, adding
> proper locking there.
>
> In libxl take the liberty to use the new local variable r also for a
> pre-existing call into libxc.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Anthony PERARD <anthony.perard@citrix.com>
Thanks,
--
Anthony PERARD
next prev parent reply other threads:[~2022-01-28 16:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 9:39 [PATCH v3 0/2] x86/mm: get/set PoD target related adjustments Jan Beulich
2022-01-04 9:41 ` [PATCH v3 1/2] IOMMU/x86: disallow device assignment to PoD guests Jan Beulich
2022-01-27 15:02 ` Ping: " Jan Beulich
2022-01-28 16:07 ` Anthony PERARD [this message]
2022-02-02 16:13 ` Roger Pau Monné
2022-02-03 8:31 ` Jan Beulich
2022-02-03 9:04 ` Roger Pau Monné
2022-02-03 9:21 ` Jan Beulich
2022-02-03 9:52 ` Roger Pau Monné
2022-02-03 10:20 ` Jan Beulich
2022-02-03 10:23 ` Roger Pau Monné
2022-01-04 9:41 ` [PATCH v3 2/2] x86/mm: tidy XENMEM_{get,set}_pod_target handling Jan Beulich
2022-01-27 15:03 ` Ping: " Jan Beulich
2022-02-02 15:14 ` Roger Pau Monné
2022-02-02 15:29 ` Jan Beulich
2022-02-04 9:28 ` Roger Pau Monné
2022-02-04 9:36 ` Jan Beulich
2022-04-11 9:47 ` [PATCH v4] IOMMU/x86: disallow device assignment to PoD guests Jan Beulich
2022-04-11 10:29 ` Roger Pau Monné
2022-04-11 10:43 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfQUxVUEEPuQzewP@perard \
--to=anthony.perard@citrix.com \
--cc=aisaila@bitdefender.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=jbeulich@suse.com \
--cc=paul@xen.org \
--cc=ppircalabu@bitdefender.com \
--cc=roger.pau@citrix.com \
--cc=tamas@tklengyel.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.