All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@zeniv.linux.org.uk>
To: Tal Zussman <tz2294@columbia.edu>
Cc: "open list:FILESYSTEMS (VFS and infrastructure)" 
	<linux-fsdevel@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	Xijiao Li <xl2950@columbia.edu>,
	Hans Montero <hjm2133@columbia.edu>,
	Theodore Ts'o <tytso@mit.edu>,
	OS-TA <cucs4118-tas@googlegroups.com>
Subject: Re: [PATCH] fs: Remove FIXME comment in generic_write_checks()
Date: Sun, 30 Jan 2022 19:35:07 +0000	[thread overview]
Message-ID: <Yfboax2Yw/s5xAnp@zeniv-ca.linux.org.uk> (raw)
In-Reply-To: <20211231075750.GA1376@charmander>

On Fri, Dec 31, 2021 at 02:57:50AM -0500, Tal Zussman wrote:
> This patch removes an unnecessary comment that had to do with block special
> files from `generic_write_checks()`.
> 
> The comment, originally added in Linux v2.4.14.9, was to clarify that we only
> set `pos` to the file size when the file was opened with `O_APPEND` if the file
> wasn't a block special file. Prior to Linux v2.4, block special files had a
> different `write()` function which was unified into a generic `write()` function
> in Linux v2.4. This generic `write()` function called `generic_write_checks()`.
> For more details, see this earlier conversation:
> https://lore.kernel.org/linux-fsdevel/Yc4Czk5A+p5p2Y4W@mit.edu/
> 
> Currently, block special devices have their own `write_iter()` function and no
> longer share the same `generic_write_checks()`, therefore rendering the comment
> irrelevant.

Applied

      reply	other threads:[~2022-01-30 19:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-31  7:57 [PATCH] fs: Remove FIXME comment in generic_write_checks() Tal Zussman
2022-01-30 19:35 ` Al Viro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yfboax2Yw/s5xAnp@zeniv-ca.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=cucs4118-tas@googlegroups.com \
    --cc=hjm2133@columbia.edu \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=tz2294@columbia.edu \
    --cc=xl2950@columbia.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.