From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AEDDC433F5 for ; Tue, 1 Feb 2022 02:34:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF62D8D004D; Mon, 31 Jan 2022 21:34:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B7F208D0028; Mon, 31 Jan 2022 21:34:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1F2D8D004D; Mon, 31 Jan 2022 21:34:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0098.hostedemail.com [216.40.44.98]) by kanga.kvack.org (Postfix) with ESMTP id 9006D8D0028 for ; Mon, 31 Jan 2022 21:34:37 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 42E3E181AF5E6 for ; Tue, 1 Feb 2022 02:34:37 +0000 (UTC) X-FDA: 79092642594.09.AD09DD5 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id CB958100002 for ; Tue, 1 Feb 2022 02:34:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=RI6w30kdWOnyABxvZ/o4Gq+FApJQmABOxTdHVc8jQkw=; b=pldOf3hmMtWjXG3qgJMya8Uoa4 eFxicUnS1qoAmyHLjY56pklFxjPpQxl5b8fS64QJxt+Jan0FV9RWvZmM0icPU6+XPcdZUWwnaT7C/ nqd/RANtkuWXHvrlCijEw+0jxrhpdQVojC1YMLQJlK4SI8R0jr/7wWLIvqSk1ogWiV3ti3c1mnesJ CL13CaL4io7tkj+i4w7iTbIW2LeBXm6Y0Cj5+sSB7mtH2Tynzc7HSDx2A9abmmNQ57LpH5OKQ3w0F dPvxghExqwKhSBcBdtFIVa76SW4ShOBBrwNcfttx0mo5ZZoeljsNHr8J6kjTtNZEM2HTFCsru8pHn AH7F4GHg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEizw-00BEH5-9O; Tue, 01 Feb 2022 02:34:24 +0000 Date: Tue, 1 Feb 2022 02:34:24 +0000 From: Matthew Wilcox To: Joao Martins Cc: Jane Chu , Naoya Horiguchi , linux-mm@kvack.org, Andrew Morton Subject: Re: [RFC] Missing compound_head() in memory-failure Message-ID: References: <30a327fd-ae49-7412-ef77-9ec19480626e@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <30a327fd-ae49-7412-ef77-9ec19480626e@oracle.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: CB958100002 X-Stat-Signature: wy4f5j3mrp1ghe69wa9dpw4yxg74cnnf X-Rspam-User: nil Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=pldOf3hm; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-HE-Tag: 1643682876-112949 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 31, 2022 at 08:54:39PM +0000, Joao Martins wrote: > > > On 1/31/22 20:29, Matthew Wilcox wrote: > > Unless I am mistaken, you have to pass the compound head of the page > > which has the error to collect_procs(). Am I mistaken? > > > -rc2 already has a fix for it: > > https://lore.kernel.org/linux-mm/20220129021420.PgBIZm-q9%25akpm@linux-foundation.org/ > > Earlier in that function there's a: > > page = compound_head(page); > > So the @page passed to collect_procs() already is a head page. Well, that'll teach me to be two days behind on Linus' tree ;-)