From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF2ACC433FE for ; Tue, 1 Feb 2022 14:32:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239354AbiBAOcq (ORCPT ); Tue, 1 Feb 2022 09:32:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239361AbiBAOcm (ORCPT ); Tue, 1 Feb 2022 09:32:42 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F28B4C061714 for ; Tue, 1 Feb 2022 06:32:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=I18tNObjVFDm/kZz3nk5PXOupFozTlFQM8ZlXVFWPRs=; b=XrkHdF9USSifp4SbR3sZpOZ0kz Oi3rg5K3Jj5wB03eUvBmUIJ8/vXxdMtjf37JlmIjTsY9QvCIm8OGDbIXaQPu+BUQSlHjH0tRsqgZL FH2K7sOcOVSl8qx79SSqds2hpS+K6WT+8ojS25qzquvzfo2yGJG0oO6/i7RU8uKnz/lrO+HjrN76z FbIdSkNyY/G+wHjIG50uF/d4Yj7lEjZs6FiBww7q7cZnf26Afopz5cIy2krYoHsCOcxon3nSeVZ8U 02fO7PBYwYzcpz3R9eVDMJt7H73cKtAH3Lh+ne5l4GrojSutG6k8JKx3qN/fd9MGhYMKh9cEe6O5h fF6cOQfQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56966) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nEuCw-0000hf-Bi; Tue, 01 Feb 2022 14:32:34 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nEuCo-00028V-8b; Tue, 01 Feb 2022 14:32:26 +0000 Date: Tue, 1 Feb 2022 14:32:26 +0000 From: "Russell King (Oracle)" To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Andre Przywara , Christoffer Dall , Jintack Lim , Haibo Xu , Ganapatrao Kulkarni , Chase Conklin , James Morse , Suzuki K Poulose , Alexandru Elisei , karl.heubaum@oracle.com, mihai.carabas@oracle.com, miguel.luis@oracle.com, kernel-team@android.com Subject: Re: [PATCH v6 07/64] KVM: arm64: nv: Handle HCR_EL2.NV system register traps Message-ID: References: <20220128121912.509006-1-maz@kernel.org> <20220128121912.509006-8-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220128121912.509006-8-maz@kernel.org> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, Jan 28, 2022 at 12:18:15PM +0000, Marc Zyngier wrote: > From: Jintack Lim > > ARM v8.3 introduces a new bit in the HCR_EL2, which is the NV bit. When > this bit is set, accessing EL2 registers in EL1 traps to EL2. In > addition, executing the following instructions in EL1 will trap to EL2: > tlbi, at, eret, and msr/mrs instructions to access SP_EL1. Most of the > instructions that trap to EL2 with the NV bit were undef at EL1 prior to > ARM v8.3. The only instruction that was not undef is eret. > > This patch sets up a handler for EL2 registers and SP_EL1 register > accesses at EL1. The host hypervisor keeps those register values in > memory, and will emulate their behavior. > > This patch doesn't set the NV bit yet. It will be set in a later patch > once nested virtualization support is completed. > > Signed-off-by: Jintack Lim > [maz: EL2_REG() macros] > Signed-off-by: Marc Zyngier Reviewed-by: Russell King (Oracle) Thanks! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2FF5C433EF for ; Tue, 1 Feb 2022 14:32:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 63BE243C8C; Tue, 1 Feb 2022 09:32:44 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@armlinux.org.uk Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0PoAUCLRE8Xo; Tue, 1 Feb 2022 09:32:43 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id EE6F649EEE; Tue, 1 Feb 2022 09:32:42 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 1825F49ECC for ; Tue, 1 Feb 2022 09:32:42 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0YABVfVzHUCm for ; Tue, 1 Feb 2022 09:32:40 -0500 (EST) Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 50B3B43C8C for ; Tue, 1 Feb 2022 09:32:40 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=I18tNObjVFDm/kZz3nk5PXOupFozTlFQM8ZlXVFWPRs=; b=XrkHdF9USSifp4SbR3sZpOZ0kz Oi3rg5K3Jj5wB03eUvBmUIJ8/vXxdMtjf37JlmIjTsY9QvCIm8OGDbIXaQPu+BUQSlHjH0tRsqgZL FH2K7sOcOVSl8qx79SSqds2hpS+K6WT+8ojS25qzquvzfo2yGJG0oO6/i7RU8uKnz/lrO+HjrN76z FbIdSkNyY/G+wHjIG50uF/d4Yj7lEjZs6FiBww7q7cZnf26Afopz5cIy2krYoHsCOcxon3nSeVZ8U 02fO7PBYwYzcpz3R9eVDMJt7H73cKtAH3Lh+ne5l4GrojSutG6k8JKx3qN/fd9MGhYMKh9cEe6O5h fF6cOQfQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56966) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nEuCw-0000hf-Bi; Tue, 01 Feb 2022 14:32:34 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nEuCo-00028V-8b; Tue, 01 Feb 2022 14:32:26 +0000 Date: Tue, 1 Feb 2022 14:32:26 +0000 From: "Russell King (Oracle)" To: Marc Zyngier Subject: Re: [PATCH v6 07/64] KVM: arm64: nv: Handle HCR_EL2.NV system register traps Message-ID: References: <20220128121912.509006-1-maz@kernel.org> <20220128121912.509006-8-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220128121912.509006-8-maz@kernel.org> Cc: kernel-team@android.com, kvm@vger.kernel.org, Andre Przywara , Christoffer Dall , Chase Conklin , kvmarm@lists.cs.columbia.edu, mihai.carabas@oracle.com, Ganapatrao Kulkarni , linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Fri, Jan 28, 2022 at 12:18:15PM +0000, Marc Zyngier wrote: > From: Jintack Lim > > ARM v8.3 introduces a new bit in the HCR_EL2, which is the NV bit. When > this bit is set, accessing EL2 registers in EL1 traps to EL2. In > addition, executing the following instructions in EL1 will trap to EL2: > tlbi, at, eret, and msr/mrs instructions to access SP_EL1. Most of the > instructions that trap to EL2 with the NV bit were undef at EL1 prior to > ARM v8.3. The only instruction that was not undef is eret. > > This patch sets up a handler for EL2 registers and SP_EL1 register > accesses at EL1. The host hypervisor keeps those register values in > memory, and will emulate their behavior. > > This patch doesn't set the NV bit yet. It will be set in a later patch > once nested virtualization support is completed. > > Signed-off-by: Jintack Lim > [maz: EL2_REG() macros] > Signed-off-by: Marc Zyngier Reviewed-by: Russell King (Oracle) Thanks! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDEB8C433EF for ; Tue, 1 Feb 2022 14:34:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MXr7RoAkmW6HTIOKrnzGZsEQQjPhGccQgGGVB8U8qEY=; b=RqaRVuqvolZn31 Tubg4moeRm0fCwkSFl1OJW3xi9TREUPTpne8ZgTMJO/8fzmHgtRfIlGPmRr8HkDD1Ba+qyRv2i+7g zP7Zg58RbPHfg2bntMU0xDjjvJJmg9SyzqfaIvoGJLJOeDDEkophwIly47zYaS25nKhalR/FgNT2+ gq1Qus45vUAo42nSa/01EAhS9hbvXmwkxQttig+8CrCoJSMt2uto23V1JpsYKdKchQw3BFjjj/FSl XxXWgR/h62TQCYYqJ9JTXi23bGaSQTneraRONbyRkvCOmLYlb0T1DOPt6Q9rA7kJ8BEwDfE1E96I0 Yarmda9q1r1bSinlSjSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEuD6-00CSBm-9z; Tue, 01 Feb 2022 14:32:44 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEuD2-00CSB1-Id for linux-arm-kernel@lists.infradead.org; Tue, 01 Feb 2022 14:32:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=I18tNObjVFDm/kZz3nk5PXOupFozTlFQM8ZlXVFWPRs=; b=XrkHdF9USSifp4SbR3sZpOZ0kz Oi3rg5K3Jj5wB03eUvBmUIJ8/vXxdMtjf37JlmIjTsY9QvCIm8OGDbIXaQPu+BUQSlHjH0tRsqgZL FH2K7sOcOVSl8qx79SSqds2hpS+K6WT+8ojS25qzquvzfo2yGJG0oO6/i7RU8uKnz/lrO+HjrN76z FbIdSkNyY/G+wHjIG50uF/d4Yj7lEjZs6FiBww7q7cZnf26Afopz5cIy2krYoHsCOcxon3nSeVZ8U 02fO7PBYwYzcpz3R9eVDMJt7H73cKtAH3Lh+ne5l4GrojSutG6k8JKx3qN/fd9MGhYMKh9cEe6O5h fF6cOQfQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56966) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nEuCw-0000hf-Bi; Tue, 01 Feb 2022 14:32:34 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nEuCo-00028V-8b; Tue, 01 Feb 2022 14:32:26 +0000 Date: Tue, 1 Feb 2022 14:32:26 +0000 From: "Russell King (Oracle)" To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Andre Przywara , Christoffer Dall , Jintack Lim , Haibo Xu , Ganapatrao Kulkarni , Chase Conklin , James Morse , Suzuki K Poulose , Alexandru Elisei , karl.heubaum@oracle.com, mihai.carabas@oracle.com, miguel.luis@oracle.com, kernel-team@android.com Subject: Re: [PATCH v6 07/64] KVM: arm64: nv: Handle HCR_EL2.NV system register traps Message-ID: References: <20220128121912.509006-1-maz@kernel.org> <20220128121912.509006-8-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220128121912.509006-8-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220201_063240_648936_4D5F5943 X-CRM114-Status: GOOD ( 14.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 28, 2022 at 12:18:15PM +0000, Marc Zyngier wrote: > From: Jintack Lim > > ARM v8.3 introduces a new bit in the HCR_EL2, which is the NV bit. When > this bit is set, accessing EL2 registers in EL1 traps to EL2. In > addition, executing the following instructions in EL1 will trap to EL2: > tlbi, at, eret, and msr/mrs instructions to access SP_EL1. Most of the > instructions that trap to EL2 with the NV bit were undef at EL1 prior to > ARM v8.3. The only instruction that was not undef is eret. > > This patch sets up a handler for EL2 registers and SP_EL1 register > accesses at EL1. The host hypervisor keeps those register values in > memory, and will emulate their behavior. > > This patch doesn't set the NV bit yet. It will be set in a later patch > once nested virtualization support is completed. > > Signed-off-by: Jintack Lim > [maz: EL2_REG() macros] > Signed-off-by: Marc Zyngier Reviewed-by: Russell King (Oracle) Thanks! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel