All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Jean-Philippe Brucker <jean-philippe@linaro.org>
Cc: ndesaulniers@google.com, llvm@lists.linux.dev,
	bpf@vger.kernel.org, andrii@kernel.org, quentin@isovalent.com
Subject: Re: [PATCH] tools: Ignore errors from `which' when searching a GCC toolchain
Date: Tue, 1 Feb 2022 09:01:52 -0700	[thread overview]
Message-ID: <YflZcEjaPoN8G84c@dev-arch.archlinux-ax161> (raw)
In-Reply-To: <20220201093119.1713207-1-jean-philippe@linaro.org>

On Tue, Feb 01, 2022 at 09:31:20AM +0000, Jean-Philippe Brucker wrote:
> When cross-building tools with clang, we run `which $(CROSS_COMPILE)gcc`
> to detect whether a GCC toolchain provides the standard libraries. It is
> only a helper because some distros put libraries where LLVM does not
> automatically find them. On other systems, LLVM detects the libc
> automatically and does not need this. There, it is completely fine not
> to have a GCC at all, but some versions of `which' display an error when
> the command is not found:
> 
> 	which: no aarch64-linux-gnu-gcc in ($PATH)
> 
> Since the error can safely be ignored, throw it to /dev/null.
> 
> Fixes: cebdb7374577 ("tools: Help cross-building with clang")
> Reported-by: Nathan Chancellor <nathan@kernel.org>
> Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org>

Thanks a lot for the quick fix!

Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>

It would be nice if this could go in via bpf, as cebdb7374577 was merged
in 5.17-rc1.

> ---
>  tools/scripts/Makefile.include | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/scripts/Makefile.include b/tools/scripts/Makefile.include
> index b0be5f40a3f1..79d102304470 100644
> --- a/tools/scripts/Makefile.include
> +++ b/tools/scripts/Makefile.include
> @@ -90,7 +90,7 @@ EXTRA_WARNINGS += -Wstrict-aliasing=3
>  
>  else ifneq ($(CROSS_COMPILE),)
>  CLANG_CROSS_FLAGS := --target=$(notdir $(CROSS_COMPILE:%-=%))
> -GCC_TOOLCHAIN_DIR := $(dir $(shell which $(CROSS_COMPILE)gcc))
> +GCC_TOOLCHAIN_DIR := $(dir $(shell which $(CROSS_COMPILE)gcc 2>/dev/null))
>  ifneq ($(GCC_TOOLCHAIN_DIR),)
>  CLANG_CROSS_FLAGS += --prefix=$(GCC_TOOLCHAIN_DIR)$(notdir $(CROSS_COMPILE))
>  CLANG_CROSS_FLAGS += --sysroot=$(shell $(CROSS_COMPILE)gcc -print-sysroot)
> -- 
> 2.34.1
> 
> 

  reply	other threads:[~2022-02-01 16:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-01  9:31 [PATCH] tools: Ignore errors from `which' when searching a GCC toolchain Jean-Philippe Brucker
2022-02-01 16:01 ` Nathan Chancellor [this message]
2022-02-01 22:10 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YflZcEjaPoN8G84c@dev-arch.archlinux-ax161 \
    --to=nathan@kernel.org \
    --cc=andrii@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=jean-philippe@linaro.org \
    --cc=llvm@lists.linux.dev \
    --cc=ndesaulniers@google.com \
    --cc=quentin@isovalent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.