From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A24DDC433EF for ; Tue, 1 Feb 2022 16:52:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241247AbiBAQwA (ORCPT ); Tue, 1 Feb 2022 11:52:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235246AbiBAQv7 (ORCPT ); Tue, 1 Feb 2022 11:51:59 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB3ABC061714 for ; Tue, 1 Feb 2022 08:51:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=4RYLbPYhwvz3vodCfFsOAXqcVYhkJQJgonJ0Dgy6/18=; b=qOKwGJKjRULYfRSB8qLlAl6/Sw hp8JAMx372ifqhLcNsJaRart9AJw8OM1b2dVTSjxOHh6fPlYNrDoipHQDvlHLr5fIgj8yLl7FCWWw 8vJyEdFvTqF6T+7mrDhvJxkwiGLXDvGTG9G2l8cjdcxmN+DFFQ/bsKdtDHKNYZMuCcAftv5ZGYl6b IPA1LQf+Crr2qlgz1UkHsqjK6Dr57BOoeeoZV5cUbAW2SXvwv5jvB/0ufj03HkwZ+9RsVOKMC6u/I HSIkTTuQmhNPt16ZDWyD6XNV/qC2LbzlMmCVT/bUlPXuB5iwR5WjGgIA5GYbUtqz9jrPSTc8JvPhG CXdahTxw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56974) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nEwNm-0000ps-43; Tue, 01 Feb 2022 16:51:54 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nEwNj-0002EH-LT; Tue, 01 Feb 2022 16:51:51 +0000 Date: Tue, 1 Feb 2022 16:51:51 +0000 From: "Russell King (Oracle)" To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Andre Przywara , Christoffer Dall , Jintack Lim , Haibo Xu , Ganapatrao Kulkarni , Chase Conklin , James Morse , Suzuki K Poulose , Alexandru Elisei , karl.heubaum@oracle.com, mihai.carabas@oracle.com, miguel.luis@oracle.com, kernel-team@android.com Subject: Re: [PATCH v6 15/64] KVM: arm64: nv: Handle HCR_EL2.E2H specially Message-ID: References: <20220128121912.509006-1-maz@kernel.org> <20220128121912.509006-16-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220128121912.509006-16-maz@kernel.org> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, Jan 28, 2022 at 12:18:23PM +0000, Marc Zyngier wrote: > HCR_EL2.E2H is nasty, as a flip of this bit completely changes the way > we deal with a lot of the state. So when the guest flips this bit > (sysregs are live), do the put/load dance so that we have a consistent > state. > > Yes, this is slow. Don't do it. I'd hope this is very unlikely! > > Suggested-by: Alexandru Elisei > Signed-off-by: Marc Zyngier Reviewed-by: Russell King (Oracle) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B685C433F5 for ; Tue, 1 Feb 2022 16:52:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 907AC49F13; Tue, 1 Feb 2022 11:52:01 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@armlinux.org.uk Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Gym914q3Ty+m; Tue, 1 Feb 2022 11:51:59 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id DF97D49F1B; Tue, 1 Feb 2022 11:51:59 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id D641F49F18 for ; Tue, 1 Feb 2022 11:51:58 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0Xzan0t2sVLB for ; Tue, 1 Feb 2022 11:51:57 -0500 (EST) Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 38C2749F13 for ; Tue, 1 Feb 2022 11:51:57 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=4RYLbPYhwvz3vodCfFsOAXqcVYhkJQJgonJ0Dgy6/18=; b=qOKwGJKjRULYfRSB8qLlAl6/Sw hp8JAMx372ifqhLcNsJaRart9AJw8OM1b2dVTSjxOHh6fPlYNrDoipHQDvlHLr5fIgj8yLl7FCWWw 8vJyEdFvTqF6T+7mrDhvJxkwiGLXDvGTG9G2l8cjdcxmN+DFFQ/bsKdtDHKNYZMuCcAftv5ZGYl6b IPA1LQf+Crr2qlgz1UkHsqjK6Dr57BOoeeoZV5cUbAW2SXvwv5jvB/0ufj03HkwZ+9RsVOKMC6u/I HSIkTTuQmhNPt16ZDWyD6XNV/qC2LbzlMmCVT/bUlPXuB5iwR5WjGgIA5GYbUtqz9jrPSTc8JvPhG CXdahTxw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56974) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nEwNm-0000ps-43; Tue, 01 Feb 2022 16:51:54 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nEwNj-0002EH-LT; Tue, 01 Feb 2022 16:51:51 +0000 Date: Tue, 1 Feb 2022 16:51:51 +0000 From: "Russell King (Oracle)" To: Marc Zyngier Subject: Re: [PATCH v6 15/64] KVM: arm64: nv: Handle HCR_EL2.E2H specially Message-ID: References: <20220128121912.509006-1-maz@kernel.org> <20220128121912.509006-16-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220128121912.509006-16-maz@kernel.org> Cc: kernel-team@android.com, kvm@vger.kernel.org, Andre Przywara , Christoffer Dall , Chase Conklin , kvmarm@lists.cs.columbia.edu, mihai.carabas@oracle.com, Ganapatrao Kulkarni , linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Fri, Jan 28, 2022 at 12:18:23PM +0000, Marc Zyngier wrote: > HCR_EL2.E2H is nasty, as a flip of this bit completely changes the way > we deal with a lot of the state. So when the guest flips this bit > (sysregs are live), do the put/load dance so that we have a consistent > state. > > Yes, this is slow. Don't do it. I'd hope this is very unlikely! > > Suggested-by: Alexandru Elisei > Signed-off-by: Marc Zyngier Reviewed-by: Russell King (Oracle) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74207C433FE for ; Tue, 1 Feb 2022 16:53:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RFxZVs0hSLbaSaTc0jbyW0xWztcfvSSqZG33ILJwSJU=; b=xfwfYLsqOncY3t XXeJQiUox+FYHCNqmf8gZ3vsUT++6Kbs83SzBagpF3RzM5tlab/MrEvXLxHLCeaBp/4fnnYxNQFbx vXr7cOS0Xsvgpbew2sWOiCDCQ3gGCz3R0ozNrNgCa414LCAx9YGDgQJXSUoOwr0e/Nr65DNWWd6Cq BvXgLz6HUnySZaqHxK73t3HIWlM001NOdx5JsJjqSZ5/KWCwPwL4KFLl6AXHKIIjR01guTMaE/nYg JWV43BGIPgfisfJqVNjdVf7oiiRgb9v69NF7I710t1jU5SFhbleaez07nSLsCKi/KLAXnqh2pkZKM 3NiY17PxfxVBBh0rFsXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEwNs-00D2jC-LY; Tue, 01 Feb 2022 16:52:00 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEwNp-00D2hi-IG for linux-arm-kernel@lists.infradead.org; Tue, 01 Feb 2022 16:51:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=4RYLbPYhwvz3vodCfFsOAXqcVYhkJQJgonJ0Dgy6/18=; b=qOKwGJKjRULYfRSB8qLlAl6/Sw hp8JAMx372ifqhLcNsJaRart9AJw8OM1b2dVTSjxOHh6fPlYNrDoipHQDvlHLr5fIgj8yLl7FCWWw 8vJyEdFvTqF6T+7mrDhvJxkwiGLXDvGTG9G2l8cjdcxmN+DFFQ/bsKdtDHKNYZMuCcAftv5ZGYl6b IPA1LQf+Crr2qlgz1UkHsqjK6Dr57BOoeeoZV5cUbAW2SXvwv5jvB/0ufj03HkwZ+9RsVOKMC6u/I HSIkTTuQmhNPt16ZDWyD6XNV/qC2LbzlMmCVT/bUlPXuB5iwR5WjGgIA5GYbUtqz9jrPSTc8JvPhG CXdahTxw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:56974) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nEwNm-0000ps-43; Tue, 01 Feb 2022 16:51:54 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1nEwNj-0002EH-LT; Tue, 01 Feb 2022 16:51:51 +0000 Date: Tue, 1 Feb 2022 16:51:51 +0000 From: "Russell King (Oracle)" To: Marc Zyngier Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Andre Przywara , Christoffer Dall , Jintack Lim , Haibo Xu , Ganapatrao Kulkarni , Chase Conklin , James Morse , Suzuki K Poulose , Alexandru Elisei , karl.heubaum@oracle.com, mihai.carabas@oracle.com, miguel.luis@oracle.com, kernel-team@android.com Subject: Re: [PATCH v6 15/64] KVM: arm64: nv: Handle HCR_EL2.E2H specially Message-ID: References: <20220128121912.509006-1-maz@kernel.org> <20220128121912.509006-16-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220128121912.509006-16-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220201_085157_628178_3DAE81A0 X-CRM114-Status: GOOD ( 10.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 28, 2022 at 12:18:23PM +0000, Marc Zyngier wrote: > HCR_EL2.E2H is nasty, as a flip of this bit completely changes the way > we deal with a lot of the state. So when the guest flips this bit > (sysregs are live), do the put/load dance so that we have a consistent > state. > > Yes, this is slow. Don't do it. I'd hope this is very unlikely! > > Suggested-by: Alexandru Elisei > Signed-off-by: Marc Zyngier Reviewed-by: Russell King (Oracle) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel