From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC722C433F5 for ; Tue, 1 Feb 2022 17:22:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241456AbiBARWg (ORCPT ); Tue, 1 Feb 2022 12:22:36 -0500 Received: from mail-ot1-f45.google.com ([209.85.210.45]:34753 "EHLO mail-ot1-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229836AbiBARWf (ORCPT ); Tue, 1 Feb 2022 12:22:35 -0500 Received: by mail-ot1-f45.google.com with SMTP id b17-20020a9d4791000000b005a17fc2dfc1so16910791otf.1 for ; Tue, 01 Feb 2022 09:22:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZXG/HpK5iimHhno4a4gmqcNT8xzbRL3eWb4JTlbIiWA=; b=ZoHwGcH1wy6csoo5xk7bj+kb9VIJJGT7Vnsqlp7RXMuDARrebULMali19TuLNDDPrn ant/fL//4d47lnxkBHP+v2dZR/rFHQ9sZ3xnC/wRwPWorkdi7uD8Ko/blbQoLxL02r2v jwQxhgB1US4EVBVKULDeJ3bkoGL3nL/oYwQEJhhE62PSix68LSVxylmh+vQeqZomNBuO faBMCxM+ol160s8b4EnHwhuV7vwwMjEq7SuI9pO2p8mpQyIIBXXX+dyxgJ1Z2AfnyBXz K/YaHx4qZ/0RfBJwjUeOGLeWcUT4T0aiEqDG7ALQD4n0coEceojAY88JL07IhGAmrzqy Aiuw== X-Gm-Message-State: AOAM5335t2MpWuhqUh5W1ja2CrzGS1tUHQlFm4xfZIRCQp96aLUv7hxp boq+ncLVOboZyx95DYbDsQ== X-Google-Smtp-Source: ABdhPJyUvXkJDpPdLDNVyZW0OTXgSkoXrPNkaXMM14hMv3h2yJGcl0URslitlIeJWL8iqgqI2BIobg== X-Received: by 2002:a05:6830:1e11:: with SMTP id s17mr14458124otr.347.1643736155108; Tue, 01 Feb 2022 09:22:35 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id s64sm13024778oos.0.2022.02.01.09.22.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Feb 2022 09:22:34 -0800 (PST) Received: (nullmailer pid 235445 invoked by uid 1000); Tue, 01 Feb 2022 17:22:33 -0000 Date: Tue, 1 Feb 2022 11:22:33 -0600 From: Rob Herring To: Sascha Hauer Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , Heiko =?iso-8859-1?Q?St=FCbner?= , Peter Geis Subject: Re: [PATCH 17/27] dt-bindings: display: rockchip: Add binding for VOP2 Message-ID: References: <20220126145549.617165-1-s.hauer@pengutronix.de> <20220126145549.617165-18-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220126145549.617165-18-s.hauer@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Jan 26, 2022 at 03:55:39PM +0100, Sascha Hauer wrote: > The VOP2 is found on newer Rockchip SoCs like the rk3568 or the rk3566. > The binding differs slightly from the existing VOP binding, so add a new > binding file for it. > > Changes since v3: > - drop redundant _vop suffix from clock names > > Signed-off-by: Sascha Hauer > --- > .../display/rockchip/rockchip-vop2.yaml | 146 ++++++++++++++++++ > 1 file changed, 146 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > new file mode 100644 > index 000000000000..572cfb307c20 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > @@ -0,0 +1,146 @@ > +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/rockchip/rockchip-vop2.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip SoC display controller (VOP2) > + > +description: > + VOP2 (Video Output Processor v2) is the display controller for the Rockchip > + series of SoCs which transfers the image data from a video memory > + buffer to an external LCD interface. > + > +maintainers: > + - Sandy Huang > + - Heiko Stuebner > + > +properties: > + compatible: > + enum: > + - rockchip,rk3566-vop > + - rockchip,rk3568-vop > + > + reg: > + minItems: 1 > + items: > + - description: > + Must contain one entry corresponding to the base address and length > + of the register space. > + - description: > + Can optionally contain a second entry corresponding to > + the CRTC gamma LUT address. > + > + interrupts: > + maxItems: 1 > + description: > + The VOP interrupt is shared by several interrupt sources, such as > + frame start (VSYNC), line flag and other status interrupts. > + > + clocks: > + items: > + - description: Clock for ddr buffer transfer. > + - description: Clock for the ahb bus to R/W the phy regs. > + - description: Pixel clock for video port 0. > + - description: Pixel clock for video port 1. > + - description: Pixel clock for video port 2. > + > + clock-names: > + items: > + - const: aclk > + - const: hclk > + - const: dclk_vp0 > + - const: dclk_vp1 > + - const: dclk_vp2 > + > + rockchip,grf: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Phandle to GRF regs used for misc control > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Output endpoint of VP0 > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Output endpoint of VP1 > + > + port@2: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Output endpoint of VP2 > + > + assigned-clocks: true > + > + assigned-clock-rates: true > + > + assigned-clock-parents: true You can drop these. They are implicitly allowed with 'clocks'. > + > + iommus: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + bus { > + #address-cells = <2>; > + #size-cells = <2>; > + vop: vop@fe040000 { > + compatible = "rockchip,rk3568-vop"; > + reg = <0x0 0xfe040000 0x0 0x3000>, <0x0 0xfe044000 0x0 0x1000>; > + interrupts = ; > + clocks = <&cru ACLK_VOP>, > + <&cru HCLK_VOP>, > + <&cru DCLK_VOP0>, > + <&cru DCLK_VOP1>, > + <&cru DCLK_VOP2>; > + clock-names = "aclk_vop", > + "hclk_vop", > + "dclk_vp0", > + "dclk_vp1", > + "dclk_vp2"; > + power-domains = <&power RK3568_PD_VO>; > + iommus = <&vop_mmu>; > + vop_out: ports { > + #address-cells = <1>; > + #size-cells = <0>; > + vp0: port@0 { > + reg = <0>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + vp1: port@1 { > + reg = <1>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + vp2: port@2 { > + reg = <2>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + }; > + }; > + }; > -- > 2.30.2 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE3AFC433F5 for ; Tue, 1 Feb 2022 17:24:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VwXqQBC6BoyK571UOHmojRYiuU2woDWLvIwpXwU6ePg=; b=BPHd52wfW9wZX3 eWHZ3UeFX1x+sQSB4Mx/hgU7fDRPibKFYqir3MILHdx4YU5OByao631nFgJC0Wn9T3eqOU0rRKZKO M4T1x2lzGVxC1jNO6SFpmpKm+zqInkuyYYa9gEdcJS148w/iyLR/FLCDzBjzyrmqKFyBUkVbZ7q8L ybCWLvd1F3R5zF52grDlneeejIfnGl/YAUDVluk/J0xuoBzS2EUcg0mcOsCk3/Ivnpf/aOu/g0DFX g5KEaHOzgFQIFSKHR7dOazKbnKNKtUQerwmIrz/aA5ToAT01JJAiBt7A9rS38OgTIHMxCanL7cH9X LKreH2Z/xgOLOwtO5QPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEwsm-00DA2N-Vd; Tue, 01 Feb 2022 17:23:57 +0000 Received: from mail-ot1-f48.google.com ([209.85.210.48]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEwrW-00D9Uw-9U; Tue, 01 Feb 2022 17:22:40 +0000 Received: by mail-ot1-f48.google.com with SMTP id j38-20020a9d1926000000b0059fa6de6c71so16871278ota.10; Tue, 01 Feb 2022 09:22:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZXG/HpK5iimHhno4a4gmqcNT8xzbRL3eWb4JTlbIiWA=; b=CQUc6FgeUbFUA6Gt0hjkDVyftMtG+KAaBPlF/k6vAuZwWqztFo66Q0kQnljQ222VMK qYimF+DmHxD42Mc7loV3J0qi/z/zfasFIALvn47JHU4C8AxXlcXDbJcRZzqhShiQKvWa 7ObbfjtGa98+Lss7NIxaQUl4xROAEDWcHIM0SxQgECiZDo9OJoz4kegb+8pNDrRplRM8 zdCNh+Vtsljs8B78uj7RAwBCvfPgZz0sIZ5hgqvCFTancTq3Ro8hDCouXGFs1zhc4oGf aUti2pm2q3JHUmfhp52hJYXMq1vGcUcoxWxMta5rI+yQ3AHG77F8sHBr6XblXIeoFQH8 1O1w== X-Gm-Message-State: AOAM531JcSGCDXu0jswWPRBrteiUsVFtAUiZkho71F7/0EZg7QCkh3M2 JwLXmG20AKFBTNHCvXjX0YceUJqe1g== X-Google-Smtp-Source: ABdhPJyUvXkJDpPdLDNVyZW0OTXgSkoXrPNkaXMM14hMv3h2yJGcl0URslitlIeJWL8iqgqI2BIobg== X-Received: by 2002:a05:6830:1e11:: with SMTP id s17mr14458124otr.347.1643736155108; Tue, 01 Feb 2022 09:22:35 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id s64sm13024778oos.0.2022.02.01.09.22.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Feb 2022 09:22:34 -0800 (PST) Received: (nullmailer pid 235445 invoked by uid 1000); Tue, 01 Feb 2022 17:22:33 -0000 Date: Tue, 1 Feb 2022 11:22:33 -0600 From: Rob Herring To: Sascha Hauer Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , Heiko =?iso-8859-1?Q?St=FCbner?= , Peter Geis Subject: Re: [PATCH 17/27] dt-bindings: display: rockchip: Add binding for VOP2 Message-ID: References: <20220126145549.617165-1-s.hauer@pengutronix.de> <20220126145549.617165-18-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220126145549.617165-18-s.hauer@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220201_092238_382854_5469D771 X-CRM114-Status: GOOD ( 24.69 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Wed, Jan 26, 2022 at 03:55:39PM +0100, Sascha Hauer wrote: > The VOP2 is found on newer Rockchip SoCs like the rk3568 or the rk3566. > The binding differs slightly from the existing VOP binding, so add a new > binding file for it. > > Changes since v3: > - drop redundant _vop suffix from clock names > > Signed-off-by: Sascha Hauer > --- > .../display/rockchip/rockchip-vop2.yaml | 146 ++++++++++++++++++ > 1 file changed, 146 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > new file mode 100644 > index 000000000000..572cfb307c20 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > @@ -0,0 +1,146 @@ > +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/rockchip/rockchip-vop2.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip SoC display controller (VOP2) > + > +description: > + VOP2 (Video Output Processor v2) is the display controller for the Rockchip > + series of SoCs which transfers the image data from a video memory > + buffer to an external LCD interface. > + > +maintainers: > + - Sandy Huang > + - Heiko Stuebner > + > +properties: > + compatible: > + enum: > + - rockchip,rk3566-vop > + - rockchip,rk3568-vop > + > + reg: > + minItems: 1 > + items: > + - description: > + Must contain one entry corresponding to the base address and length > + of the register space. > + - description: > + Can optionally contain a second entry corresponding to > + the CRTC gamma LUT address. > + > + interrupts: > + maxItems: 1 > + description: > + The VOP interrupt is shared by several interrupt sources, such as > + frame start (VSYNC), line flag and other status interrupts. > + > + clocks: > + items: > + - description: Clock for ddr buffer transfer. > + - description: Clock for the ahb bus to R/W the phy regs. > + - description: Pixel clock for video port 0. > + - description: Pixel clock for video port 1. > + - description: Pixel clock for video port 2. > + > + clock-names: > + items: > + - const: aclk > + - const: hclk > + - const: dclk_vp0 > + - const: dclk_vp1 > + - const: dclk_vp2 > + > + rockchip,grf: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Phandle to GRF regs used for misc control > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Output endpoint of VP0 > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Output endpoint of VP1 > + > + port@2: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Output endpoint of VP2 > + > + assigned-clocks: true > + > + assigned-clock-rates: true > + > + assigned-clock-parents: true You can drop these. They are implicitly allowed with 'clocks'. > + > + iommus: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + bus { > + #address-cells = <2>; > + #size-cells = <2>; > + vop: vop@fe040000 { > + compatible = "rockchip,rk3568-vop"; > + reg = <0x0 0xfe040000 0x0 0x3000>, <0x0 0xfe044000 0x0 0x1000>; > + interrupts = ; > + clocks = <&cru ACLK_VOP>, > + <&cru HCLK_VOP>, > + <&cru DCLK_VOP0>, > + <&cru DCLK_VOP1>, > + <&cru DCLK_VOP2>; > + clock-names = "aclk_vop", > + "hclk_vop", > + "dclk_vp0", > + "dclk_vp1", > + "dclk_vp2"; > + power-domains = <&power RK3568_PD_VO>; > + iommus = <&vop_mmu>; > + vop_out: ports { > + #address-cells = <1>; > + #size-cells = <0>; > + vp0: port@0 { > + reg = <0>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + vp1: port@1 { > + reg = <1>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + vp2: port@2 { > + reg = <2>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + }; > + }; > + }; > -- > 2.30.2 > > _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA8ECC433FE for ; Tue, 1 Feb 2022 17:24:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NqrnMcfi2rSyW54JaD2lnmln0uTVAlVakPgjfKlOL9E=; b=k13wS7j+CoXzNf xy8/r/ZAZGvlbK45W5kNXKOXclA4iqyQ3qxUVovv2OYgiFBKSP6jHEv0AkvWCA8n9UX0P6U+uKzzg I+PIhE+WYlhVIVxsYCu2H92EyOe9Tq51mACeH6zu+aWaTQ7a9jPme7rQ8PO97dBVrNlQm0n5+xEt6 7Foiqp5zkjIsV5qXTwPATuF3/VoXUxGeDiD4tSJ6Or2qSeLwxB66iJ8f3VztYcFJPjnodrd3JUYtY MGMwoPxL/nHqQJNq8FXJ3nt8oLQZmx8VqnL0csi6jPfRJ3C+kGLsOKfMMm+MKqyt/L08v9tXBg5n9 fjEcxlloY8ybEGCHr8Dg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEws4-00D9it-GQ; Tue, 01 Feb 2022 17:23:13 +0000 Received: from mail-ot1-f48.google.com ([209.85.210.48]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nEwrW-00D9Uw-9U; Tue, 01 Feb 2022 17:22:40 +0000 Received: by mail-ot1-f48.google.com with SMTP id j38-20020a9d1926000000b0059fa6de6c71so16871278ota.10; Tue, 01 Feb 2022 09:22:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZXG/HpK5iimHhno4a4gmqcNT8xzbRL3eWb4JTlbIiWA=; b=CQUc6FgeUbFUA6Gt0hjkDVyftMtG+KAaBPlF/k6vAuZwWqztFo66Q0kQnljQ222VMK qYimF+DmHxD42Mc7loV3J0qi/z/zfasFIALvn47JHU4C8AxXlcXDbJcRZzqhShiQKvWa 7ObbfjtGa98+Lss7NIxaQUl4xROAEDWcHIM0SxQgECiZDo9OJoz4kegb+8pNDrRplRM8 zdCNh+Vtsljs8B78uj7RAwBCvfPgZz0sIZ5hgqvCFTancTq3Ro8hDCouXGFs1zhc4oGf aUti2pm2q3JHUmfhp52hJYXMq1vGcUcoxWxMta5rI+yQ3AHG77F8sHBr6XblXIeoFQH8 1O1w== X-Gm-Message-State: AOAM531JcSGCDXu0jswWPRBrteiUsVFtAUiZkho71F7/0EZg7QCkh3M2 JwLXmG20AKFBTNHCvXjX0YceUJqe1g== X-Google-Smtp-Source: ABdhPJyUvXkJDpPdLDNVyZW0OTXgSkoXrPNkaXMM14hMv3h2yJGcl0URslitlIeJWL8iqgqI2BIobg== X-Received: by 2002:a05:6830:1e11:: with SMTP id s17mr14458124otr.347.1643736155108; Tue, 01 Feb 2022 09:22:35 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id s64sm13024778oos.0.2022.02.01.09.22.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Feb 2022 09:22:34 -0800 (PST) Received: (nullmailer pid 235445 invoked by uid 1000); Tue, 01 Feb 2022 17:22:33 -0000 Date: Tue, 1 Feb 2022 11:22:33 -0600 From: Rob Herring To: Sascha Hauer Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Andy Yan , Benjamin Gaignard , Michael Riesch , Sandy Huang , Heiko =?iso-8859-1?Q?St=FCbner?= , Peter Geis Subject: Re: [PATCH 17/27] dt-bindings: display: rockchip: Add binding for VOP2 Message-ID: References: <20220126145549.617165-1-s.hauer@pengutronix.de> <20220126145549.617165-18-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220126145549.617165-18-s.hauer@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220201_092238_382854_5469D771 X-CRM114-Status: GOOD ( 24.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 26, 2022 at 03:55:39PM +0100, Sascha Hauer wrote: > The VOP2 is found on newer Rockchip SoCs like the rk3568 or the rk3566. > The binding differs slightly from the existing VOP binding, so add a new > binding file for it. > > Changes since v3: > - drop redundant _vop suffix from clock names > > Signed-off-by: Sascha Hauer > --- > .../display/rockchip/rockchip-vop2.yaml | 146 ++++++++++++++++++ > 1 file changed, 146 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > new file mode 100644 > index 000000000000..572cfb307c20 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > @@ -0,0 +1,146 @@ > +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/rockchip/rockchip-vop2.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip SoC display controller (VOP2) > + > +description: > + VOP2 (Video Output Processor v2) is the display controller for the Rockchip > + series of SoCs which transfers the image data from a video memory > + buffer to an external LCD interface. > + > +maintainers: > + - Sandy Huang > + - Heiko Stuebner > + > +properties: > + compatible: > + enum: > + - rockchip,rk3566-vop > + - rockchip,rk3568-vop > + > + reg: > + minItems: 1 > + items: > + - description: > + Must contain one entry corresponding to the base address and length > + of the register space. > + - description: > + Can optionally contain a second entry corresponding to > + the CRTC gamma LUT address. > + > + interrupts: > + maxItems: 1 > + description: > + The VOP interrupt is shared by several interrupt sources, such as > + frame start (VSYNC), line flag and other status interrupts. > + > + clocks: > + items: > + - description: Clock for ddr buffer transfer. > + - description: Clock for the ahb bus to R/W the phy regs. > + - description: Pixel clock for video port 0. > + - description: Pixel clock for video port 1. > + - description: Pixel clock for video port 2. > + > + clock-names: > + items: > + - const: aclk > + - const: hclk > + - const: dclk_vp0 > + - const: dclk_vp1 > + - const: dclk_vp2 > + > + rockchip,grf: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Phandle to GRF regs used for misc control > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Output endpoint of VP0 > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Output endpoint of VP1 > + > + port@2: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Output endpoint of VP2 > + > + assigned-clocks: true > + > + assigned-clock-rates: true > + > + assigned-clock-parents: true You can drop these. They are implicitly allowed with 'clocks'. > + > + iommus: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + bus { > + #address-cells = <2>; > + #size-cells = <2>; > + vop: vop@fe040000 { > + compatible = "rockchip,rk3568-vop"; > + reg = <0x0 0xfe040000 0x0 0x3000>, <0x0 0xfe044000 0x0 0x1000>; > + interrupts = ; > + clocks = <&cru ACLK_VOP>, > + <&cru HCLK_VOP>, > + <&cru DCLK_VOP0>, > + <&cru DCLK_VOP1>, > + <&cru DCLK_VOP2>; > + clock-names = "aclk_vop", > + "hclk_vop", > + "dclk_vp0", > + "dclk_vp1", > + "dclk_vp2"; > + power-domains = <&power RK3568_PD_VO>; > + iommus = <&vop_mmu>; > + vop_out: ports { > + #address-cells = <1>; > + #size-cells = <0>; > + vp0: port@0 { > + reg = <0>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + vp1: port@1 { > + reg = <1>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + vp2: port@2 { > + reg = <2>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + }; > + }; > + }; > -- > 2.30.2 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9D65C433FE for ; Tue, 1 Feb 2022 17:22:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0693D10E6FB; Tue, 1 Feb 2022 17:22:38 +0000 (UTC) Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) by gabe.freedesktop.org (Postfix) with ESMTPS id EDFFF10E6FB for ; Tue, 1 Feb 2022 17:22:35 +0000 (UTC) Received: by mail-ot1-f46.google.com with SMTP id d18-20020a9d51d2000000b005a09728a8c2so16880747oth.3 for ; Tue, 01 Feb 2022 09:22:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZXG/HpK5iimHhno4a4gmqcNT8xzbRL3eWb4JTlbIiWA=; b=FnW/As7IbABYc35JnBKGII7m3Uynmn+weBuc24ikrvyWf4+wn94zE/cIWM+Gjqh4nd P51MnH0cir8ns0yroVOTeVzM8iobTeMzF/jzLyzKNFfZH9VoZnyjBhVvvagHPP7WaTvV P/CWSEOFsa/znLNL6GmXHVlqLH6t5yKdlGkr1TLEO3N6DiYN/6w+7I9WwacTVHA0nSpR fMnR5OJj97Qs4EuBRuSnJYoKn09pkw6HRTTvKuoZ5MPQLAw2hxn2N7Z3vHswOJhgry/z J8WF1D4Y6SxbqCMFI912BdLNeVFiVO0OItmLXQEKfy3LTh4aqPGOb2iWXeAmy5t8/6rB gONw== X-Gm-Message-State: AOAM530pvbjNjlTp5O/u+oABWRiZ3meFAaZ3aHmsEJKEnpklF0eIlgDj 0JTKme+Sa1HS+/ZMpYssSQ== X-Google-Smtp-Source: ABdhPJyUvXkJDpPdLDNVyZW0OTXgSkoXrPNkaXMM14hMv3h2yJGcl0URslitlIeJWL8iqgqI2BIobg== X-Received: by 2002:a05:6830:1e11:: with SMTP id s17mr14458124otr.347.1643736155108; Tue, 01 Feb 2022 09:22:35 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id s64sm13024778oos.0.2022.02.01.09.22.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Feb 2022 09:22:34 -0800 (PST) Received: (nullmailer pid 235445 invoked by uid 1000); Tue, 01 Feb 2022 17:22:33 -0000 Date: Tue, 1 Feb 2022 11:22:33 -0600 From: Rob Herring To: Sascha Hauer Subject: Re: [PATCH 17/27] dt-bindings: display: rockchip: Add binding for VOP2 Message-ID: References: <20220126145549.617165-1-s.hauer@pengutronix.de> <20220126145549.617165-18-s.hauer@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220126145549.617165-18-s.hauer@pengutronix.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Benjamin Gaignard , Peter Geis , Sandy Huang , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, Andy Yan , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Jan 26, 2022 at 03:55:39PM +0100, Sascha Hauer wrote: > The VOP2 is found on newer Rockchip SoCs like the rk3568 or the rk3566. > The binding differs slightly from the existing VOP binding, so add a new > binding file for it. > > Changes since v3: > - drop redundant _vop suffix from clock names > > Signed-off-by: Sascha Hauer > --- > .../display/rockchip/rockchip-vop2.yaml | 146 ++++++++++++++++++ > 1 file changed, 146 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > > diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > new file mode 100644 > index 000000000000..572cfb307c20 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop2.yaml > @@ -0,0 +1,146 @@ > +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/rockchip/rockchip-vop2.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip SoC display controller (VOP2) > + > +description: > + VOP2 (Video Output Processor v2) is the display controller for the Rockchip > + series of SoCs which transfers the image data from a video memory > + buffer to an external LCD interface. > + > +maintainers: > + - Sandy Huang > + - Heiko Stuebner > + > +properties: > + compatible: > + enum: > + - rockchip,rk3566-vop > + - rockchip,rk3568-vop > + > + reg: > + minItems: 1 > + items: > + - description: > + Must contain one entry corresponding to the base address and length > + of the register space. > + - description: > + Can optionally contain a second entry corresponding to > + the CRTC gamma LUT address. > + > + interrupts: > + maxItems: 1 > + description: > + The VOP interrupt is shared by several interrupt sources, such as > + frame start (VSYNC), line flag and other status interrupts. > + > + clocks: > + items: > + - description: Clock for ddr buffer transfer. > + - description: Clock for the ahb bus to R/W the phy regs. > + - description: Pixel clock for video port 0. > + - description: Pixel clock for video port 1. > + - description: Pixel clock for video port 2. > + > + clock-names: > + items: > + - const: aclk > + - const: hclk > + - const: dclk_vp0 > + - const: dclk_vp1 > + - const: dclk_vp2 > + > + rockchip,grf: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Phandle to GRF regs used for misc control > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Output endpoint of VP0 > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Output endpoint of VP1 > + > + port@2: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Output endpoint of VP2 > + > + assigned-clocks: true > + > + assigned-clock-rates: true > + > + assigned-clock-parents: true You can drop these. They are implicitly allowed with 'clocks'. > + > + iommus: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + bus { > + #address-cells = <2>; > + #size-cells = <2>; > + vop: vop@fe040000 { > + compatible = "rockchip,rk3568-vop"; > + reg = <0x0 0xfe040000 0x0 0x3000>, <0x0 0xfe044000 0x0 0x1000>; > + interrupts = ; > + clocks = <&cru ACLK_VOP>, > + <&cru HCLK_VOP>, > + <&cru DCLK_VOP0>, > + <&cru DCLK_VOP1>, > + <&cru DCLK_VOP2>; > + clock-names = "aclk_vop", > + "hclk_vop", > + "dclk_vp0", > + "dclk_vp1", > + "dclk_vp2"; > + power-domains = <&power RK3568_PD_VO>; > + iommus = <&vop_mmu>; > + vop_out: ports { > + #address-cells = <1>; > + #size-cells = <0>; > + vp0: port@0 { > + reg = <0>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + vp1: port@1 { > + reg = <1>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + vp2: port@2 { > + reg = <2>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > + }; > + }; > + }; > -- > 2.30.2 > >