From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B37BBC433F5 for ; Tue, 1 Feb 2022 17:53:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233440AbiBARxn (ORCPT ); Tue, 1 Feb 2022 12:53:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230439AbiBARxm (ORCPT ); Tue, 1 Feb 2022 12:53:42 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69145C061714 for ; Tue, 1 Feb 2022 09:53:42 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id DCE9BCE1A59 for ; Tue, 1 Feb 2022 17:53:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39E52C340EB; Tue, 1 Feb 2022 17:53:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643738019; bh=NGS5ouwpQgNcB4ZZf3Yt7F53HpAPg/xrqWx6slbV+KU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uDXbK0k9825XqM1P9Pv1wQhadKP6SGc7YGEcA2zOOpbpGf6Dnrz9sboG1PqmkOSiZ BW61ybNoOTtOpNrcev25U/pRgP+Q5PFNxs0u12wfN/W6atBpolaEHqC11IR0r4rJ4L 1YIdv05VS0TnUrDectphk4ekH7y56LsnuoqJphZRp9LA66pIpVOhGAKixrRHk5RRQa xdSXwOM6Ason3iuKRm6IMly/yN1uD8jbKl8Vl9hsuQ4/5U2eoxmajnfZp6XAuti0Mg QERJ8oliVgsRS/OsjDaaaWhQ2tHPXt6fA13wU4JVOAH8nIZxkYO6UzCjUlsyoCyBg5 fiKRqVz4WPu6w== Date: Tue, 1 Feb 2022 09:53:37 -0800 From: Eric Biggers To: Chao Yu Cc: Sun Ke , fstests@vger.kernel.org, guan@eryu.me Subject: Re: [PATCH] common/attr: _acl_get_max echo 532 for f2fs Message-ID: References: <20220130092858.1260210-1-sunke32@huawei.com> <6dbebe97-b29d-ede4-79cf-4d66b2d44c01@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6dbebe97-b29d-ede4-79cf-4d66b2d44c01@kernel.org> Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org On Sun, Jan 30, 2022 at 11:07:17PM +0800, Chao Yu wrote: > On 2022/1/30 17:28, Sun Ke wrote: > > Run generic/026 on f2fs, the diff: > > > > -chacl: cannot set access acl on "largeaclfile": Argument list too long > > +Wrong ACL count - 532 != 531 > > > > The ACL_MAX_ENTRIES depend on MAX_VALUE_LEN(inode), MAX_VALUE_LEN(inode) I got > > by printk is 4244, so I think the ACL_MAX_ENTRIES should be > > (4244 - 20) / 8 + 4 =532. > > > > Signed-off-by: Sun Ke > > FYI: > > https://patchwork.kernel.org/project/fstests/patch/20170428131307.3384-1-chao@kernel.org/ > > I've update the patch based on Jaegeuk's comments, however, I forgot to send it to > mailing list, so could you please check revised one below? > > From 68965c837fd04795064b352589e3f7005e6d75f5 Mon Sep 17 00:00:00 2001 > From: Chao Yu > Date: Fri, 28 Apr 2017 20:51:11 +0800 > Subject: [PATCH v2] attr: adbjust acl_max of f2fs > > f2fs has set inline_xattr as a default option, and introduced a new option > named 'noinline_xattr' for disabling default inline_xattr option. So in > _acl_get_max we need to check 'noinline_xattr' string in fs option, > otherwise we may select the wrong max acl number since we always found > the string 'inline_xattr' in fs option. > > Additionally, f2fs has changed disk layout of xattr block a bit, so will > contain one more entry in both inline and noinline xattr inode, this patch > will modify the max acl number to adjust it. > > Signed-off-by: Chao Yu > --- > v2: > - adjust the config for old kernel as well. > common/attr | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/common/attr b/common/attr > index 35682d7c..6377a936 100644 > --- a/common/attr > +++ b/common/attr > @@ -26,11 +26,16 @@ _acl_get_max() > echo 8191 > ;; > f2fs) > - _fs_options $TEST_DEV | grep "inline_xattr" >/dev/null 2>&1 > + _fs_options $TEST_DEV | grep "noinline_xattr" >/dev/null 2>&1 > if [ $? -eq 0 ]; then > - echo 531 > + echo 507 > else > - echo 506 > + _fs_options $TEST_DEV | grep "inline_xattr" >/dev/null 2>&1 > + if [ $? -eq 0 ]; then > + echo 532 > + else > + echo 507 > + fi > fi > ;; Can you add a comment that explains how these numbers were calculated? They seem very random. - Eric