From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Aditya Garg <gargaditya08@live.com>
Cc: "laurent.pinchart@ideasonboard.com"
<laurent.pinchart@ideasonboard.com>,
"laurent.pinchart+renesas@ideasonboard.com"
<laurent.pinchart+renesas@ideasonboard.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"mchehab+huawei@kernel.org" <mchehab+huawei@kernel.org>,
"hverkuil@xs4all.nl" <hverkuil@xs4all.nl>,
"sergey.senozhatsky@gmail.com" <sergey.senozhatsky@gmail.com>,
"ribalda@chromium.org" <ribalda@chromium.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
Orlando Chamberlain <redecorating@protonmail.com>,
"paul@mrarm.io" <paul@mrarm.io>, Aun-Ali Zaidi <admin@kodeit.net>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH RESEND] media: uvcvideo: Add support for Apple T2-attached FaceTime HD Camera
Date: Wed, 2 Feb 2022 12:41:54 +0900 [thread overview]
Message-ID: <Yfn9glTzki60IRFy@google.com> (raw)
In-Reply-To: <9BD1D373-F588-44EE-AFC0-3D691B4134DA@live.com>
On (22/01/31 09:12), Aditya Garg wrote:
> > On 26-Jan-2022, at 4:07 PM, Aditya Garg <gargaditya08@live.com> wrote:
> >
> > From: Paul Pawlowski <paul@mrarm.io>
> >
> > Adds the requisite device id to support detection of the Apple FaceTime
> > HD webcam exposed over the T2 BCE VHCI interface.
> >
> > Tested-by: Aun-Ali Zaidi <admin@kodeit.net>
> > Signed-off-by: Paul Pawlowski <paul@mrarm.io>
> > Signed-off-by: Aun-Ali Zaidi <admin@kodeit.net>
> > Signed-off-by: Aditya Garg <gargaditya08@live.com>
I'm not the maintainer, but the patch looks OK to me
FWIW
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Laurent, Ricardo, any thoughts?
> > drivers/media/usb/uvc/uvc_driver.c | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> > index 7c007426e..88dc9e7aa 100644
> > --- a/drivers/media/usb/uvc/uvc_driver.c
> > +++ b/drivers/media/usb/uvc/uvc_driver.c
> > @@ -2848,6 +2848,15 @@ static const struct usb_device_id uvc_ids[] = {
> > .bInterfaceProtocol = 0,
> > .driver_info = UVC_INFO_QUIRK(UVC_QUIRK_PROBE_MINMAX
> > | UVC_QUIRK_BUILTIN_ISIGHT) },
> > + /* Apple FaceTime HD Camera (Built-In) */
> > + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
> > + | USB_DEVICE_ID_MATCH_INT_INFO,
> > + .idVendor = 0x05ac,
> > + .idProduct = 0x8514,
> > + .bInterfaceClass = USB_CLASS_VIDEO,
> > + .bInterfaceSubClass = 1,
> > + .bInterfaceProtocol = 0,
> > + .driver_info = (kernel_ulong_t)&uvc_quirk_probe_def },
> > /* Apple Built-In iSight via iBridge */
> > { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
> > | USB_DEVICE_ID_MATCH_INT_INFO,
next prev parent reply other threads:[~2022-02-02 3:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 10:37 [PATCH RESEND] media: uvcvideo: Add support for Apple T2-attached FaceTime HD Camera Aditya Garg
2022-01-31 9:12 ` Aditya Garg
2022-02-02 3:41 ` Sergey Senozhatsky [this message]
2022-02-02 6:37 ` Laurent Pinchart
2022-02-02 7:08 ` Aditya Garg
2022-02-02 23:59 ` Laurent Pinchart
2022-02-03 12:51 ` Aditya Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yfn9glTzki60IRFy@google.com \
--to=senozhatsky@chromium.org \
--cc=admin@kodeit.net \
--cc=gargaditya08@live.com \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mchehab@kernel.org \
--cc=paul@mrarm.io \
--cc=redecorating@protonmail.com \
--cc=ribalda@chromium.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.