From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 257FBC433EF for ; Wed, 2 Feb 2022 13:25:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344315AbiBBNZK (ORCPT ); Wed, 2 Feb 2022 08:25:10 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]:41616 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232862AbiBBNZI (ORCPT ); Wed, 2 Feb 2022 08:25:08 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 364F0617B4 for ; Wed, 2 Feb 2022 13:25:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56D83C340ED; Wed, 2 Feb 2022 13:25:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643808307; bh=jchafuS6+vgsXiYnWLpJZef5yK8Vi9yCKhPRLY9XIYU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=t+wbDdbrzp+LdeTHhq+CwqAEM19xFXWbBh+pnpwJ5F2hTXAlGxlv//iRG+s21sMvn zCKcoYOXoIghmr9Lsmrm19alsdMs0oqf7H5AEkwhnszjPq31nNkaHch8WaSCQe4Cwg 9aiNNvaJ4xDZ38DFNjCAvUNsSECRSDuXrdHC9DWplPnFted5A6kLIt+k9II6Ne81is L7urJ4VRUQLd9XdGUIwuRPP6/4V8SxIVPJ9gSMPv1CZYhnr/faWszWRCjitZM5W90Q wsldzHWd/onsINGMfpmOlmanvJI0kM1n0lMV7AW90/JyoBpXj9QcWE+K0wuvoW8JWS LreF9gj10eSpw== Date: Wed, 2 Feb 2022 13:25:02 +0000 From: Mark Brown To: Curtis Malainey Cc: V sujith kumar Reddy , ALSA development , Vijendar.Mukunda@amd.com, "Hiregoudar, Basavaraj" , "Dommati, Sunil-kumar" , "Pandey, Ajit Kumar" , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , open list Subject: Re: [PATCH] ASoC: amd: acp: Set gpio_spkr_en to None for max speaker amplifer in machine driver Message-ID: References: <20220131203225.1418648-1-vsujithkumar.reddy@amd.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="OYVC+pEbH0ukOWFY" Content-Disposition: inline In-Reply-To: X-Cookie: Quack! Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --OYVC+pEbH0ukOWFY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Feb 01, 2022 at 01:43:38PM -0800, Curtis Malainey wrote: > Yes that is correct, this is the quick fix that will alleviate the > gpio contention issue. But I think there is a better solution here. > According to the sheet I have, the pin for the alc1019 is the same as > the max98357a and its a shutdown pin for the amp. OK, that sounds like it should be added to the driver then. --OYVC+pEbH0ukOWFY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmH6hi0ACgkQJNaLcl1U h9BM6wf/bydWhYb/gkHNtrvSQ/dJxc7Gf7XsY0PY63Xddav43XnO7jtGQHNgIusX TGAwX/Nv1vdJO3clfk/cwBTy8mXL77lEBiEY+uauRpbD7N215EDFKBO/oYOoMmGB 8G/TGXoxF6FVirgzW2MhYh8Kg3biGxV2xQ5B+oBKW1QvCYp8cvP026GjuegtWJSa WbvAo3nan6hAo8M3JoYl0/UiUQT22Lt+c/JBhrqKtTVsWiQ9m96W+5uU1qyt3B4E 5NNXyzFvpRh2k0AonStGPzaefdVSRAArEUNKq0wZO0OzWJJ5xUF1Ru19m8CSvygz jebBoykr+hBTV4pb9Qlv27O7vxYiag== =18y7 -----END PGP SIGNATURE----- --OYVC+pEbH0ukOWFY-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0410DC433F5 for ; Wed, 2 Feb 2022 13:26:06 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0646F171E; Wed, 2 Feb 2022 14:25:14 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0646F171E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1643808364; bh=jchafuS6+vgsXiYnWLpJZef5yK8Vi9yCKhPRLY9XIYU=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=dAg3G9K0htvJ9vIaipeLyQ/2f/wYwvyVXrGQ1Z7dUt033hOtoTN6jViJUvvJ6Jt6Q 5Bi9/8hMhh6DbhJTHhOlqocN1Yhqhs/NPA+ke3OG2fdT9eWCQ9fpI0Rc02izqu4ZKv vya+o48mq3gBB31uOgx1VaxbJXmaSrqK/gl7tex8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id A5F4AF80171; Wed, 2 Feb 2022 14:25:13 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 989E5F804B0; Wed, 2 Feb 2022 14:25:12 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 459B3F80171 for ; Wed, 2 Feb 2022 14:25:10 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 459B3F80171 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="t+wbDdbr" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3DB52617C5; Wed, 2 Feb 2022 13:25:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56D83C340ED; Wed, 2 Feb 2022 13:25:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643808307; bh=jchafuS6+vgsXiYnWLpJZef5yK8Vi9yCKhPRLY9XIYU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=t+wbDdbrzp+LdeTHhq+CwqAEM19xFXWbBh+pnpwJ5F2hTXAlGxlv//iRG+s21sMvn zCKcoYOXoIghmr9Lsmrm19alsdMs0oqf7H5AEkwhnszjPq31nNkaHch8WaSCQe4Cwg 9aiNNvaJ4xDZ38DFNjCAvUNsSECRSDuXrdHC9DWplPnFted5A6kLIt+k9II6Ne81is L7urJ4VRUQLd9XdGUIwuRPP6/4V8SxIVPJ9gSMPv1CZYhnr/faWszWRCjitZM5W90Q wsldzHWd/onsINGMfpmOlmanvJI0kM1n0lMV7AW90/JyoBpXj9QcWE+K0wuvoW8JWS LreF9gj10eSpw== Date: Wed, 2 Feb 2022 13:25:02 +0000 From: Mark Brown To: Curtis Malainey Subject: Re: [PATCH] ASoC: amd: acp: Set gpio_spkr_en to None for max speaker amplifer in machine driver Message-ID: References: <20220131203225.1418648-1-vsujithkumar.reddy@amd.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="OYVC+pEbH0ukOWFY" Content-Disposition: inline In-Reply-To: X-Cookie: Quack! Cc: ALSA development , "Dommati, Sunil-kumar" , "Pandey, Ajit Kumar" , open list , "Hiregoudar, Basavaraj" , Takashi Iwai , Liam Girdwood , Vijendar.Mukunda@amd.com, V sujith kumar Reddy X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --OYVC+pEbH0ukOWFY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Feb 01, 2022 at 01:43:38PM -0800, Curtis Malainey wrote: > Yes that is correct, this is the quick fix that will alleviate the > gpio contention issue. But I think there is a better solution here. > According to the sheet I have, the pin for the alc1019 is the same as > the max98357a and its a shutdown pin for the amp. OK, that sounds like it should be added to the driver then. --OYVC+pEbH0ukOWFY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmH6hi0ACgkQJNaLcl1U h9BM6wf/bydWhYb/gkHNtrvSQ/dJxc7Gf7XsY0PY63Xddav43XnO7jtGQHNgIusX TGAwX/Nv1vdJO3clfk/cwBTy8mXL77lEBiEY+uauRpbD7N215EDFKBO/oYOoMmGB 8G/TGXoxF6FVirgzW2MhYh8Kg3biGxV2xQ5B+oBKW1QvCYp8cvP026GjuegtWJSa WbvAo3nan6hAo8M3JoYl0/UiUQT22Lt+c/JBhrqKtTVsWiQ9m96W+5uU1qyt3B4E 5NNXyzFvpRh2k0AonStGPzaefdVSRAArEUNKq0wZO0OzWJJ5xUF1Ru19m8CSvygz jebBoykr+hBTV4pb9Qlv27O7vxYiag== =18y7 -----END PGP SIGNATURE----- --OYVC+pEbH0ukOWFY--