All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: fstests@vger.kernel.org
Cc: Leah Rumancik <leah.rumancik@gmail.com>,
	Luis Chamberlain <mcgrof@kernel.org>
Subject: Re: [PATCH] common: handle old versions of modprobe which don't support --help
Date: Wed, 2 Feb 2022 08:48:25 -0500	[thread overview]
Message-ID: <YfqLqRKWlCSUP31i@mit.edu> (raw)
In-Reply-To: <20220201231936.981003-1-tytso@mit.edu>

On Tue, Feb 01, 2022 at 06:19:36PM -0500, Theodore Ts'o wrote:
> There exists versions of modprobe out there which are so old that
> modprobe --help isn't a thing.  They're certainly not going to support
> modprobe --remove-patiently, so test to make sure modprobe --help
> works to suppress a spurious warning.

I was going to reword the last part of the commit message, but forgot
to do it before sending out the message.

- works to suppress a spurious warning.
+ works to avoid causing all tests to fail due to the error message
+ to stderr showing up in $seq.out.

	     	    	       	  - Ted

      parent reply	other threads:[~2022-02-02 13:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-01 23:19 [PATCH] common: handle old versions of modprobe which don't support --help Theodore Ts'o
2022-02-02  2:47 ` Luis Chamberlain
2022-02-02 13:48 ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YfqLqRKWlCSUP31i@mit.edu \
    --to=tytso@mit.edu \
    --cc=fstests@vger.kernel.org \
    --cc=leah.rumancik@gmail.com \
    --cc=mcgrof@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.