From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A5C12F29 for ; Wed, 2 Feb 2022 15:37:24 +0000 (UTC) Received: from zn.tnic (dslb-088-067-221-104.088.067.pools.vodafone-ip.de [88.67.221.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 10A411EC059D; Wed, 2 Feb 2022 16:37:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1643816232; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=lR+5h1xpSxxBgCHRuGXXMTqEsGCqmfgSEVBH7xBsRo8=; b=G1I2u0TJApKDboo30VddlADnScMtG9Dasl6SClNcRc3fiGRb2fK/j/sKg+xwr9mX0TT+ZC AJ9QWyrGIKjz+/gy+c6U1k+Cklc9Dn99Qr83fclck8Fa/7bM0+WVKGpo+wAtukkS1ZSCzy IodLXDx0DeRa8zBUw2LNDiIdCUCh2KY= Date: Wed, 2 Feb 2022 16:37:07 +0100 From: Borislav Petkov To: Brijesh Singh Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Michael Roth , Vlastimil Babka , "Kirill A . Shutemov" , Andi Kleen , "Dr . David Alan Gilbert" , brijesh.ksingh@gmail.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com Subject: Re: [PATCH v9 10/43] x86/sev: Check SEV-SNP features support Message-ID: References: <20220128171804.569796-1-brijesh.singh@amd.com> <20220128171804.569796-11-brijesh.singh@amd.com> <02102fda-63b9-5da0-2e2b-037761cc0019@amd.com> Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <02102fda-63b9-5da0-2e2b-037761cc0019@amd.com> On Wed, Feb 02, 2022 at 08:28:17AM -0600, Brijesh Singh wrote: > Yeah, most of the documentation explicitly calls SEV-SNP, I was unsure about > the trademark, so I used it in the comments/logs. I am okay with the SEV > prefix removed; I am not in the marketing team, and hopefully, they will > *never* see kernel code ;) They better! :-) Also, in our kernel team here, the importance lies on having stuff clearly and succinctly explained, without any bla or fluff. When you look at that code later, you should go "ah, ok, that's why we're doing this here" - not, "uuh, I need to sit down and parse that comment first." That's why I'd like for comments to have only good and important words - no deadweight marketing bla. :-) -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette