From: "Magnus Groß" <magnus.gross@rwth-aachen.de>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Eric Biederman <ebiederm@xmission.com>,
<linux-fsdevel@vger.kernel.org>, <linux-mm@kvack.org>,
<linux-hardening@vger.kernel.org>
Subject: Re: [PATCH] elf: Relax assumptions about vaddr ordering
Date: Wed, 2 Feb 2022 16:44:44 +0100 [thread overview]
Message-ID: <Yfqm7HbucDjPbES+@fractal.localdomain> (raw)
In-Reply-To: <YfqgLmk9+4W50EEB@localhost.localdomain>
Am Wed, Feb 02, 2022 at 06:15:58PM +0300 schrieb Alexey Dobriyan:
> On Tue, Feb 01, 2022 at 02:48:16PM -0800, Andrew Morton wrote:
> > On Fri, 28 Jan 2022 14:30:12 -0800 Kees Cook <keescook@chromium.org> wrote:
> >
> > > Andrew, can you update elf-fix-overflow-in-total-mapping-size-calculation.patch
> > > to include:
> > >
> > > Fixes: 5f501d555653 ("binfmt_elf: reintroduce using MAP_FIXED_NOREPLACE")
> > > Cc: stable@vger.kernel.org
> > > Acked-by: Kees Cook <keescook@chromium.org>
> >
> > Done.
> >
> > I'm taking it that we can omit this patch ("elf: Relax assumptions
> > about vaddr ordering") and that Alexey's "ELF: fix overflow in total
> > mapping size calculation" will suffice?
>
> Yes, it is same patch conceptually.
> It should work, but those who can't play Bioshock are better test it.
Yes it works.
Although the change from unsigned int to int is not necessary in the
first place, as you can avoid the -1 initialization for min_addr by
simply using ULONG_MAX, as can be seen in my patch.
next prev parent reply other threads:[~2022-02-02 15:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 16:25 [PATCH] elf: Relax assumptions about vaddr ordering Magnus Groß
2022-01-26 16:50 ` Kees Cook
2022-01-27 6:31 ` Kees Cook
2022-01-28 8:26 ` Magnus Groß
2022-01-28 20:04 ` Kees Cook
2022-01-28 22:30 ` Kees Cook
2022-01-29 7:53 ` Alexey Dobriyan
2022-01-29 13:28 ` Magnus Groß
2022-02-01 22:48 ` Andrew Morton
2022-02-02 1:07 ` Kees Cook
2022-02-02 15:15 ` Alexey Dobriyan
2022-02-02 15:44 ` Magnus Groß [this message]
2022-02-01 22:44 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yfqm7HbucDjPbES+@fractal.localdomain \
--to=magnus.gross@rwth-aachen.de \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.