From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BC66C433EF for ; Thu, 3 Feb 2022 11:30:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350228AbiBCLaj (ORCPT ); Thu, 3 Feb 2022 06:30:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350232AbiBCLac (ORCPT ); Thu, 3 Feb 2022 06:30:32 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 132CEC061714; Thu, 3 Feb 2022 03:30:32 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D195AB83319; Thu, 3 Feb 2022 11:30:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0946DC340EC; Thu, 3 Feb 2022 11:30:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643887829; bh=ElkeASgcn6MS/RiiYgEdTkfCoIEA2TIk4cBPoe8jH3g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JXqPaIoq+5cUUqu5WLopiCmfiYYBwado01Iwsf5VmcLhbMdnx+O+wto3u7LHfc35P lWdB58KuNPN1lRwzPf0WE3Aj3eR78mT2EhifmmV1iTjW415b4x309iKM80tHQhP87R BS7hWekPDSoYhOvu37oUiExkNr4n2ZVO5TgpfrqYDa2Fk9T+jVVqKtzn34iYlQN+04 ObT+fbpU4zPA/C3LEgmcA5C/x8OqoHuqAAwP29HYV7TmLFhqzY+POr4wqRFuMAcpjD NlasCwyJinqoK39/roDpgATzNpkq2I8LDbv+D2dpK+jK1dhy7ffAzoijFEu/rRVn2V l3HpAH1bEgRCw== Date: Thu, 3 Feb 2022 11:30:23 +0000 From: Mark Brown To: "Madhavan T. Venkataraman" Cc: mark.rutland@arm.com, jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v13 06/11] arm64: Use stack_trace_consume_fn and rename args to unwind() Message-ID: References: <95691cae4f4504f33d0fc9075541b1e7deefe96f> <20220117145608.6781-1-madvenka@linux.microsoft.com> <20220117145608.6781-7-madvenka@linux.microsoft.com> <48b17c52-58d6-0df5-a50b-35a8ea408998@linux.microsoft.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="OU6vGcxXH+1e+JAT" Content-Disposition: inline In-Reply-To: <48b17c52-58d6-0df5-a50b-35a8ea408998@linux.microsoft.com> X-Cookie: Prices higher in Alaska and Hawaii. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --OU6vGcxXH+1e+JAT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 02, 2022 at 06:34:43PM -0600, Madhavan T. Venkataraman wrote: > On 2/2/22 12:46, Mark Brown wrote: > > On Mon, Jan 17, 2022 at 08:56:03AM -0600, madvenka@linux.microsoft.com wrote: > >> Rename the arguments to unwind() for better consistency. Also, use the > >> typedef stack_trace_consume_fn for the consume_entry function as it is > >> already defined in linux/stacktrace.h. > > Consistency with...? But otherwise: > Naming consistency. E.g., the name consume_entry is used in a lot of places. > This code used to use fn() instead of consume_entry(). arch_stack_walk() > names the argument to consume_entry as cookie. This code calls it data > instead of cookie. That is all. It is minor in nature. But I thought I might > as well make it conform while I am at it. The commit message should probably say some of that then. --OU6vGcxXH+1e+JAT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmH7vM8ACgkQJNaLcl1U h9CfQAf+MaUncd9LNQlfnS/OHAXj8zGxyDIr9Gmgjk8pvxAc/r4cuY1K4MTyMrjB Ab4gWFuINop5WudPHCI5JkE7nZzdd2doX9fhiTMYOEcw068bMkTrtBRkn5GSF6kQ NHbLxxq6G7DAzqWPnePvL7RX7/IwswqFQvXJ4fOBQ+WmIxBHWJpwdGgLao2F+z8r DHt+OUpEvHBcf1Hy1P5IkJwnVTsZmeDNf1mOflR33uMicEeWr+3Dj18cEh+1586a D1VzUVWkDyECv2s0SBzTAlhAcFR3QF3+1OIHZuIwrl2ooxpAgqjWTjjDgURRO65S Kzgl4MjkmdST0T5OlV/Gi2ApgDTzWA== =bbIO -----END PGP SIGNATURE----- --OU6vGcxXH+1e+JAT-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C5DEC433F5 for ; Thu, 3 Feb 2022 11:32:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xLN52ruqE0t4zg7bbjYwijxrSxb+OHfFwveSsx0itS8=; b=TAOp4l1h32kiXkN/PATzRuHS0B bgm0xIEDGso2eSK0pIFHodW/IWZQ19h8IBAGAkFbSGyDmq7Jh8DX1t10KxrC/Cokvswy0sC6zzjm/ HQ81IL4rdgBD4H62ldQIyDryAzpJUeLn+5a/McyGUFBf0KrRn/7bWAAYgr905DkO3TlJDd+TPHsma jPxWKKOJ8LU1YMsV4u4cFnKrzfwVkGImNkE1ZtC/vnq3YkRXYjEKtJocZBExtgWJh7+MdCdBjSTx9 YQxDY2q2OZ+ZBu1cbbIBIWMWEm1ryyHPB/sQoP/jwqvyAtHcl9TBl9u2xNewMK7XYi4L7CFKzp/aJ ExON+jvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nFaJu-000z6m-C7; Thu, 03 Feb 2022 11:30:34 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nFaJq-000z5e-Pr for linux-arm-kernel@lists.infradead.org; Thu, 03 Feb 2022 11:30:32 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3A3B56164D; Thu, 3 Feb 2022 11:30:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0946DC340EC; Thu, 3 Feb 2022 11:30:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643887829; bh=ElkeASgcn6MS/RiiYgEdTkfCoIEA2TIk4cBPoe8jH3g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JXqPaIoq+5cUUqu5WLopiCmfiYYBwado01Iwsf5VmcLhbMdnx+O+wto3u7LHfc35P lWdB58KuNPN1lRwzPf0WE3Aj3eR78mT2EhifmmV1iTjW415b4x309iKM80tHQhP87R BS7hWekPDSoYhOvu37oUiExkNr4n2ZVO5TgpfrqYDa2Fk9T+jVVqKtzn34iYlQN+04 ObT+fbpU4zPA/C3LEgmcA5C/x8OqoHuqAAwP29HYV7TmLFhqzY+POr4wqRFuMAcpjD NlasCwyJinqoK39/roDpgATzNpkq2I8LDbv+D2dpK+jK1dhy7ffAzoijFEu/rRVn2V l3HpAH1bEgRCw== Date: Thu, 3 Feb 2022 11:30:23 +0000 From: Mark Brown To: "Madhavan T. Venkataraman" Cc: mark.rutland@arm.com, jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v13 06/11] arm64: Use stack_trace_consume_fn and rename args to unwind() Message-ID: References: <95691cae4f4504f33d0fc9075541b1e7deefe96f> <20220117145608.6781-1-madvenka@linux.microsoft.com> <20220117145608.6781-7-madvenka@linux.microsoft.com> <48b17c52-58d6-0df5-a50b-35a8ea408998@linux.microsoft.com> MIME-Version: 1.0 In-Reply-To: <48b17c52-58d6-0df5-a50b-35a8ea408998@linux.microsoft.com> X-Cookie: Prices higher in Alaska and Hawaii. X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220203_033030_905773_ED411795 X-CRM114-Status: GOOD ( 17.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1175071391549558468==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1175071391549558468== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="OU6vGcxXH+1e+JAT" Content-Disposition: inline --OU6vGcxXH+1e+JAT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 02, 2022 at 06:34:43PM -0600, Madhavan T. Venkataraman wrote: > On 2/2/22 12:46, Mark Brown wrote: > > On Mon, Jan 17, 2022 at 08:56:03AM -0600, madvenka@linux.microsoft.com wrote: > >> Rename the arguments to unwind() for better consistency. Also, use the > >> typedef stack_trace_consume_fn for the consume_entry function as it is > >> already defined in linux/stacktrace.h. > > Consistency with...? But otherwise: > Naming consistency. E.g., the name consume_entry is used in a lot of places. > This code used to use fn() instead of consume_entry(). arch_stack_walk() > names the argument to consume_entry as cookie. This code calls it data > instead of cookie. That is all. It is minor in nature. But I thought I might > as well make it conform while I am at it. The commit message should probably say some of that then. --OU6vGcxXH+1e+JAT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmH7vM8ACgkQJNaLcl1U h9CfQAf+MaUncd9LNQlfnS/OHAXj8zGxyDIr9Gmgjk8pvxAc/r4cuY1K4MTyMrjB Ab4gWFuINop5WudPHCI5JkE7nZzdd2doX9fhiTMYOEcw068bMkTrtBRkn5GSF6kQ NHbLxxq6G7DAzqWPnePvL7RX7/IwswqFQvXJ4fOBQ+WmIxBHWJpwdGgLao2F+z8r DHt+OUpEvHBcf1Hy1P5IkJwnVTsZmeDNf1mOflR33uMicEeWr+3Dj18cEh+1586a D1VzUVWkDyECv2s0SBzTAlhAcFR3QF3+1OIHZuIwrl2ooxpAgqjWTjjDgURRO65S Kzgl4MjkmdST0T5OlV/Gi2ApgDTzWA== =bbIO -----END PGP SIGNATURE----- --OU6vGcxXH+1e+JAT-- --===============1175071391549558468== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1175071391549558468==--