From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 931652F21 for ; Thu, 3 Feb 2022 14:49:03 +0000 (UTC) Received: from zn.tnic (dslb-088-067-221-104.088.067.pools.vodafone-ip.de [88.67.221.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 9E2581EC04C1; Thu, 3 Feb 2022 15:48:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1643899737; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=8Uqs/kDYfVg3f/Ym3U30Di60DX4+d07g0nCPI6xr98c=; b=I6PKS7BacJGlT/KI4poYSn2BpUX1slO9EeirJdDS14JDZbpjYTIpqWLyq2hec4YYO2NvZe 7nsdiDc2CmdIXExbPmAyXRksSI7R5Lig6hT0K3n72EZD3T7Uial6gNkDrsV5bCOs7KVMVS ozn/Ezuh1BH2/3CW1eB1Dh43WeDOXVE= Date: Thu, 3 Feb 2022 15:48:57 +0100 From: Borislav Petkov To: Brijesh Singh Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Michael Roth , Vlastimil Babka , "Kirill A . Shutemov" , Andi Kleen , "Dr . David Alan Gilbert" , brijesh.ksingh@gmail.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com Subject: Re: [PATCH v9 25/43] x86/compressed/acpi: Move EFI system table lookup to helper Message-ID: References: <20220128171804.569796-1-brijesh.singh@amd.com> <20220128171804.569796-26-brijesh.singh@amd.com> Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220128171804.569796-26-brijesh.singh@amd.com> On Fri, Jan 28, 2022 at 11:17:46AM -0600, Brijesh Singh wrote: > diff --git a/arch/x86/boot/compressed/efi.c b/arch/x86/boot/compressed/efi.c > index daa73efdc7a5..bf99768cd229 100644 > --- a/arch/x86/boot/compressed/efi.c > +++ b/arch/x86/boot/compressed/efi.c > @@ -48,3 +48,32 @@ enum efi_type efi_get_type(struct boot_params *boot_params) > > return et; > } > + > +/* /** kernel-doc comment pls. > + * efi_get_system_table - Given boot_params, retrieve the physical address of > + * EFI system table. > + * > + * @boot_params: pointer to boot_params > + * > + * Return: EFI system table address on success. On error, return 0. > + */ > +unsigned long efi_get_system_table(struct boot_params *boot_params) ... *bp) - as before. Please go through all those functions taking in struct boot_params ptr. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette