From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5B392C9D for ; Thu, 3 Feb 2022 15:13:41 +0000 (UTC) Received: from zn.tnic (dslb-088-067-221-104.088.067.pools.vodafone-ip.de [88.67.221.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 06EFB1EC058A; Thu, 3 Feb 2022 16:13:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1643901215; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=su0chIW0cbLPhkXWhBMbksAxZ8gJeI5gzh3NlG+Xo84=; b=IR0S7zOkfUWi6s+H1hW6QRZqmnqKiQr+TTTkruM9jmVAPrd6LPVMOz/kLFqsEMBL6OHUdb 0RirvheWyH6ntw7tYuI3euDtmJu0KSSIcQ2UrY+HQkOAfjVqNXUkgvupXLWO5B8tEQ0tDr MFvLcIG8N1QcnGZL9J29hBqtFkThfxs= Date: Thu, 3 Feb 2022 16:13:29 +0100 From: Borislav Petkov To: Brijesh Singh Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Michael Roth , Vlastimil Babka , "Kirill A . Shutemov" , Andi Kleen , "Dr . David Alan Gilbert" , brijesh.ksingh@gmail.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com Subject: Re: [PATCH v9 26/43] x86/compressed/acpi: Move EFI config table lookup to helper Message-ID: References: <20220128171804.569796-1-brijesh.singh@amd.com> <20220128171804.569796-27-brijesh.singh@amd.com> Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220128171804.569796-27-brijesh.singh@amd.com> On Fri, Jan 28, 2022 at 11:17:47AM -0600, Brijesh Singh wrote: > +int efi_get_conf_table(struct boot_params *boot_params, unsigned long *cfg_tbl_pa, > + unsigned int *cfg_tbl_len) > +{ > + unsigned long sys_tbl_pa = 0; > + enum efi_type et; > + int ret; > + > + if (!cfg_tbl_pa || !cfg_tbl_len) > + return -EINVAL; > + > + sys_tbl_pa = efi_get_system_table(boot_params); > + if (!sys_tbl_pa) > + return -EINVAL; > + > + /* Handle EFI bitness properly */ > + et = efi_get_type(boot_params); > + if (et == EFI_TYPE_64) { > + efi_system_table_64_t *stbl = > + (efi_system_table_64_t *)sys_tbl_pa; > + > + *cfg_tbl_pa = stbl->tables; > + *cfg_tbl_len = stbl->nr_tables; > + } else if (et == EFI_TYPE_32) { > + efi_system_table_32_t *stbl = > + (efi_system_table_32_t *)sys_tbl_pa; You don't have to break those assignment lines - the 80 cols rule is not a hard one. Readability is more important. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette