From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09437C433F5 for ; Fri, 18 Feb 2022 11:51:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1B0DB10E1E8; Fri, 18 Feb 2022 11:51:14 +0000 (UTC) Received: from mx1.smtp.larsendata.com (mx1.smtp.larsendata.com [91.221.196.215]) by gabe.freedesktop.org (Postfix) with ESMTPS id C147D10E1E8 for ; Fri, 18 Feb 2022 11:51:12 +0000 (UTC) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx1.smtp.larsendata.com (Halon) with ESMTPS id 1bda185b-90b1-11ec-baa1-0050568c148b; Fri, 18 Feb 2022 11:51:29 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id 0E0B3194B47; Fri, 18 Feb 2022 12:51:10 +0100 (CET) Date: Fri, 18 Feb 2022 12:51:07 +0100 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Ville Syrjala Subject: Re: [PATCH 20/22] drm/panel: Use drm_mode_duplicate() Message-ID: References: <20220218100403.7028-1-ville.syrjala@linux.intel.com> <20220218100403.7028-21-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220218100403.7028-21-ville.syrjala@linux.intel.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, Thierry Reding , dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Ville, On Fri, Feb 18, 2022 at 12:04:01PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Replace the hand rolled drm_mode_duplicate() with the > real thing. > > @is_dup@ > @@ > drm_mode_duplicate(...) > { ... } > > @depends on !is_dup@ > expression dev, oldmode; > identifier newmode; > @@ > - newmode = drm_mode_create(dev); > + newmode = drm_mode_duplicate(dev, oldmode); > ... > - drm_mode_copy(newmode, oldmode); > > Signed-off-by: Ville Syrjälä > Cc: Thierry Reding > Cc: Sam Ravnborg Looks good, Acked-by: Sam Ravnborg From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0059C433EF for ; Fri, 18 Feb 2022 11:51:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9962310E2A4; Fri, 18 Feb 2022 11:51:14 +0000 (UTC) Received: from mx1.smtp.larsendata.com (mx1.smtp.larsendata.com [91.221.196.215]) by gabe.freedesktop.org (Postfix) with ESMTPS id C495210E391 for ; Fri, 18 Feb 2022 11:51:12 +0000 (UTC) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx1.smtp.larsendata.com (Halon) with ESMTPS id 1bda185b-90b1-11ec-baa1-0050568c148b; Fri, 18 Feb 2022 11:51:29 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id 0E0B3194B47; Fri, 18 Feb 2022 12:51:10 +0100 (CET) Date: Fri, 18 Feb 2022 12:51:07 +0100 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Ville Syrjala Message-ID: References: <20220218100403.7028-1-ville.syrjala@linux.intel.com> <20220218100403.7028-21-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220218100403.7028-21-ville.syrjala@linux.intel.com> Subject: Re: [Intel-gfx] [PATCH 20/22] drm/panel: Use drm_mode_duplicate() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Ville, On Fri, Feb 18, 2022 at 12:04:01PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Replace the hand rolled drm_mode_duplicate() with the > real thing. > > @is_dup@ > @@ > drm_mode_duplicate(...) > { ... } > > @depends on !is_dup@ > expression dev, oldmode; > identifier newmode; > @@ > - newmode = drm_mode_create(dev); > + newmode = drm_mode_duplicate(dev, oldmode); > ... > - drm_mode_copy(newmode, oldmode); > > Signed-off-by: Ville Syrjälä > Cc: Thierry Reding > Cc: Sam Ravnborg Looks good, Acked-by: Sam Ravnborg