All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: eduardo@habkost.net, Thomas Huth <thuth@redhat.com>,
	mst@redhat.com, quintela@redhat.com, qemu-devel@nongnu.org,
	Gerd Hoffmann <kraxel@redhat.com>,
	pbonzini@redhat.com
Subject: Re: [PATCH 3/3] x86: Switch to q35 as the default machine type
Date: Wed, 16 Feb 2022 17:48:08 +0000	[thread overview]
Message-ID: <Yg042JzxCjgF2siM@redhat.com> (raw)
In-Reply-To: <Yg03HB5KHGYWyI0J@work-vm>

On Wed, Feb 16, 2022 at 05:40:44PM +0000, Dr. David Alan Gilbert wrote:
> * Thomas Huth (thuth@redhat.com) wrote:
> > On 16/02/2022 12.01, Dr. David Alan Gilbert wrote:
> > > * Gerd Hoffmann (kraxel@redhat.com) wrote:
> > > >    Hi,
> > > > > Given the semantic differences from 'i440fx', changing the default
> > > > > machine type has effects that are equivalent to breaking command
> > > > > line syntax compatibility, which is something we've always tried
> > > > > to avoid.
> > > > 
> > > > And if we are fine breaking backward compatibility I'd rather *not* pick
> > > > a default, effectively making -M $something mandatory, similar to arm.
> > > 
> > > Oh, that's probably easy to do;  what are other peoples thoughts on
> > > that?
> > 
> > I agree with Gerd. Getting rid of a default machine on x86 is likely better
> > than silently changing it to q35. But I'd maybe say that this should go
> > through the deprecation process first?
> 
> So just adding something like the following under 'System emulator
> machines':
> 
> x86 default machine type
> ------------------------
> 
> x86 currently defaults to the very old ```pc``` machine type
> which is based on the very old ```i440f``` chipset.  This default
> will be removed and the user will be required to specify a machine
> type explicitly using -M; users are encouraged to switch to the
> not quite as old ```q35``` machine types.
> 
> 
> (This option is going to take a lot more work switching all the
> test cases over; in my world here I'd only changed the tests that broke
> on q35, now everything is going to need to specify a type).

....which is still nothing compared to how many users will be impacted
and the docs all over the internet we'll never be able to change, which
give illustrations using qemu command lines without '-M pc'

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2022-02-16 18:15 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-15 16:25 [PATCH 0/3] x86: Switch over to q35 as the default machine type Dr. David Alan Gilbert (git)
2022-02-15 16:25 ` [PATCH 1/3] tests/x86: Use 'pc' machine type for old hardware tests Dr. David Alan Gilbert (git)
2022-02-17  8:04   ` Thomas Huth
2022-02-17  8:18   ` Michael S. Tsirkin
2022-02-15 16:25 ` [PATCH 2/3] tests/x86: Use 'pc' machine type for hotplug tests Dr. David Alan Gilbert (git)
2022-02-17  8:09   ` Thomas Huth
2022-02-17  8:18   ` Michael S. Tsirkin
2022-02-15 16:25 ` [PATCH 3/3] x86: Switch to q35 as the default machine type Dr. David Alan Gilbert (git)
2022-02-15 18:13   ` Daniel P. Berrangé
2022-02-15 18:29     ` Dr. David Alan Gilbert
2022-02-16 10:58     ` Gerd Hoffmann
2022-02-16 11:01       ` Dr. David Alan Gilbert
2022-02-16 11:23         ` Daniel P. Berrangé
2022-02-16 11:24         ` Thomas Huth
2022-02-16 17:40           ` Dr. David Alan Gilbert
2022-02-16 17:48             ` Daniel P. Berrangé [this message]
2022-02-16 17:57               ` Dr. David Alan Gilbert
2022-02-17  7:46                 ` Thomas Huth
2022-02-17  7:52                   ` Michael S. Tsirkin
2022-02-17  9:29                 ` Daniel P. Berrangé
2022-02-17  9:43                   ` Dr. David Alan Gilbert
2022-02-17  7:57             ` Thomas Huth
2022-02-17  8:08               ` Gerd Hoffmann
2022-02-17  8:17                 ` Michael S. Tsirkin
2022-02-17  9:16                   ` Daniel P. Berrangé
2022-02-17  9:35                   ` Igor Mammedov
2022-02-17  9:19               ` Kashyap Chamarthy
2022-02-15 16:25 ` [PATCH 0/3] x86: Switch over " Dr. David Alan Gilbert (git)
2022-02-15 16:25 ` [PATCH 1/3] tests/x86: Use 'pc' machine type for old hardware tests Dr. David Alan Gilbert (git)
2022-02-15 16:25 ` [PATCH 2/3] tests/x86: Use 'pc' machine type for hotplug tests Dr. David Alan Gilbert (git)
2022-02-15 16:25 ` [PATCH 3/3] x86: Switch to q35 as the default machine type Dr. David Alan Gilbert (git)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yg042JzxCjgF2siM@redhat.com \
    --to=berrange@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=kraxel@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.