From: Christoph Hellwig <hch@infradead.org>
To: "Nitin Rawat (QUIC)" <quic_nitirawa@quicinc.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Vidya Sagar <vidyas@nvidia.com>, Keith Busch <kbusch@kernel.org>,
Jens Axboe <axboe@fb.com>, Sagi Grimberg <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Sajida Bhanu (Temp) (QUIC)" <quic_c_sbhanu@quicinc.com>
Subject: Re: [PATCH v3] nvme/pci: Add quick suspend quirk for Sc7280 Platform
Date: Wed, 16 Feb 2022 09:12:50 -0800 [thread overview]
Message-ID: <Yg0wklcJ3ed76Jbk@infradead.org> (raw)
In-Reply-To: <9b291987cf914f119788c42b32a08a12@quicinc.com>
On Wed, Feb 16, 2022 at 04:07:05PM +0000, Nitin Rawat (QUIC) wrote:
> Hi Christoph/Keith/Rafael
>
> Since we are giving control to PCIe (NVMe power rails control), it can vary from platform to platform.
> More over, PCIe driver doesn't control these power rails directly from PCIe driver, they tie nvme supply with one of the pcie supply and control them together.
> So i think it would be better to either have quirk based on platform or always setting simple suspend and platform which needs full suspend can update it through some means.
>
> Based on below link, Looks like this can be across platform ...vidya also mention similar concern for tegra platform.
Here is the thing: nothing here is really NVMe specific. We do have
a bunch of drivers including nvme that would love to not do a full
firmware shutdown on a suspend. For storage devices this is especially
important as each shutdown reduces media life time. Until very recently
this has been perfectly fine, but now various platforms show up that
want to completely disable power to PCIe slots on a system suspend.
The drivers need information from the PCI / PM core when a ->suspend
call requires the device to got into D3 and when not, and we can't just
do that with quirks in the various drivers.
next prev parent reply other threads:[~2022-02-16 17:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 20:53 [PATCH v3] nvme/pci: Add quick suspend quirk for Sc7280 Platform Nitin Rawat
2022-02-10 20:57 ` Keith Busch
2022-02-10 20:58 ` Nitin Rawat (QUIC)
2022-02-11 6:22 ` Christoph Hellwig
2022-02-16 16:07 ` Nitin Rawat (QUIC)
2022-02-16 16:09 ` Nitin Rawat (QUIC)
2022-02-17 2:42 ` Vidya Sagar
2022-02-16 17:12 ` Christoph Hellwig [this message]
[not found] ` <8b2735c1-4207-dc1b-45bc-33a4138b57cc@quicinc.com>
2022-04-20 7:46 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yg0wklcJ3ed76Jbk@infradead.org \
--to=hch@infradead.org \
--cc=axboe@fb.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=quic_c_sbhanu@quicinc.com \
--cc=quic_nitirawa@quicinc.com \
--cc=sagi@grimberg.me \
--cc=vidyas@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.