From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6163C433FE for ; Wed, 16 Feb 2022 23:52:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238644AbiBPXwf (ORCPT ); Wed, 16 Feb 2022 18:52:35 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:56462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229820AbiBPXwd (ORCPT ); Wed, 16 Feb 2022 18:52:33 -0500 Received: from mail-il1-f181.google.com (mail-il1-f181.google.com [209.85.166.181]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77089F4063; Wed, 16 Feb 2022 15:52:20 -0800 (PST) Received: by mail-il1-f181.google.com with SMTP id d3so1049538ilr.10; Wed, 16 Feb 2022 15:52:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=b/JXIitbDZ9HoqIJQDyG8ELeQOdY8UCMjKhFkXYelkw=; b=eAKZe+Seh7P0SYBnxfLgH/sgd67U+4UQXJU/+1+vLP6bFNhtAmzjXj0e03i5X6uYCr MANiweju6037zb6zhB4Vjo23/k+aaEQrHu4R06EyIL2ZVV16UoOPWXS5xbk5CdgFAXRG GC3GFQiBQUWPcLt2OZdOZ2JtHQ9LDiytt0PzCCSc27pJczQgWXpngj4+8wsOSMuqEdpj wIxCm8TQvHwAb3HP5qYPBRedrVDggr9JNmo+g+hycBq7mHaP8N9Ubm3QRilwdzjY0c+l 1vBEHpQJis/mXS1giY9IqwfOV8YbkF3c2XPFiz36kzAOsS2rxdoC5k/y79tt73amRxz6 0ayA== X-Gm-Message-State: AOAM531u1UJujwPXSE2Ywf5vAx8Fp0D7jQJJ7E00M0+EvTJeZTS5kvs0 jz3Gia5pEcQDbOhn6O7Pew== X-Google-Smtp-Source: ABdhPJzMeZBEmpkyBZ0DqYIbANVj7AN2XmgRUWyZkypg6ORTBG7lSLroGnVPeDY/yrX1DtGyrr1CDQ== X-Received: by 2002:a92:c567:0:b0:2b8:b4d1:ba3c with SMTP id b7-20020a92c567000000b002b8b4d1ba3cmr202018ilj.50.1645055539773; Wed, 16 Feb 2022 15:52:19 -0800 (PST) Received: from robh.at.kernel.org ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id i13sm800285ila.46.2022.02.16.15.52.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Feb 2022 15:52:18 -0800 (PST) Received: (nullmailer pid 1918923 invoked by uid 1000); Wed, 16 Feb 2022 23:52:16 -0000 Date: Wed, 16 Feb 2022 17:52:16 -0600 From: Rob Herring To: Andreas Kemnade Cc: p.zabel@pengutronix.de, airlied@linux.ie, daniel@ffwll.ch, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alistair@alistair23.me, samuel@sholland.org, josua.mayer@jm0.eu, letux-kernel@openphoenux.org Subject: Re: [RFC PATCH 1/6] dt-bindings: display: imx: Add EPDC Message-ID: References: <20220206080016.796556-1-andreas@kemnade.info> <20220206080016.796556-2-andreas@kemnade.info> <20220214234517.121e1167@aktux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220214234517.121e1167@aktux> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 14, 2022 at 11:45:17PM +0100, Andreas Kemnade wrote: > Hi Rob, > > On Fri, 11 Feb 2022 09:46:27 -0600 > Rob Herring wrote: > > > On Sun, Feb 06, 2022 at 09:00:11AM +0100, Andreas Kemnade wrote: > > > Add a binding for the Electrophoretic Display Controller found at least > > > in the i.MX6. > > > > The first version was in i.MX50 (I helped design the register > > interface). Is that version compatible? > > > it has some differences, but that could be detected by EPDC_VERSION > register. I do not own such a device, so I cannot fully check. I have > not seen any driver with devicetree for IMX5. For now I am rejecting > anything which has a EPDC version which I cannot check. > > > > The timing subnode is directly here to avoid having display parameters > > > spread all over the plate. > > > > > > Supplies are organized the same way as in the fbdev driver in the > > > NXP/Freescale kernel forks. The regulators used for that purpose, > > > like the TPS65185, the SY7636A and MAX17135 have typically a single bit to > > > start a bunch of regulators of higher or negative voltage with a > > > well-defined timing. VCOM can be handled separately, but can also be > > > incorporated into that single bit. > > > > > > Signed-off-by: Andreas Kemnade > > > --- > > > .../bindings/display/imx/fsl,mxc-epdc.yaml | 159 ++++++++++++++++++ > > > 1 file changed, 159 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,mxc-epdc.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/display/imx/fsl,mxc-epdc.yaml b/Documentation/devicetree/bindings/display/imx/fsl,mxc-epdc.yaml > > > new file mode 100644 > > > index 000000000000..7e0795cc3f70 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/display/imx/fsl,mxc-epdc.yaml > > > @@ -0,0 +1,159 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/display/imx/fsl,mxc-epdc.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Freescale i.MX6 EPDC > > > + > > > +maintainers: > > > + - Andreas Kemnade > > > + > > > +description: | > > > + The EPDC is a controller for handling electronic paper displays found in > > > + i.MX6 SoCs. > > > + > > > +properties: > > > + compatible: > > > + enum: > > > + - fsl,imx6sl-epdc > > > + - fsl,imx6sll-epdc > > > > Not compatible with each other? > > > differences are detectable by EPDC_VERSION register, so probably so > problem. NXP/Freescale kernel uses > fsl,imx6dl-epdc > and > fsl,imx7d-epdc (used also by imx6 devices with EPDC_VERSION = 3.0) > in their drivers. > > fsl,imx6dl-epdc > fsl,imx6sl-epdc > fsl,imx6sll-epdc > fsl,imx7d-epdc > in their dtsis. > > But the general rule is to use as less as possible compatible strings > if differences can be probed properly, so only one should be > sufficient? Which one? If you can probe all the differences, then just 'fsl,imx-epdc' is sufficient. Just document that so the next time around I don't forget and tell you it needs to be specific. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1A8FC433F5 for ; Wed, 16 Feb 2022 23:52:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C026D10E669; Wed, 16 Feb 2022 23:52:21 +0000 (UTC) Received: from mail-il1-f179.google.com (mail-il1-f179.google.com [209.85.166.179]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7211910E669 for ; Wed, 16 Feb 2022 23:52:20 +0000 (UTC) Received: by mail-il1-f179.google.com with SMTP id p11so1075294ils.1 for ; Wed, 16 Feb 2022 15:52:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=b/JXIitbDZ9HoqIJQDyG8ELeQOdY8UCMjKhFkXYelkw=; b=cA1Sbx6x+/LuVSA3nWEzD66/z5dUFbqhRq1CgEJ6LwYNXspJrbCTTiYJsdXj3458t1 JaP0/gqWO998phexV7lpjBme8rpvd4LFjI3+XORR9CycQf4svMMVTZZ/v2mqmJLQpEtm s7vF2weAiit5xt/W4vdaaY41V4ETMtwT8hIcc82zkQhSJHd1ILWy22cQe390WYeMYG17 fmiGWDXj5l9vVaUhz/a0ErOlHom1U6kDS48VHxAe2vXVNknzyWZzhRqyaDL580EX/yyf pEdSH0DGwIdwTl0Y4qdXiOoaoDAot25+9N7YcZGz5NKDClOIhKRGR4MKkNgHIq8GLoPP bvIA== X-Gm-Message-State: AOAM5313U5KWX/sa4zdp69eolDIG/ACcfa3Swt/HbIz6hFlJr80UZ6sd dFIYP9b1HxbIlvOC90xS5g== X-Google-Smtp-Source: ABdhPJzMeZBEmpkyBZ0DqYIbANVj7AN2XmgRUWyZkypg6ORTBG7lSLroGnVPeDY/yrX1DtGyrr1CDQ== X-Received: by 2002:a92:c567:0:b0:2b8:b4d1:ba3c with SMTP id b7-20020a92c567000000b002b8b4d1ba3cmr202018ilj.50.1645055539773; Wed, 16 Feb 2022 15:52:19 -0800 (PST) Received: from robh.at.kernel.org ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id i13sm800285ila.46.2022.02.16.15.52.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Feb 2022 15:52:18 -0800 (PST) Received: (nullmailer pid 1918923 invoked by uid 1000); Wed, 16 Feb 2022 23:52:16 -0000 Date: Wed, 16 Feb 2022 17:52:16 -0600 From: Rob Herring To: Andreas Kemnade Subject: Re: [RFC PATCH 1/6] dt-bindings: display: imx: Add EPDC Message-ID: References: <20220206080016.796556-1-andreas@kemnade.info> <20220206080016.796556-2-andreas@kemnade.info> <20220214234517.121e1167@aktux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220214234517.121e1167@aktux> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, letux-kernel@openphoenux.org, tzimmermann@suse.de, samuel@sholland.org, airlied@linux.ie, s.hauer@pengutronix.de, alistair@alistair23.me, linux-kernel@vger.kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, josua.mayer@jm0.eu, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Feb 14, 2022 at 11:45:17PM +0100, Andreas Kemnade wrote: > Hi Rob, > > On Fri, 11 Feb 2022 09:46:27 -0600 > Rob Herring wrote: > > > On Sun, Feb 06, 2022 at 09:00:11AM +0100, Andreas Kemnade wrote: > > > Add a binding for the Electrophoretic Display Controller found at least > > > in the i.MX6. > > > > The first version was in i.MX50 (I helped design the register > > interface). Is that version compatible? > > > it has some differences, but that could be detected by EPDC_VERSION > register. I do not own such a device, so I cannot fully check. I have > not seen any driver with devicetree for IMX5. For now I am rejecting > anything which has a EPDC version which I cannot check. > > > > The timing subnode is directly here to avoid having display parameters > > > spread all over the plate. > > > > > > Supplies are organized the same way as in the fbdev driver in the > > > NXP/Freescale kernel forks. The regulators used for that purpose, > > > like the TPS65185, the SY7636A and MAX17135 have typically a single bit to > > > start a bunch of regulators of higher or negative voltage with a > > > well-defined timing. VCOM can be handled separately, but can also be > > > incorporated into that single bit. > > > > > > Signed-off-by: Andreas Kemnade > > > --- > > > .../bindings/display/imx/fsl,mxc-epdc.yaml | 159 ++++++++++++++++++ > > > 1 file changed, 159 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,mxc-epdc.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/display/imx/fsl,mxc-epdc.yaml b/Documentation/devicetree/bindings/display/imx/fsl,mxc-epdc.yaml > > > new file mode 100644 > > > index 000000000000..7e0795cc3f70 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/display/imx/fsl,mxc-epdc.yaml > > > @@ -0,0 +1,159 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/display/imx/fsl,mxc-epdc.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Freescale i.MX6 EPDC > > > + > > > +maintainers: > > > + - Andreas Kemnade > > > + > > > +description: | > > > + The EPDC is a controller for handling electronic paper displays found in > > > + i.MX6 SoCs. > > > + > > > +properties: > > > + compatible: > > > + enum: > > > + - fsl,imx6sl-epdc > > > + - fsl,imx6sll-epdc > > > > Not compatible with each other? > > > differences are detectable by EPDC_VERSION register, so probably so > problem. NXP/Freescale kernel uses > fsl,imx6dl-epdc > and > fsl,imx7d-epdc (used also by imx6 devices with EPDC_VERSION = 3.0) > in their drivers. > > fsl,imx6dl-epdc > fsl,imx6sl-epdc > fsl,imx6sll-epdc > fsl,imx7d-epdc > in their dtsis. > > But the general rule is to use as less as possible compatible strings > if differences can be probed properly, so only one should be > sufficient? Which one? If you can probe all the differences, then just 'fsl,imx-epdc' is sufficient. Just document that so the next time around I don't forget and tell you it needs to be specific. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72D2EC433F5 for ; Wed, 16 Feb 2022 23:53:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=af9tc3UIfEjXlp+TRUPpjXhLjmtDpS90Hdnctiz7k2Q=; b=sO39Du2/vkFNnm rxBpqHR0kDKaBrdAoFFOgGIR/tFx3hG4mjdoZsztBoojEvf71peYK6dERw0YNmBMtmvtXdAs7EVLB KTt5X1cor08NMtWVpVTN6oP1vjbuprMtRJLd8eaFPXO3doJ0JzguHXMZbn74G+adJdilrKiWJbcyb 5Bm2lOsd3TRtfw2oySVJILdRQw19hlUjGUSg1pHk1Ti4755KHv3SAVjiMoIH0cVq2dBPOO+OBx4hg E8mN4txtuMK2gcUynQ1eyJmVLq3/+n+3ng8kPYudkc4t4EUjiawBxcGvkf+EsQqGf+q1f0W7BzT9k eawBQCkV8YZBOMGVUbAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKU5v-008Xkq-RB; Wed, 16 Feb 2022 23:52:23 +0000 Received: from mail-il1-f180.google.com ([209.85.166.180]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKU5s-008XkQ-Ns for linux-arm-kernel@lists.infradead.org; Wed, 16 Feb 2022 23:52:22 +0000 Received: by mail-il1-f180.google.com with SMTP id z18so1070705iln.2 for ; Wed, 16 Feb 2022 15:52:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=b/JXIitbDZ9HoqIJQDyG8ELeQOdY8UCMjKhFkXYelkw=; b=5ZK16/lmCS0BW6Zgmg+wkvddxQLFG4Misf4pLEeu3//ixxBJSDzMY2d1m96UyrHkC0 M/DbT7PVVj40LU8EFiaiLEWk8WRX/aZLkJ5C5vuwhdspcjy2cRostYgONxqoZPg5cyJA gIoZAkHcWl2pdbUSHC4aCdd1hMkUUdBqH+Au/YSYhe1VzTRN5hAjgi6h20CF6DZsqWxn 1x8eg2mH923ehZAOw1DBBZNXDaumasD57XSVxGp9WLIC5gQM/a/ioIgJqPK84ScSdDCN rS2d2Hh7QsSE+8O6sq47HQytAiVpZCz7DyrxEqtFf2uGhKaz9cYHVYyJ6YgQHTvFTzZi F5lA== X-Gm-Message-State: AOAM532+0SXIJEr9Ti885m9/8DeNnT/7z3qrBfxAxcL17R/lhVESuvR8 LfG7owshyGmGElF2hhTYzQ== X-Google-Smtp-Source: ABdhPJzMeZBEmpkyBZ0DqYIbANVj7AN2XmgRUWyZkypg6ORTBG7lSLroGnVPeDY/yrX1DtGyrr1CDQ== X-Received: by 2002:a92:c567:0:b0:2b8:b4d1:ba3c with SMTP id b7-20020a92c567000000b002b8b4d1ba3cmr202018ilj.50.1645055539773; Wed, 16 Feb 2022 15:52:19 -0800 (PST) Received: from robh.at.kernel.org ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id i13sm800285ila.46.2022.02.16.15.52.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Feb 2022 15:52:18 -0800 (PST) Received: (nullmailer pid 1918923 invoked by uid 1000); Wed, 16 Feb 2022 23:52:16 -0000 Date: Wed, 16 Feb 2022 17:52:16 -0600 From: Rob Herring To: Andreas Kemnade Cc: p.zabel@pengutronix.de, airlied@linux.ie, daniel@ffwll.ch, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alistair@alistair23.me, samuel@sholland.org, josua.mayer@jm0.eu, letux-kernel@openphoenux.org Subject: Re: [RFC PATCH 1/6] dt-bindings: display: imx: Add EPDC Message-ID: References: <20220206080016.796556-1-andreas@kemnade.info> <20220206080016.796556-2-andreas@kemnade.info> <20220214234517.121e1167@aktux> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220214234517.121e1167@aktux> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220216_155220_822858_FF7EF2E9 X-CRM114-Status: GOOD ( 34.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 14, 2022 at 11:45:17PM +0100, Andreas Kemnade wrote: > Hi Rob, > > On Fri, 11 Feb 2022 09:46:27 -0600 > Rob Herring wrote: > > > On Sun, Feb 06, 2022 at 09:00:11AM +0100, Andreas Kemnade wrote: > > > Add a binding for the Electrophoretic Display Controller found at least > > > in the i.MX6. > > > > The first version was in i.MX50 (I helped design the register > > interface). Is that version compatible? > > > it has some differences, but that could be detected by EPDC_VERSION > register. I do not own such a device, so I cannot fully check. I have > not seen any driver with devicetree for IMX5. For now I am rejecting > anything which has a EPDC version which I cannot check. > > > > The timing subnode is directly here to avoid having display parameters > > > spread all over the plate. > > > > > > Supplies are organized the same way as in the fbdev driver in the > > > NXP/Freescale kernel forks. The regulators used for that purpose, > > > like the TPS65185, the SY7636A and MAX17135 have typically a single bit to > > > start a bunch of regulators of higher or negative voltage with a > > > well-defined timing. VCOM can be handled separately, but can also be > > > incorporated into that single bit. > > > > > > Signed-off-by: Andreas Kemnade > > > --- > > > .../bindings/display/imx/fsl,mxc-epdc.yaml | 159 ++++++++++++++++++ > > > 1 file changed, 159 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,mxc-epdc.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/display/imx/fsl,mxc-epdc.yaml b/Documentation/devicetree/bindings/display/imx/fsl,mxc-epdc.yaml > > > new file mode 100644 > > > index 000000000000..7e0795cc3f70 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/display/imx/fsl,mxc-epdc.yaml > > > @@ -0,0 +1,159 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/display/imx/fsl,mxc-epdc.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Freescale i.MX6 EPDC > > > + > > > +maintainers: > > > + - Andreas Kemnade > > > + > > > +description: | > > > + The EPDC is a controller for handling electronic paper displays found in > > > + i.MX6 SoCs. > > > + > > > +properties: > > > + compatible: > > > + enum: > > > + - fsl,imx6sl-epdc > > > + - fsl,imx6sll-epdc > > > > Not compatible with each other? > > > differences are detectable by EPDC_VERSION register, so probably so > problem. NXP/Freescale kernel uses > fsl,imx6dl-epdc > and > fsl,imx7d-epdc (used also by imx6 devices with EPDC_VERSION = 3.0) > in their drivers. > > fsl,imx6dl-epdc > fsl,imx6sl-epdc > fsl,imx6sll-epdc > fsl,imx7d-epdc > in their dtsis. > > But the general rule is to use as less as possible compatible strings > if differences can be probed properly, so only one should be > sufficient? Which one? If you can probe all the differences, then just 'fsl,imx-epdc' is sufficient. Just document that so the next time around I don't forget and tell you it needs to be specific. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel