From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AA8BC433F5 for ; Thu, 17 Feb 2022 06:08:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234904AbiBQGI7 (ORCPT ); Thu, 17 Feb 2022 01:08:59 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:49144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234859AbiBQGI6 (ORCPT ); Thu, 17 Feb 2022 01:08:58 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDF03C7D6A; Wed, 16 Feb 2022 22:08:44 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DC820611DE; Thu, 17 Feb 2022 06:08:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57B79C340EB; Thu, 17 Feb 2022 06:08:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645078123; bh=ztO5z3iN5cSQeK67iLz7hEoXVaNMQ6S4MlmQnptMOE0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qc/7GbYzvU09UZz+yxyXWiOptXJNDq7P54syRgq4lWSiMsPTpBknuklYTbnVbhq6U ERaMrs4RGGjz5FXF7IG8YTLCFVwYeqHeqOkjpFjXxx3FTBczkFg60a4PgbFdsajBUh ZNFcOOi0mGH0u+siIItZcnv/LUJ/rsb4JsA89DQ5HnLjuUTNF07SVUlwwkQrYFF84x Z9gzEWGUi2EXE3aAG2YJMmez+3frj2dJElqFXGvOTbzX7PRZVVFZQKWTMJLfoCb6ix iu3KN5iay3/C6VQ9Dx1VYsTyWGNgRL16/SHJr7VLvK/1b8zV4BS1WYMk8TYAxMeGV0 w5npvCwMkd21A== Date: Thu, 17 Feb 2022 11:38:38 +0530 From: Vinod Koul To: Abhinav Kumar Cc: Rob Clark , Jonathan Marek , David Airlie , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Abhinav Kumar , Bjorn Andersson , dri-devel@lists.freedesktop.org, Daniel Vetter , Dmitry Baryshkov , freedreno@lists.freedesktop.org Subject: Re: [Freedreno] [REPOST PATCH v4 07/13] drm/msm/disp/dpu1: Add support for DSC in encoder Message-ID: References: <20220210103423.271016-1-vkoul@kernel.org> <20220210103423.271016-8-vkoul@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 16-02-22, 11:54, Abhinav Kumar wrote: > > +/** > > + * dpu_encoder_helper_get_dsc - get DSC blocks mask for the DPU encoder > > + * This helper function is used by physical encoder to get DSC blocks mask > > + * used for this encoder. > > This looks slightly misaligned to me or not sure if its my mail client. > Please check it once. This looks fine in code as well as in mutt for me.. Maybe client issue -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 893FFC433EF for ; Thu, 17 Feb 2022 06:08:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0E6AF10E708; Thu, 17 Feb 2022 06:08:45 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0B1E910E6FF; Thu, 17 Feb 2022 06:08:44 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7F7C961257; Thu, 17 Feb 2022 06:08:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 57B79C340EB; Thu, 17 Feb 2022 06:08:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645078123; bh=ztO5z3iN5cSQeK67iLz7hEoXVaNMQ6S4MlmQnptMOE0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qc/7GbYzvU09UZz+yxyXWiOptXJNDq7P54syRgq4lWSiMsPTpBknuklYTbnVbhq6U ERaMrs4RGGjz5FXF7IG8YTLCFVwYeqHeqOkjpFjXxx3FTBczkFg60a4PgbFdsajBUh ZNFcOOi0mGH0u+siIItZcnv/LUJ/rsb4JsA89DQ5HnLjuUTNF07SVUlwwkQrYFF84x Z9gzEWGUi2EXE3aAG2YJMmez+3frj2dJElqFXGvOTbzX7PRZVVFZQKWTMJLfoCb6ix iu3KN5iay3/C6VQ9Dx1VYsTyWGNgRL16/SHJr7VLvK/1b8zV4BS1WYMk8TYAxMeGV0 w5npvCwMkd21A== Date: Thu, 17 Feb 2022 11:38:38 +0530 From: Vinod Koul To: Abhinav Kumar Subject: Re: [Freedreno] [REPOST PATCH v4 07/13] drm/msm/disp/dpu1: Add support for DSC in encoder Message-ID: References: <20220210103423.271016-1-vkoul@kernel.org> <20220210103423.271016-8-vkoul@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jonathan Marek , David Airlie , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Abhinav Kumar , Bjorn Andersson , dri-devel@lists.freedesktop.org, Dmitry Baryshkov , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 16-02-22, 11:54, Abhinav Kumar wrote: > > +/** > > + * dpu_encoder_helper_get_dsc - get DSC blocks mask for the DPU encoder > > + * This helper function is used by physical encoder to get DSC blocks mask > > + * used for this encoder. > > This looks slightly misaligned to me or not sure if its my mail client. > Please check it once. This looks fine in code as well as in mutt for me.. Maybe client issue -- ~Vinod