From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45AEFC433F5 for ; Thu, 17 Feb 2022 09:06:23 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3106440150; Thu, 17 Feb 2022 10:06:22 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id E72FE40042 for ; Thu, 17 Feb 2022 10:06:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645088781; x=1676624781; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=A42IZOUQEolUWzUJotlGEWf5aRDW+ep8Xk18GTaDAMc=; b=mZ8s+UnxrM3m2O1F7eNDO/oRfRqVJyulbm+fI/ZJc1pcR3yZ//qPTri4 uGfw232PKYUI0NVT2hq4T16Yi6uU4T1FmxTyiKjqbR/YPGcflztffIkNR 9WJSFkHlTVm76NfcQSUNxYr+t3o5KmCu4irzVejeo9PS6kGGsI7v6Tk8E oS19YwVX52jBhAAUl85kecx5dTua7LkeG7sadRQ+3lTyYIcrE5cTLikT7 yVa8Ge5sfIg6z1RUbCyc3FFz4SlZgHneg1pUjFbETL9R+piqhhCUJQUwD zWPZfbcwqD4QBU8WfzlDj/3dL6e+8HhnPmmMHOLlO/TkGRNzllhwwD727 g==; X-IronPort-AV: E=McAfee;i="6200,9189,10260"; a="251030057" X-IronPort-AV: E=Sophos;i="5.88,375,1635231600"; d="scan'208";a="251030057" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2022 01:06:20 -0800 X-IronPort-AV: E=Sophos;i="5.88,375,1635231600"; d="scan'208";a="545471187" Received: from nsitbons-mobl2.ger.corp.intel.com (HELO bricha3-MOBL.ger.corp.intel.com) ([10.252.22.221]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 17 Feb 2022 01:06:18 -0800 Date: Thu, 17 Feb 2022 09:06:14 +0000 From: Bruce Richardson To: Wenwu Ma Cc: anatoly.burakov@intel.com, dev@dpdk.org, jiayu.hu@intel.com, yinan.wang@intel.com, xingguang.he@intel.com Subject: Re: [PATCH] examples/multi_process: add options to control port configuration Message-ID: References: <20220217151755.442306-1-wenwux.ma@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220217151755.442306-1-wenwux.ma@intel.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Feb 17, 2022 at 03:17:55PM +0000, Wenwu Ma wrote: > The default values of rx mq_mode and rx offloads for port will cause > symmetric_mp startup failure if the port do not support rss or csum. > Therefore, we added two new options --rx-mq-mode and --rx-offloads, > through which the user can set the values appropriately according to the > situation to make app startup normally. > > Signed-off-by: Wenwu Ma --- The idea seems reasonable enough, but I think the implementation requiring the user to pass in special "magic numbers" for the offload values is not a good idea. Perhaps add in a separate flag for "no-csum" to disable that. For the no-rss case, can you explain how you would see this app being used in the absense of RSS support to distribute traffic among the separate processes?