From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE397C433F5 for ; Thu, 17 Feb 2022 14:48:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242082AbiBQOso (ORCPT ); Thu, 17 Feb 2022 09:48:44 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:34038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242061AbiBQOsj (ORCPT ); Thu, 17 Feb 2022 09:48:39 -0500 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FE7A160FDE; Thu, 17 Feb 2022 06:48:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645109304; x=1676645304; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=/a6kPOmK1R4gkycE4EvBWHz/vCQFwiKnu48Rd4yVAA0=; b=jWvXhL/tYb5RneHsiRe+5oH5OXHrywj/8+8/8+dn8J4/zL7gdN0tlFMT wB/J1oROE8H67ZgfLknjFU6/8xGnaTCPhAL/Yov66tbzcTWP11i6SVuKQ Tc67vsgaGcOPVWzdDW6IMNqzmpv63XbgGgoLP6lOts8hpWmKLXe2pJU47 4Wo0ggmJxfBZADNqfkj1j00tQGTocHoLQLU1G1+0xx9hVFYz8nJ1bwERQ x2msxu/jQrVQwZgFPUtvA1HayXhYw9pdFJLysytBSLxswxKbR/cugR+jm 6wVFm/27Y2YeweFM8Qg01LZe4xdZaPcXVaqg+ow+8WQzVCFoKLkJuLCrC g==; X-IronPort-AV: E=McAfee;i="6200,9189,10260"; a="249722768" X-IronPort-AV: E=Sophos;i="5.88,376,1635231600"; d="scan'208";a="249722768" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2022 06:48:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,376,1635231600"; d="scan'208";a="502480195" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.151]) by orsmga006.jf.intel.com with SMTP; 17 Feb 2022 06:48:06 -0800 Received: by stinkbox (sSMTP sendmail emulation); Thu, 17 Feb 2022 16:48:05 +0200 Date: Thu, 17 Feb 2022 16:48:05 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Andrzej Hajda Cc: linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, netdev , Lucas De Marchi , Chris Wilson , Eric Dumazet , Chris Wilson , Jakub Kicinski , Dmitry Vyukov Subject: Re: [Intel-gfx] [PATCH 6/9] drm/i915: Separate wakeref tracking Message-ID: References: <20220217140441.1218045-1-andrzej.hajda@intel.com> <20220217140441.1218045-7-andrzej.hajda@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220217140441.1218045-7-andrzej.hajda@intel.com> X-Patchwork-Hint: comment Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 17, 2022 at 03:04:38PM +0100, Andrzej Hajda wrote: > -static noinline depot_stack_handle_t > +static intel_wakeref_t > track_intel_runtime_pm_wakeref(struct intel_runtime_pm *rpm) > { > - depot_stack_handle_t stack, *stacks; > - unsigned long flags; > - > - if (rpm->no_wakeref_tracking) > - return -1; > - > - stack = __save_depot_stack(); > - if (!stack) > + if (!rpm->available) > return -1; no_wakeref_tracking != available -- Ville Syrjälä Intel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 612C0C433F5 for ; Thu, 17 Feb 2022 14:48:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3A42610E304; Thu, 17 Feb 2022 14:48:27 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8F5E710E304; Thu, 17 Feb 2022 14:48:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645109305; x=1676645305; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=/a6kPOmK1R4gkycE4EvBWHz/vCQFwiKnu48Rd4yVAA0=; b=bq8Li+M+5XvE2/GEJvUgXXA5WUhIKCOp9ZR58Cp1J2buuXAxX89sPwFx 5q+0bNPZjuVxY1hRyTyDCcjAuninWC+caHcQ28Kajfv/L3AZaSq2K5xbM KkTh9u5Rs5YFHbh9DnX+60DAU+zZz8dVKGRLNaIsdiN/qf/UMYCQQaNE6 VkcUYE0rlr4FbML+t4N+pTdFG1ssdnfLRtqIpJfsztjUcherqEP2W8i3q K4ZVLBr9k4YDB7nEsiHM80nZD7elPGan7zlq2YQuIMLMtpV9VOmM9Budz YgP6MOeu65nSkRx6jq35tssC8ES85y87scFovcwb8oqzO0Z55kZWi1Xu7 A==; X-IronPort-AV: E=McAfee;i="6200,9189,10260"; a="251085921" X-IronPort-AV: E=Sophos;i="5.88,376,1635231600"; d="scan'208";a="251085921" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2022 06:48:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,376,1635231600"; d="scan'208";a="502480195" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.151]) by orsmga006.jf.intel.com with SMTP; 17 Feb 2022 06:48:06 -0800 Received: by stinkbox (sSMTP sendmail emulation); Thu, 17 Feb 2022 16:48:05 +0200 Date: Thu, 17 Feb 2022 16:48:05 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Andrzej Hajda Subject: Re: [Intel-gfx] [PATCH 6/9] drm/i915: Separate wakeref tracking Message-ID: References: <20220217140441.1218045-1-andrzej.hajda@intel.com> <20220217140441.1218045-7-andrzej.hajda@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220217140441.1218045-7-andrzej.hajda@intel.com> X-Patchwork-Hint: comment X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev , intel-gfx@lists.freedesktop.org, Lucas De Marchi , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Chris Wilson , Eric Dumazet , Chris Wilson , Jakub Kicinski , Dmitry Vyukov Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Feb 17, 2022 at 03:04:38PM +0100, Andrzej Hajda wrote: > -static noinline depot_stack_handle_t > +static intel_wakeref_t > track_intel_runtime_pm_wakeref(struct intel_runtime_pm *rpm) > { > - depot_stack_handle_t stack, *stacks; > - unsigned long flags; > - > - if (rpm->no_wakeref_tracking) > - return -1; > - > - stack = __save_depot_stack(); > - if (!stack) > + if (!rpm->available) > return -1; no_wakeref_tracking != available -- Ville Syrjälä Intel