From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D92752F23 for ; Sun, 6 Feb 2022 19:01:43 +0000 (UTC) Received: from zn.tnic (dslb-088-067-221-104.088.067.pools.vodafone-ip.de [88.67.221.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id C8E731EC0441; Sun, 6 Feb 2022 20:01:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1644174097; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=ChxamsEn4wVXVgyKqugsP7LdW1mp5Q8UXz53U1t1exI=; b=W7H33NnTuF0YEUxMSx9nd8PnP7sMY8KRbI4CpEqeB6JvNk5Dg8rN6021MmzubsWWibJktB Q3Px8g3dthyfnnteq9VMx1c1DBoG1ZqoinUJL8ZBKBuWxfzIAikUkCzwKR3UDc1xCODOON kgSm9z+VuDVmE7m406H2ipIB07ANU6U= Date: Sun, 6 Feb 2022 20:01:31 +0100 From: Borislav Petkov To: Brijesh Singh Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Michael Roth , Vlastimil Babka , "Kirill A . Shutemov" , Andi Kleen , "Dr . David Alan Gilbert" , brijesh.ksingh@gmail.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, Borislav Petkov Subject: Re: [PATCH v9 35/43] x86/compressed: Export and rename add_identity_map() Message-ID: References: <20220128171804.569796-1-brijesh.singh@amd.com> <20220128171804.569796-36-brijesh.singh@amd.com> Precedence: bulk X-Mailing-List: linux-coco@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220128171804.569796-36-brijesh.singh@amd.com> On Fri, Jan 28, 2022 at 11:17:56AM -0600, Brijesh Singh wrote: > From: Michael Roth > > SEV-specific code will need to add some additional mappings, but doing > this within ident_map_64.c requires some SEV-specific helpers to be > exported and some SEV-specific struct definitions to be pulled into > ident_map_64.c. Instead, export add_identity_map() so SEV-specific (and > other subsystem-specific) code can be better contained outside of > ident_map_64.c. > > While at it, rename the function to kernel_add_identity_map(), similar > to the kernel_ident_mapping_init() function it relies upon. Add here: "No functional changes." -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette