From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF16F2F23 for ; Tue, 8 Feb 2022 13:39:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67BA8C340E9; Tue, 8 Feb 2022 13:39:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644327596; bh=arWyuKrgF6+HTy5MGGr9g1ZYG3YqGe+bpPoKBhwDtjY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iRcMxm2NinrxP0/dQodYfHh7RziJJ6SzP7mzdIkPqhMs3k5TCjS1XddxBIZiBLRWe fwsdHqkyllv+f+u1X7HW1pRH236O9WBWXThRFXUZ3DGcllJJyj+jpn8NGzuMduVmt2 VH9+3pdfzFM+wiZ3119U215A3SNS6eM4zENnhzdV2JsEUAIyTv0hA+0xyYGATs+knD eiR0PPJyCdHewwzmyv7KEe+xE2Y45P468g1Y7LTuTiliKkMrJXkeMtFJ3bAd55MtPd phoE2FDW40WGRPJHyNd45b9VSjxZK9ZOanjsJLzazKAr+DS4Zf4rcVtyQzybCN9V04 WOeQ8tXUTVsFw== Date: Tue, 8 Feb 2022 13:39:22 +0000 From: Mark Brown To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Marek =?iso-8859-1?Q?Beh=FAn?= , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , Michael Turquette , Stephen Boyd , Linus Walleij , Bartosz Golaszewski , Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Markuss Broks , Emma Anholt , David Lechner , Kamlesh Gurudasani , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , Jean Delvare , Guenter Roeck , Dan Robertson , Jonathan Cameron , Lars-Peter Clausen , Michael Hennerich , Marcus Folkesson , Kent Gustavsson , Rui Miguel Silva , Dmitry Torokhov , Pavel Machek , Yasunari Takiguchi , Mauro Carvalho Chehab , Charles-Antoine Couret , Antti Palosaari , Lee Jones , Support Opensource , Charles Keepax , Richard Fitzgerald , Maxime Coquelin , Alexandre Torgue , Arnd Bergmann , Greg Kroah-Hartman , Eric Piel , Ulf Hansson , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Jakub Kicinski , Manivannan Sadhasivam , Thomas Kopp , Florian Fainelli , Andrew Lunn , Vivien Didelot , Vladimir Oltean , Woojung Huh , UNGLinuxDriver@microchip.com, =?utf-8?Q?=C5=81ukasz?= Stelmach , Alexander Aring , Stefan Schmidt , Harry Morris , Varka Bhadram , Xue Liu , Alan Ott , Heiner Kallweit , Russell King , Christian Lamparter , Kalle Valo , Ajay Singh , Claudiu Beznea , Solomon Peachy , Krzysztof Kozlowski , Mark Greer , Benson Leung , Hans de Goede , Mark Gross , Alessandro Zummo , Alexandre Belloni , =?iso-8859-1?B?Suly9G1l?= Pouiller , Jiri Slaby , Felipe Balbi , Daniel Thompson , Jingoo Han , Helge Deller , James Schulman , David Rhodes , Lucas Tanure , Jaroslav Kysela , Takashi Iwai , Nuno =?iso-8859-1?Q?S=E1?= , Liam Girdwood , Daniel Mack , Thomas Zimmermann , Maxime Ripard , Andy Shevchenko , Stephan Gerhold , Alexandru Ardelean , Mike Looijmans , Gwendal Grignou , Cai Huoqing , Minghao Chi , Antoniu Miclaus , Julia Lawall , Ronald =?iso-8859-1?Q?Tschal=E4r?= , Marco Felsch , Jonathan =?iso-8859-1?Q?Neusch=E4fer?= , Emmanuel Gil Peyrot , Jon Hunter , Andrew Morton , Heiko Schocher , Fabio Estevam , Colin Ian King , Dan Carpenter , Tudor Ambarus , Matt Kline , Torin Cooper-Bennun , Vincent Mailhol , Stefan =?iso-8859-1?Q?M=E4tje?= , Frieder Schrempf , Wei Yongjun , Randy Dunlap , Nanyong Sun , Yang Shen , dingsenjie , Aditya Srivastava , Stefan Wahren , Peter Zijlstra , Michael Walle , Yang Li , Geert Uytterhoeven , wengjianfeng , Sidong Yang , Paulo Miguel Almeida , Zhang Qilong , Will Deacon , Mark Tomlinson , Davidlohr Bueso , Claudius Heine , Jiri Prchal , linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-media@vger.kernel.org, patches@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-wpan@vger.kernel.org, linux-wireless@vger.kernel.org, libertas-dev@lists.infradead.org, platform-driver-x86@vger.kernel.org, linux-rtc@vger.kernel.org, linux-spi@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 5/5] spi: make remove callback a void function Message-ID: References: <20220123175201.34839-1-u.kleine-koenig@pengutronix.de> <20220123175201.34839-6-u.kleine-koenig@pengutronix.de> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ef2aNFzDYnZC/zcG" Content-Disposition: inline In-Reply-To: <20220123175201.34839-6-u.kleine-koenig@pengutronix.de> X-Cookie: You will forget that you ever knew me. --ef2aNFzDYnZC/zcG Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 23, 2022 at 06:52:01PM +0100, Uwe Kleine-K=F6nig wrote: > The value returned by an spi driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) >=20 > So change the prototype of the remove function to return no value. This > way driver authors are not tempted to assume that passing an error to > the upper layer is a good idea. All drivers are adapted accordingly. > There is no intended change of behaviour, all callbacks were prepared to > return 0 before. I was going to apply this but it needs rebasing against current code unfortunately. --ef2aNFzDYnZC/zcG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmICcokACgkQJNaLcl1U h9DmcQf+LJZ969n1sCqmHKwy4lQ2Pxdy53x61CG2xi4rHMBDaahnhIqh6OONUbd+ C69P1GRsp8evXqnMb8d4TH1pFPvi3X7mWWwRFhXalhZsYYw/b3jmnQNO7zN81ayi 80hp04WF+UE2A+FJhiN9n9i47vM4FEBcuKxNp9AZNSxwiTfVHUoHAF3UddqF0oAo hThmCBaRZYCQ9dCX1glz8vfrfXVIqRVx30esuamogMGtZbM5bSDoPizzdk83trN4 pfd594g2DUBkpQBHZvadCjp92MBULn5nNnlF5Ob5PAmP1T0NUVsTu7Ra/ZJTnUNb GfkUNfSvLNah+a6BUd3Jp6LazHu9Ew== =bpX2 -----END PGP SIGNATURE----- --ef2aNFzDYnZC/zcG-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98F4DC433EF for ; Tue, 8 Feb 2022 13:40:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=v+NnL6kdG7swMGBMijPUXD21qnS7MbmATvWp9XXpuUo=; b=IRvf4rjusIstFX/wqoqWqmWjrO DLD2Sz2R6uL9QJhLjX2WLZ/c2sSerSa/+TR4MbnquJ4jRtp2jDLaoZDi6WPwQxmcCYWSsv+69IERU DkO40+Nfj44UI2AwGkkHgPV4aPfUWllN84Sg7FxTaIIwk0vTb/UgiFUnaFMJMtsLP46WaPZOhSBan 1kOQHkaUyYtKTgWZYNM82RqeZ24kyddlUHhwACFh1NTRMw26aeENDmx+2ack/+3ryz2ZrJpKQpaCp ezp2GteUOE8afq8Q0b2LrFtE1ZU0lpE5r23PowM6u3AJE0NovRDR7J22KHQoRyxnmJLugZmvTJJEb N+XJdJcw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHQiz-00EAUP-5h; Tue, 08 Feb 2022 13:40:05 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHQis-00EAQc-W3; Tue, 08 Feb 2022 13:40:01 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 136C760B2B; Tue, 8 Feb 2022 13:39:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67BA8C340E9; Tue, 8 Feb 2022 13:39:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644327596; bh=arWyuKrgF6+HTy5MGGr9g1ZYG3YqGe+bpPoKBhwDtjY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iRcMxm2NinrxP0/dQodYfHh7RziJJ6SzP7mzdIkPqhMs3k5TCjS1XddxBIZiBLRWe fwsdHqkyllv+f+u1X7HW1pRH236O9WBWXThRFXUZ3DGcllJJyj+jpn8NGzuMduVmt2 VH9+3pdfzFM+wiZ3119U215A3SNS6eM4zENnhzdV2JsEUAIyTv0hA+0xyYGATs+knD eiR0PPJyCdHewwzmyv7KEe+xE2Y45P468g1Y7LTuTiliKkMrJXkeMtFJ3bAd55MtPd phoE2FDW40WGRPJHyNd45b9VSjxZK9ZOanjsJLzazKAr+DS4Zf4rcVtyQzybCN9V04 WOeQ8tXUTVsFw== Date: Tue, 8 Feb 2022 13:39:22 +0000 From: Mark Brown To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Marek =?iso-8859-1?Q?Beh=FAn?= , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , Michael Turquette , Stephen Boyd , Linus Walleij , Bartosz Golaszewski , Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Markuss Broks , Emma Anholt , David Lechner , Kamlesh Gurudasani , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , Jean Delvare , Guenter Roeck , Dan Robertson , Jonathan Cameron , Lars-Peter Clausen , Michael Hennerich , Marcus Folkesson , Kent Gustavsson , Rui Miguel Silva , Dmitry Torokhov , Pavel Machek , Yasunari Takiguchi , Mauro Carvalho Chehab , Charles-Antoine Couret , Antti Palosaari , Lee Jones , Support Opensource , Charles Keepax , Richard Fitzgerald , Maxime Coquelin , Alexandre Torgue , Arnd Bergmann , Greg Kroah-Hartman , Eric Piel , Ulf Hansson , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Jakub Kicinski , Manivannan Sadhasivam , Thomas Kopp , Florian Fainelli , Andrew Lunn , Vivien Didelot , Vladimir Oltean , Woojung Huh , UNGLinuxDriver@microchip.com, =?utf-8?Q?=C5=81ukasz?= Stelmach , Alexander Aring , Stefan Schmidt , Harry Morris , Varka Bhadram , Xue Liu , Alan Ott , Heiner Kallweit , Russell King , Christian Lamparter , Kalle Valo , Ajay Singh , Claudiu Beznea , Solomon Peachy , Krzysztof Kozlowski , Mark Greer , Benson Leung , Hans de Goede , Mark Gross , Alessandro Zummo , Alexandre Belloni , =?iso-8859-1?B?Suly9G1l?= Pouiller , Jiri Slaby , Felipe Balbi , Daniel Thompson , Jingoo Han , Helge Deller , James Schulman , David Rhodes , Lucas Tanure , Jaroslav Kysela , Takashi Iwai , Nuno =?iso-8859-1?Q?S=E1?= , Liam Girdwood , Daniel Mack , Thomas Zimmermann , Maxime Ripard , Andy Shevchenko , Stephan Gerhold , Alexandru Ardelean , Mike Looijmans , Gwendal Grignou , Cai Huoqing , Minghao Chi , Antoniu Miclaus , Julia Lawall , Ronald =?iso-8859-1?Q?Tschal=E4r?= , Marco Felsch , Jonathan =?iso-8859-1?Q?Neusch=E4fer?= , Emmanuel Gil Peyrot , Jon Hunter , Andrew Morton , Heiko Schocher , Fabio Estevam , Colin Ian King , Dan Carpenter , Tudor Ambarus , Matt Kline , Torin Cooper-Bennun , Vincent Mailhol , Stefan =?iso-8859-1?Q?M=E4tje?= , Frieder Schrempf , Wei Yongjun , Randy Dunlap , Nanyong Sun , Yang Shen , dingsenjie , Aditya Srivastava , Stefan Wahren , Peter Zijlstra , Michael Walle , Yang Li , Geert Uytterhoeven , wengjianfeng , Sidong Yang , Paulo Miguel Almeida , Zhang Qilong , Will Deacon , Mark Tomlinson , Davidlohr Bueso , Claudius Heine , Jiri Prchal , linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-media@vger.kernel.org, patches@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-wpan@vger.kernel.org, linux-wireless@vger.kernel.org, libertas-dev@lists.infradead.org, platform-driver-x86@vger.kernel.org, linux-rtc@vger.kernel.org, linux-spi@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 5/5] spi: make remove callback a void function Message-ID: References: <20220123175201.34839-1-u.kleine-koenig@pengutronix.de> <20220123175201.34839-6-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 In-Reply-To: <20220123175201.34839-6-u.kleine-koenig@pengutronix.de> X-Cookie: You will forget that you ever knew me. X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220208_053959_154262_C673AB56 X-CRM114-Status: GOOD ( 21.30 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5801107612965452985==" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org --===============5801107612965452985== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ef2aNFzDYnZC/zcG" Content-Disposition: inline --ef2aNFzDYnZC/zcG Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 23, 2022 at 06:52:01PM +0100, Uwe Kleine-K=F6nig wrote: > The value returned by an spi driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) >=20 > So change the prototype of the remove function to return no value. This > way driver authors are not tempted to assume that passing an error to > the upper layer is a good idea. All drivers are adapted accordingly. > There is no intended change of behaviour, all callbacks were prepared to > return 0 before. I was going to apply this but it needs rebasing against current code unfortunately. --ef2aNFzDYnZC/zcG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmICcokACgkQJNaLcl1U h9DmcQf+LJZ969n1sCqmHKwy4lQ2Pxdy53x61CG2xi4rHMBDaahnhIqh6OONUbd+ C69P1GRsp8evXqnMb8d4TH1pFPvi3X7mWWwRFhXalhZsYYw/b3jmnQNO7zN81ayi 80hp04WF+UE2A+FJhiN9n9i47vM4FEBcuKxNp9AZNSxwiTfVHUoHAF3UddqF0oAo hThmCBaRZYCQ9dCX1glz8vfrfXVIqRVx30esuamogMGtZbM5bSDoPizzdk83trN4 pfd594g2DUBkpQBHZvadCjp92MBULn5nNnlF5Ob5PAmP1T0NUVsTu7Ra/ZJTnUNb GfkUNfSvLNah+a6BUd3Jp6LazHu9Ew== =bpX2 -----END PGP SIGNATURE----- --ef2aNFzDYnZC/zcG-- --===============5801107612965452985== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ --===============5801107612965452985==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9138AC433F5 for ; Wed, 9 Feb 2022 08:39:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AFB4510E295; Wed, 9 Feb 2022 08:39:54 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4963210E322 for ; Tue, 8 Feb 2022 13:39:58 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 136C760B2B; Tue, 8 Feb 2022 13:39:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67BA8C340E9; Tue, 8 Feb 2022 13:39:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644327596; bh=arWyuKrgF6+HTy5MGGr9g1ZYG3YqGe+bpPoKBhwDtjY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iRcMxm2NinrxP0/dQodYfHh7RziJJ6SzP7mzdIkPqhMs3k5TCjS1XddxBIZiBLRWe fwsdHqkyllv+f+u1X7HW1pRH236O9WBWXThRFXUZ3DGcllJJyj+jpn8NGzuMduVmt2 VH9+3pdfzFM+wiZ3119U215A3SNS6eM4zENnhzdV2JsEUAIyTv0hA+0xyYGATs+knD eiR0PPJyCdHewwzmyv7KEe+xE2Y45P468g1Y7LTuTiliKkMrJXkeMtFJ3bAd55MtPd phoE2FDW40WGRPJHyNd45b9VSjxZK9ZOanjsJLzazKAr+DS4Zf4rcVtyQzybCN9V04 WOeQ8tXUTVsFw== Date: Tue, 8 Feb 2022 13:39:22 +0000 From: Mark Brown To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH 5/5] spi: make remove callback a void function Message-ID: References: <20220123175201.34839-1-u.kleine-koenig@pengutronix.de> <20220123175201.34839-6-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ef2aNFzDYnZC/zcG" Content-Disposition: inline In-Reply-To: <20220123175201.34839-6-u.kleine-koenig@pengutronix.de> X-Cookie: You will forget that you ever knew me. X-Mailman-Approved-At: Wed, 09 Feb 2022 08:39:54 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Gwendal Grignou , Yasunari Takiguchi , Claudius Heine , Geert Uytterhoeven , Nanyong Sun , dri-devel@lists.freedesktop.org, Jaroslav Kysela , Frieder Schrempf , Pavel Machek , Miquel Raynal , Christian Lamparter , Ajay Singh , linux-clk@vger.kernel.org, Stefan Schmidt , Sidong Yang , libertas-dev@lists.infradead.org, linux-omap@vger.kernel.org, Guenter Roeck , Jean Delvare , linux-serial@vger.kernel.org, =?utf-8?Q?=C5=81ukasz?= Stelmach , Mark Tomlinson , James Schulman , Kamlesh Gurudasani , Jingoo Han , Zhang Qilong , Randy Dunlap , linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Michael Walle , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , kernel@pengutronix.de, Greg Kroah-Hartman , linux-mtd@lists.infradead.org, Andrew Morton , Vladimir Oltean , linux-wpan@vger.kernel.org, Claudiu Beznea , Alexandre Belloni , Dan Robertson , Markuss Broks , Lucas Tanure , David Airlie , linux-wireless@vger.kernel.org, Marco Felsch , David Rhodes , Thierry Reding , Solomon Peachy , Marek =?iso-8859-1?Q?Beh=FAn?= , Krzysztof Kozlowski , Emmanuel Gil Peyrot , Jiri Slaby , Bartosz Golaszewski , Tudor Ambarus , Minghao Chi , Jon Hunter , dingsenjie , Heiko Schocher , Wolfgang Grandegger , Matt Kline , Woojung Huh , Charles Keepax , Michael Hennerich , Mike Looijmans , Ronald =?iso-8859-1?Q?Tschal=E4r?= , Daniel Thompson , linux-can@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Hans de Goede , Stephen Boyd , Davidlohr Bueso , UNGLinuxDriver@microchip.com, Jarkko Sakkinen , linux-usb@vger.kernel.org, Maxime Coquelin , linux-integrity@vger.kernel.org, Jonathan Cameron , Heiner Kallweit , Ulf Hansson , linux-staging@lists.linux.dev, linux-iio@vger.kernel.org, Michael Turquette , alsa-devel@alsa-project.org, Nuno =?iso-8859-1?Q?S=E1?= , netdev@vger.kernel.org, Wei Yongjun , Sam Ravnborg , =?iso-8859-1?B?Suly9G1l?= Pouiller , linux-rtc@vger.kernel.org, Marcus Folkesson , Florian Fainelli , Aditya Srivastava , Varka Bhadram , wengjianfeng , linux-input@vger.kernel.org, linux-media@vger.kernel.org, Arnd Bergmann , Jonathan =?iso-8859-1?Q?Neusch=E4fer?= , Mark Greer , Mark Gross , Richard Fitzgerald , linux-fbdev@vger.kernel.org, Mauro Carvalho Chehab , Stefan =?iso-8859-1?Q?M=E4tje?= , linux-hwmon@vger.kernel.org, Felipe Balbi , Paulo Miguel Almeida , Support Opensource , Dmitry Torokhov , linux-mmc@vger.kernel.org, Liam Girdwood , Julia Lawall , Yang Li , Dan Carpenter , patches@opensource.cirrus.com, Kent Gustavsson , "David S. Miller" , Charles-Antoine Couret , Alexander Aring , Jiri Prchal , Vignesh Raghavendra , Emma Anholt , Peter Zijlstra , Alexandre Torgue , Alexandru Ardelean , Antoniu Miclaus , Peter Huewe , Torin Cooper-Bennun , Lee Jones , linux-leds@vger.kernel.org, Eric Piel , Stephan Gerhold , Richard Weinberger , Russell King , Jason Gunthorpe , Thomas Kopp , Jakub Kicinski , Vivien Didelot , platform-driver-x86@vger.kernel.org, Stefan Wahren , Xue Liu , David Lechner , Will Deacon , Manivannan Sadhasivam , Kalle Valo , Rui Miguel Silva , Marc Kleine-Budde , Harry Morris , Andy Shevchenko , Vincent Mailhol , Alessandro Zummo , Yang Shen , Thomas Zimmermann , Takashi Iwai , Cai Huoqing , Daniel Mack , Colin Ian King , Helge Deller , Alan Ott Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --ef2aNFzDYnZC/zcG Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 23, 2022 at 06:52:01PM +0100, Uwe Kleine-K=F6nig wrote: > The value returned by an spi driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) >=20 > So change the prototype of the remove function to return no value. This > way driver authors are not tempted to assume that passing an error to > the upper layer is a good idea. All drivers are adapted accordingly. > There is no intended change of behaviour, all callbacks were prepared to > return 0 before. I was going to apply this but it needs rebasing against current code unfortunately. --ef2aNFzDYnZC/zcG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmICcokACgkQJNaLcl1U h9DmcQf+LJZ969n1sCqmHKwy4lQ2Pxdy53x61CG2xi4rHMBDaahnhIqh6OONUbd+ C69P1GRsp8evXqnMb8d4TH1pFPvi3X7mWWwRFhXalhZsYYw/b3jmnQNO7zN81ayi 80hp04WF+UE2A+FJhiN9n9i47vM4FEBcuKxNp9AZNSxwiTfVHUoHAF3UddqF0oAo hThmCBaRZYCQ9dCX1glz8vfrfXVIqRVx30esuamogMGtZbM5bSDoPizzdk83trN4 pfd594g2DUBkpQBHZvadCjp92MBULn5nNnlF5Ob5PAmP1T0NUVsTu7Ra/ZJTnUNb GfkUNfSvLNah+a6BUd3Jp6LazHu9Ew== =bpX2 -----END PGP SIGNATURE----- --ef2aNFzDYnZC/zcG-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 385C7C433EF for ; Wed, 9 Feb 2022 09:09:48 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 555E3189E; Wed, 9 Feb 2022 10:08:56 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 555E3189E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1644397786; bh=arWyuKrgF6+HTy5MGGr9g1ZYG3YqGe+bpPoKBhwDtjY=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=sUcS3S68gXFsh3HXeghgeebK1S11p9hi7G7pOhqsOoQnSzw4hX7SdDCtZx+h3hNYT 7I2cbl6Ut4JVoNeGVv4DWcENoIN5ui0Nx7uQsJcj4X+dLVAXY6ADjlss3WV02xYpIC mBGsApCv9gMbp4LWrv2biVq/oy4mb5NLYYH+8jPk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 698E9F80508; Wed, 9 Feb 2022 10:08:06 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2FB63F8013C; Tue, 8 Feb 2022 14:40:03 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1824EF800EB for ; Tue, 8 Feb 2022 14:39:59 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1824EF800EB Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iRcMxm2N" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1172D60B28; Tue, 8 Feb 2022 13:39:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67BA8C340E9; Tue, 8 Feb 2022 13:39:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644327596; bh=arWyuKrgF6+HTy5MGGr9g1ZYG3YqGe+bpPoKBhwDtjY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iRcMxm2NinrxP0/dQodYfHh7RziJJ6SzP7mzdIkPqhMs3k5TCjS1XddxBIZiBLRWe fwsdHqkyllv+f+u1X7HW1pRH236O9WBWXThRFXUZ3DGcllJJyj+jpn8NGzuMduVmt2 VH9+3pdfzFM+wiZ3119U215A3SNS6eM4zENnhzdV2JsEUAIyTv0hA+0xyYGATs+knD eiR0PPJyCdHewwzmyv7KEe+xE2Y45P468g1Y7LTuTiliKkMrJXkeMtFJ3bAd55MtPd phoE2FDW40WGRPJHyNd45b9VSjxZK9ZOanjsJLzazKAr+DS4Zf4rcVtyQzybCN9V04 WOeQ8tXUTVsFw== Date: Tue, 8 Feb 2022 13:39:22 +0000 From: Mark Brown To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH 5/5] spi: make remove callback a void function Message-ID: References: <20220123175201.34839-1-u.kleine-koenig@pengutronix.de> <20220123175201.34839-6-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ef2aNFzDYnZC/zcG" Content-Disposition: inline In-Reply-To: <20220123175201.34839-6-u.kleine-koenig@pengutronix.de> X-Cookie: You will forget that you ever knew me. X-Mailman-Approved-At: Wed, 09 Feb 2022 10:08:04 +0100 Cc: Andrew Lunn , Gwendal Grignou , Yasunari Takiguchi , Claudius Heine , Geert Uytterhoeven , Nanyong Sun , Linus Walleij , dri-devel@lists.freedesktop.org, Frieder Schrempf , Pavel Machek , Miquel Raynal , Christian Lamparter , Ajay Singh , linux-clk@vger.kernel.org, Stefan Schmidt , Sidong Yang , libertas-dev@lists.infradead.org, linux-omap@vger.kernel.org, Antti Palosaari , Guenter Roeck , Jean Delvare , linux-serial@vger.kernel.org, =?utf-8?Q?=C5=81ukasz?= Stelmach , Mark Tomlinson , James Schulman , Kamlesh Gurudasani , Jingoo Han , Zhang Qilong , Randy Dunlap , linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Michael Walle , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , kernel@pengutronix.de, Greg Kroah-Hartman , linux-mtd@lists.infradead.org, Andrew Morton , Vladimir Oltean , linux-wpan@vger.kernel.org, Claudiu Beznea , Alexandre Belloni , Dan Robertson , Markuss Broks , Lucas Tanure , David Airlie , linux-wireless@vger.kernel.org, Marco Felsch , David Rhodes , Thierry Reding , Solomon Peachy , Marek =?iso-8859-1?Q?Beh=FAn?= , Lars-Peter Clausen , Krzysztof Kozlowski , Emmanuel Gil Peyrot , Jiri Slaby , Helge Deller , Tudor Ambarus , Minghao Chi , Jon Hunter , dingsenjie , Heiko Schocher , Wolfgang Grandegger , Matt Kline , Woojung Huh , Charles Keepax , Michael Hennerich , Mike Looijmans , Ronald =?iso-8859-1?Q?Tschal=E4r?= , Daniel Thompson , Maxime Ripard , linux-can@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Hans de Goede , Stephen Boyd , Davidlohr Bueso , UNGLinuxDriver@microchip.com, Jarkko Sakkinen , linux-usb@vger.kernel.org, Maxime Coquelin , linux-integrity@vger.kernel.org, Jonathan Cameron , Heiner Kallweit , Ulf Hansson , linux-staging@lists.linux.dev, linux-iio@vger.kernel.org, Michael Turquette , alsa-devel@alsa-project.org, Nuno =?iso-8859-1?Q?S=E1?= , netdev@vger.kernel.org, Wei Yongjun , Sam Ravnborg , =?iso-8859-1?B?Suly9G1l?= Pouiller , linux-rtc@vger.kernel.org, Marcus Folkesson , Florian Fainelli , Aditya Srivastava , Varka Bhadram , wengjianfeng , linux-input@vger.kernel.org, linux-media@vger.kernel.org, Arnd Bergmann , Jonathan =?iso-8859-1?Q?Neusch=E4fer?= , Mark Greer , Mark Gross , Richard Fitzgerald , linux-fbdev@vger.kernel.org, Mauro Carvalho Chehab , Benson Leung , Stefan =?iso-8859-1?Q?M=E4tje?= , linux-hwmon@vger.kernel.org, Felipe Balbi , Paulo Miguel Almeida , Support Opensource , Dmitry Torokhov , linux-mmc@vger.kernel.org, Liam Girdwood , Julia Lawall , Yang Li , Dan Carpenter , patches@opensource.cirrus.com, Kent Gustavsson , "David S. Miller" , Charles-Antoine Couret , Alexander Aring , Jiri Prchal , Vignesh Raghavendra , Emma Anholt , Peter Zijlstra , Alexandre Torgue , Alexandru Ardelean , Antoniu Miclaus , Peter Huewe , Torin Cooper-Bennun , Lee Jones , linux-leds@vger.kernel.org, Eric Piel , Stephan Gerhold , Richard Weinberger , Russell King , Jason Gunthorpe , Thomas Kopp , Jakub Kicinski , Vivien Didelot , platform-driver-x86@vger.kernel.org, Stefan Wahren , Xue Liu , David Lechner , Will Deacon , Manivannan Sadhasivam , Kalle Valo , Rui Miguel Silva , Marc Kleine-Budde , Fabio Estevam , Harry Morris , Andy Shevchenko , Vincent Mailhol , Alessandro Zummo , Yang Shen , Thomas Zimmermann , Takashi Iwai , Cai Huoqing , Daniel Mack , Daniel Vetter , Colin Ian King , Bartosz Golaszewski , Alan Ott X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --ef2aNFzDYnZC/zcG Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 23, 2022 at 06:52:01PM +0100, Uwe Kleine-K=F6nig wrote: > The value returned by an spi driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) >=20 > So change the prototype of the remove function to return no value. This > way driver authors are not tempted to assume that passing an error to > the upper layer is a good idea. All drivers are adapted accordingly. > There is no intended change of behaviour, all callbacks were prepared to > return 0 before. I was going to apply this but it needs rebasing against current code unfortunately. --ef2aNFzDYnZC/zcG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmICcokACgkQJNaLcl1U h9DmcQf+LJZ969n1sCqmHKwy4lQ2Pxdy53x61CG2xi4rHMBDaahnhIqh6OONUbd+ C69P1GRsp8evXqnMb8d4TH1pFPvi3X7mWWwRFhXalhZsYYw/b3jmnQNO7zN81ayi 80hp04WF+UE2A+FJhiN9n9i47vM4FEBcuKxNp9AZNSxwiTfVHUoHAF3UddqF0oAo hThmCBaRZYCQ9dCX1glz8vfrfXVIqRVx30esuamogMGtZbM5bSDoPizzdk83trN4 pfd594g2DUBkpQBHZvadCjp92MBULn5nNnlF5Ob5PAmP1T0NUVsTu7Ra/ZJTnUNb GfkUNfSvLNah+a6BUd3Jp6LazHu9Ew== =bpX2 -----END PGP SIGNATURE----- --ef2aNFzDYnZC/zcG--