All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: David Airlie <airlied@linux.ie>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	Luca Abeni <lucabe72@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [Intel-gfx] [PATCH 7/8] drm/i915: Disable tracing points on PREEMPT_RT
Date: Tue, 8 Feb 2022 18:32:34 +0100	[thread overview]
Message-ID: <YgKpMufo+dYSLPIl@linutronix.de> (raw)
In-Reply-To: <20211214115837.6f33a9b2@gandalf.local.home>

On 2021-12-14 11:58:37 [-0500], Steven Rostedt wrote:
> On Tue, 14 Dec 2021 18:34:50 +0200
> Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> 
> > Looks lightly tedious. Can't we have "slow" (or whatever) versions of
> > the trace macros so we could just declare these the same was as before
> > without having to manually write that wrapper for every event?
> 
> That would be quite tedious as well ;-)
…
> It may be possible to do, but it will be far from trivial, and I'm not sure
> I want this to be an easy option. Locks should not be taken from trace
> events in general, as they are not tested with lockdep when the trace
> points are not enabled, and could hide deadlocks that may not appear until
> running on production.

So we disable the tracing points or try what Steven suggested?

> -- Steve

Sebastian

  reply	other threads:[~2022-02-08 17:39 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-14 14:02 [PATCH 0/8] drm/i915: PREEMPT_RT related fixups Sebastian Andrzej Siewior
2021-12-14 14:02 ` [Intel-gfx] " Sebastian Andrzej Siewior
2021-12-14 14:02 ` [PATCH 1/8] drm/i915: Drop the irqs_disabled() check Sebastian Andrzej Siewior
2021-12-14 14:02   ` [Intel-gfx] " Sebastian Andrzej Siewior
2021-12-14 14:02 ` [PATCH 2/8] drm/i915/gt: Queue and wait for the irq_work item Sebastian Andrzej Siewior
2021-12-14 14:02   ` [Intel-gfx] " Sebastian Andrzej Siewior
2021-12-14 14:02 ` [PATCH 3/8] drm/i915/gt: Use spin_lock_irq() instead of local_irq_disable() + spin_lock() Sebastian Andrzej Siewior
2021-12-14 14:02   ` [Intel-gfx] " Sebastian Andrzej Siewior
2021-12-14 14:02 ` [PATCH 4/8] drm/i915: Use preempt_disable/enable_rt() where recommended Sebastian Andrzej Siewior
2021-12-14 14:02   ` [Intel-gfx] " Sebastian Andrzej Siewior
2022-01-26 23:29   ` Mario Kleiner
2022-01-26 23:29     ` [Intel-gfx] " Mario Kleiner
2022-02-11  8:44     ` Sebastian Andrzej Siewior
2022-02-11  8:44       ` [Intel-gfx] " Sebastian Andrzej Siewior
2022-02-14 18:38       ` Mario Kleiner
2022-02-14 18:38         ` [Intel-gfx] " Mario Kleiner
2021-12-14 14:02 ` [PATCH 5/8] drm/i915: Don't disable interrupts on PREEMPT_RT during atomic updates Sebastian Andrzej Siewior
2021-12-14 14:02   ` [Intel-gfx] " Sebastian Andrzej Siewior
2021-12-14 14:02 ` [PATCH 6/8] drm/i915: Don't check for atomic context on PREEMPT_RT Sebastian Andrzej Siewior
2021-12-14 14:02   ` [Intel-gfx] " Sebastian Andrzej Siewior
2021-12-14 14:03 ` [PATCH 7/8] drm/i915: Disable tracing points " Sebastian Andrzej Siewior
2021-12-14 14:03   ` [Intel-gfx] " Sebastian Andrzej Siewior
2021-12-14 14:36   ` Steven Rostedt
2021-12-14 14:36     ` [Intel-gfx] " Steven Rostedt
2021-12-14 15:41     ` Jani Nikula
2021-12-14 15:41       ` [Intel-gfx] " Jani Nikula
2021-12-14 15:56     ` Sebastian Andrzej Siewior
2021-12-14 15:56       ` [Intel-gfx] " Sebastian Andrzej Siewior
2021-12-14 16:34     ` Ville Syrjälä
2021-12-14 16:58       ` Steven Rostedt
2022-02-08 17:32         ` Sebastian Andrzej Siewior [this message]
2021-12-14 14:03 ` [PATCH 8/8] drm/i915: skip DRM_I915_LOW_LEVEL_TRACEPOINTS with NOTRACE Sebastian Andrzej Siewior
2021-12-14 14:03   ` [Intel-gfx] " Sebastian Andrzej Siewior
2021-12-14 15:58 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: PREEMPT_RT related fixups. (rev4) Patchwork
2021-12-14 16:12   ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YgKpMufo+dYSLPIl@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lucabe72@gmail.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.