From: Rob Herring <robh@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
Oliver Neukum <oneukum@suse.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH net-next v1 2/4] dt-bindings: net: add schema for Microchip/SMSC LAN95xx USB Ethernet controllers
Date: Tue, 8 Feb 2022 21:47:41 -0600 [thread overview]
Message-ID: <YgM5XSwmiQi5XbW/@robh.at.kernel.org> (raw)
In-Reply-To: <YfJ6/xdacR59Jvq+@kroah.com>
On Thu, Jan 27, 2022 at 11:59:11AM +0100, Greg KH wrote:
> On Thu, Jan 27, 2022 at 11:49:03AM +0100, Oleksij Rempel wrote:
> > Create initial schema for Microchip/SMSC LAN95xx USB Ethernet controllers and
> > import all currently supported USB IDs form drivers/net/usb/smsc95xx.c
>
> That is a loosing game to play. There is a reason that kernel drivers
> only require a device id in 1 place, instead of multiple places like
> other operating systems. Please do not go back and make the same
> mistakes others have.
This instance doesn't look so bad because SMSC devices are chips rather
than random OEM rebranded devices all with the same underlying chip.
> Not to mention that I think overall this is a bad idea anyway. USB
> devices are self-describing, don't add them to DT.
Until they are soldered down and the board maker cheaps out on having an
eeprom to hold the MAC address...
Rob
next prev parent reply other threads:[~2022-02-09 4:11 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 10:49 [PATCH net-next v1 0/4] usbnet: add "label" support Oleksij Rempel
2022-01-27 10:49 ` [PATCH net-next v1 1/4] dt-bindings: net: add schema for ASIX USB Ethernet controllers Oleksij Rempel
2022-01-27 10:59 ` Greg KH
2022-02-03 13:21 ` Oliver Neukum
2022-02-09 3:41 ` Rob Herring
2022-01-27 10:49 ` [PATCH net-next v1 2/4] dt-bindings: net: add schema for Microchip/SMSC LAN95xx " Oleksij Rempel
2022-01-27 10:59 ` Greg KH
2022-01-27 11:28 ` Oleksij Rempel
2022-02-09 3:47 ` Rob Herring [this message]
2022-01-27 14:03 ` Rob Herring
2022-01-27 10:49 ` [PATCH net-next v1 3/4] dt-bindings: net: add "label" property for all usbnet " Oleksij Rempel
2022-02-09 3:51 ` Rob Herring
2022-01-27 10:49 ` [PATCH net-next v1 4/4] usbnet: add support for label from device tree Oleksij Rempel
2022-01-27 10:57 ` Greg KH
2022-01-27 11:23 ` Oleksij Rempel
2022-01-27 11:30 ` Greg KH
2022-01-27 12:00 ` Oleksij Rempel
2022-01-27 13:21 ` Greg KH
2022-01-27 14:01 ` Lucas Stach
2022-02-03 0:12 ` Sergey Ryazanov
2022-02-03 2:20 ` Sergey Ryazanov
2022-02-03 13:04 ` Andrew Lunn
2022-02-03 14:20 ` Greg KH
2022-01-27 14:28 ` Andrew Lunn
2022-02-09 4:00 ` Rob Herring
2022-01-27 10:57 ` [PATCH net-next v1 0/4] usbnet: add "label" support Greg KH
2022-02-03 9:34 ` Oliver Neukum
2022-02-03 10:27 ` Oleksij Rempel
2022-02-03 13:16 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgM5XSwmiQi5XbW/@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.